Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Sequence to Task for RecoLocalCalo config files #27474

Merged
merged 7 commits into from
Jul 14, 2019
Merged

Move Sequence to Task for RecoLocalCalo config files #27474

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0ce884a
Move Sequence to Task RecoLocalCalo configuration
jeongeun Jul 8, 2019
45e7790
Moving Sequence to Task RecoLocalCalo configuration
jeongeun Jul 8, 2019
eedb232
fix error
jeongeun Jul 10, 2019
8f76492
fix : removing unused sequence
jeongeun Jul 12, 2019
7393aee
Merge branch 'MoveSeqToTask' of https://github.com/jeongeun/cmssw int…
jeongeun Jul 12, 2019
6c4f5df
Removing unused sequences
jeongeun Jul 12, 2019
3bdd662
slove issue with wf 101
jeongeun Jul 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions RecoLocalCalo/Configuration/python/RecoLocalCalo_Commissioning_cff.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,13 @@
#
# sequence CaloLocalReco and CaloGlobalReco
#
calolocalreco = cms.Sequence(ecalLocalRecoSequence+hcalLocalRecoSequence)
calolocalrecoTask = cms.Task(ecalLocalRecoTask,hcalLocalRecoTask)
calolocalreco = cms.Sequence(calolocalrecoTask)
caloglobalreco = cms.Sequence(hcalGlobalRecoSequence)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not also migrating this sequence?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your every comments.
I kept this sequence that have one module(hbhereco).
In this PR, I modified the sequences that has more than one modules.

In cmssw/RecoLocalCalo/Configuration/python/hcalGlobalReco_cff.py
from RecoLocalCalo.HcalRecProducers.HBHEIsolatedNoiseReflagger_cfi import *
hcalGlobalRecoSequence = cms.Sequence(hbhereco)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, this sequence is never used, it only includes hcalGlobalRecoSequence from RecoLocalCalo/Configuration/python/hcalGlobalReco_cff.py (which in its turn is only used for the globalreco_tracking reconstruction sequence) and it can be misleading here: I would suggest to just remove it


#
# R.Ofierzynski (29.Oct.2009): add NZS sequence
#
from RecoLocalCalo.Configuration.hcalLocalRecoNZS_cff import *
calolocalrecoNZS = cms.Sequence(ecalLocalRecoSequence+hcalLocalRecoSequence+hcalLocalRecoSequenceNZS)
calolocalrecoTaskNZS = cms.Task(ecalLocalRecoTask,hcalLocalRecoTask,hcalLocalRecoTaskNZS)
calolocalrecoNZS = cms.Sequence(calolocalrecoTaskNZS)
29 changes: 15 additions & 14 deletions RecoLocalCalo/Configuration/python/RecoLocalCalo_Cosmics_cff.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,31 +80,32 @@ def hbheCosmic(module):
from RecoLocalCalo.HcalRecProducers.hbheplan1_cfi import hbheplan1

# redefine hcal sequence
hcalLocalRecoSequence = cms.Sequence(hbhereco+hfreco+horeco+zdcreco)
hcalLocalRecoTask = cms.Task(hbhereco,hfreco,horeco,zdcreco)
hcalLocalRecoSequence = cms.Sequence(hcalLocalRecoTask)

_phase1_hcalLocalRecoSequence = hcalLocalRecoSequence.copy()
_phase1_hcalLocalRecoSequence.insert(0,hfprereco)
run2_HF_2017.toReplaceWith(hcalLocalRecoSequence, _phase1_hcalLocalRecoSequence)
_phase1_hcalLocalRecoTask = hcalLocalRecoTask.copy()
_phase1_hcalLocalRecoTask.add(hfprereco)
run2_HF_2017.toReplaceWith(hcalLocalRecoTask, _phase1_hcalLocalRecoTask)

# shuffle modules so "hbheplan1" produces final collection of hits named "hbhereco"
_plan1_hcalLocalRecoSequence = _phase1_hcalLocalRecoSequence.copy()
_plan1_hcalLocalRecoTask = _phase1_hcalLocalRecoTask.copy()
hbheprereco = hbhereco.clone()
_plan1_hcalLocalRecoSequence.insert(0,hbheprereco)
_plan1_hcalLocalRecoTask.add(hbheprereco)
from Configuration.Eras.Modifier_run2_HEPlan1_2017_cff import run2_HEPlan1_2017
run2_HEPlan1_2017.toReplaceWith(hbhereco, hbheplan1)
run2_HEPlan1_2017.toReplaceWith(hcalLocalRecoSequence, _plan1_hcalLocalRecoSequence)
run2_HEPlan1_2017.toReplaceWith(hcalLocalRecoTask, _plan1_hcalLocalRecoTask)

hbhecollapse = hbheplan1.clone()
_collapse_hcalLocalRecoSequence = _phase1_hcalLocalRecoSequence.copy()
_collapse_hcalLocalRecoSequence.insert(0,hbheprereco)
_collapse_hcalLocalRecoTask = _phase1_hcalLocalRecoTask.copy()
_collapse_hcalLocalRecoTask.add(hbheprereco)
from Configuration.ProcessModifiers.run2_HECollapse_2018_cff import run2_HECollapse_2018
run2_HECollapse_2018.toReplaceWith(hbhereco, hbhecollapse)
run2_HECollapse_2018.toReplaceWith(hcalLocalRecoSequence, _collapse_hcalLocalRecoSequence)

calolocalrecoCosmics = cms.Sequence(ecalLocalRecoSequenceCosmics+hcalLocalRecoSequence)

run2_HECollapse_2018.toReplaceWith(hcalLocalRecoTask, _collapse_hcalLocalRecoTask)
calolocalrecoTaskCosmics = cms.Task(ecalLocalRecoTaskCosmics,hcalLocalRecoTask)
calolocalrecoCosmics = cms.Sequence(calolocalrecoTaskCosmics)
#
# R.Ofierzynski (29.Oct.2009): add NZS sequence
#
from RecoLocalCalo.Configuration.hcalLocalRecoNZS_cff import *
calolocalrecoCosmicsNZS = cms.Sequence(ecalLocalRecoSequenceCosmics+hcalLocalRecoSequence+hcalLocalRecoSequenceNZS)
calolocalrecoTaskCosmicsNZS = cms.Task(ecalLocalRecoTaskCosmics,hcalLocalRecoTask,hcalLocalRecoTaskNZS)
calolocalrecoCosmicsNZS = cms.Sequence(calolocalrecoTaskCosmicsNZS)
12 changes: 7 additions & 5 deletions RecoLocalCalo/Configuration/python/RecoLocalCalo_cff.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,8 @@
#
# sequence CaloLocalReco and CaloGlobalReco
#
calolocalreco = cms.Sequence(ecalLocalRecoSequence+hcalLocalRecoSequence)
calolocalrecoTask = cms.Task(ecalLocalRecoTask,hcalLocalRecoTask)
calolocalreco = cms.Sequence(calolocalrecoTask)
caloglobalreco = cms.Sequence(hcalGlobalRecoSequence)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not also migrating this sequence?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, this sequence is never used, it only includes hcalGlobalRecoSequence from RecoLocalCalo/Configuration/python/hcalGlobalReco_cff.py (which in its turn is only used for the globalreco_tracking reconstruction sequence) and it can be misleading here: I would suggest to just remove it


from RecoLocalCalo.HcalRecProducers.HcalHitSelection_cfi import *
Expand All @@ -30,11 +31,12 @@
# R.Ofierzynski (29.Oct.2009): add NZS sequence
#
from RecoLocalCalo.Configuration.hcalLocalRecoNZS_cff import *
calolocalrecoNZS = cms.Sequence(ecalLocalRecoSequence+hcalLocalRecoSequence+hcalLocalRecoSequenceNZS)
calolocalrecoTaskNZS = cms.Task(ecalLocalRecoTask,hcalLocalRecoTask,hcalLocalRecoTaskNZS)
calolocalrecoNZS = cms.Sequence(calolocalrecoTaskNZS)

from RecoLocalCalo.Configuration.hgcalLocalReco_cff import *
_phase2_calolocalreco = calolocalreco.copy()
_phase2_calolocalreco += hgcalLocalRecoSequence
_phase2_calolocalrecoTask = calolocalrecoTask.copy()
_phase2_calolocalrecoTask.add(hgcalLocalRecoTask)

from Configuration.Eras.Modifier_phase2_hgcal_cff import phase2_hgcal
phase2_hgcal.toReplaceWith( calolocalreco , _phase2_calolocalreco )
phase2_hgcal.toReplaceWith( calolocalrecoTask , _phase2_calolocalrecoTask )
3 changes: 2 additions & 1 deletion RecoLocalCalo/Configuration/python/ecalLocalRecoSequenceCosmics_cff.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@
from RecoLocalCalo.EcalRecProducers.ecalRecHit_cfi import *
from RecoLocalCalo.EcalRecProducers.ecalPreshowerRecHit_cfi import *
from RecoLocalCalo.EcalRecProducers.ecalDetIdToBeRecovered_cfi import *
ecalLocalRecoSequenceCosmics = cms.Sequence(ecalFixedAlphaBetaFitUncalibRecHit*ecalWeightUncalibRecHit*ecalDetIdToBeRecovered*ecalRecHit+ecalPreshowerRecHit)
ecalLocalRecoTaskCosmics = cms.Task(ecalFixedAlphaBetaFitUncalibRecHit,ecalWeightUncalibRecHit,ecalDetIdToBeRecovered,ecalRecHit,ecalPreshowerRecHit)
ecalLocalRecoSequenceCosmics = cms.Sequence(ecalLocalRecoTaskCosmics)
ecalRecHit.EBuncalibRecHitCollection = 'ecalFixedAlphaBetaFitUncalibRecHit:EcalUncalibRecHitsEB'
ecalRecHit.EEuncalibRecHitCollection = 'ecalFixedAlphaBetaFitUncalibRecHit:EcalUncalibRecHitsEE'
ecalRecHit.ChannelStatusToBeExcluded = [
Expand Down
29 changes: 17 additions & 12 deletions RecoLocalCalo/Configuration/python/ecalLocalRecoSequence_cff.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,24 +23,29 @@
#ecalUncalibRecHitSequence = cms.Sequence(ecalGlobalUncalibRecHit*
# ecalDetIdToBeRecovered)

ecalUncalibRecHitSequence = cms.Sequence(ecalMultiFitUncalibRecHit*
ecalUncalibRecHitTask = cms.Task(ecalMultiFitUncalibRecHit,
ecalDetIdToBeRecovered)

ecalRecHitSequence = cms.Sequence(ecalRecHit*
ecalCompactTrigPrim*
ecalTPSkim+
ecalRecHitTask = cms.Task(ecalRecHit,
ecalCompactTrigPrim,
ecalTPSkim,
ecalPreshowerRecHit)

ecalLocalRecoSequence = cms.Sequence(ecalUncalibRecHitSequence*
ecalRecHitSequence)
ecalLocalRecoTask = cms.Task(ecalUncalibRecHitTask,
ecalRecHitTask)

ecalUncalibRecHitSequence = cms.Sequence(ecalUncalibRecHitTask)
ecalRecHitSequence = cms.Sequence(ecalRecHitTask)
ecalLocalRecoSequence = cms.Sequence(ecalLocalRecoTask)


from RecoLocalCalo.EcalRecProducers.ecalDetailedTimeRecHit_cfi import *
_phase2_timing_ecalRecHitSequence = cms.Sequence( ecalRecHitSequence.copy() + ecalDetailedTimeRecHit )
_phase2_timing_ecalRecHitTask = cms.Task( ecalRecHitTask.copy() , ecalDetailedTimeRecHit )
from Configuration.Eras.Modifier_phase2_timing_cff import phase2_timing
phase2_timing.toReplaceWith( ecalRecHitSequence, _phase2_timing_ecalRecHitSequence )
phase2_timing.toReplaceWith( ecalRecHitTask, _phase2_timing_ecalRecHitTask )

_fastSim_ecalRecHitSequence = ecalRecHitSequence.copyAndExclude([ecalCompactTrigPrim,ecalTPSkim])
_fastSim_ecalUncalibRecHitSequence = ecalUncalibRecHitSequence.copyAndExclude([ecalDetIdToBeRecovered])
_fastSim_ecalRecHitTask = ecalRecHitTask.copyAndExclude([ecalCompactTrigPrim,ecalTPSkim])
_fastSim_ecalUncalibRecHitTask = ecalUncalibRecHitTask.copyAndExclude([ecalDetIdToBeRecovered])
from Configuration.Eras.Modifier_fastSim_cff import fastSim
fastSim.toReplaceWith(ecalRecHitSequence, _fastSim_ecalRecHitSequence)
fastSim.toReplaceWith(ecalUncalibRecHitSequence, _fastSim_ecalUncalibRecHitSequence)
fastSim.toReplaceWith(ecalRecHitTask, _fastSim_ecalRecHitTask)
fastSim.toReplaceWith(ecalUncalibRecHitTask, _fastSim_ecalUncalibRecHitTask)
24 changes: 13 additions & 11 deletions RecoLocalCalo/Configuration/python/hcalLocalRecoNZS_cff.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,8 @@
hfrecoMB.dropZSmarkedPassed = cms.bool(False)
horecoMB.dropZSmarkedPassed = cms.bool(False)

hcalLocalRecoSequenceNZS = cms.Sequence(hbherecoMB*hfrecoMB*horecoMB)
hcalLocalRecoTaskNZS = cms.Task(hbherecoMB,hfrecoMB,horecoMB)
hcalLocalRecoSequenceNZS = cms.Sequence(hcalLocalRecoTaskNZS)

import RecoLocalCalo.HcalRecProducers.hfprereco_cfi
import RecoLocalCalo.HcalRecProducers.HFPhase1Reconstructor_cfi
Expand All @@ -50,29 +51,30 @@
hbheInput = cms.InputTag("hbheprerecoMB")
)

_phase1_hcalLocalRecoSequenceNZS = hcalLocalRecoSequenceNZS.copy()
_phase1_hcalLocalRecoSequenceNZS.insert(0,hfprerecoMB)

_phase1_hcalLocalRecoTaskNZS = hcalLocalRecoTaskNZS.copy()
_phase1_hcalLocalRecoTaskNZS.add(hfprerecoMB)
from Configuration.Eras.Modifier_run2_HF_2017_cff import run2_HF_2017
run2_HF_2017.toReplaceWith( hcalLocalRecoSequenceNZS, _phase1_hcalLocalRecoSequenceNZS )
run2_HF_2017.toReplaceWith( hcalLocalRecoTaskNZS, _phase1_hcalLocalRecoTaskNZS )
run2_HF_2017.toReplaceWith( hfrecoMB, _phase1_hfrecoMB )

from Configuration.Eras.Modifier_run2_HCAL_2017_cff import run2_HCAL_2017
run2_HCAL_2017.toModify( hbherecoMB,
processQIE11 = cms.bool(True),
# temporarily disabled until RecoLocalCalo/HcalRecProducers/python/HBHEPhase1Reconstructor_cfi.py:flagParametersQIE11 is filled
# setNoiseFlagsQIE11 = cms.bool(True),
)

_plan1_hcalLocalRecoSequenceNZS = _phase1_hcalLocalRecoSequenceNZS.copy()
_plan1_hcalLocalRecoTaskNZS = _phase1_hcalLocalRecoTaskNZS.copy()
hbheprerecoMB = hbherecoMB.clone()
_plan1_hcalLocalRecoSequenceNZS.insert(0,hbheprerecoMB)
_plan1_hcalLocalRecoTaskNZS.add(hbheprerecoMB)
from Configuration.Eras.Modifier_run2_HEPlan1_2017_cff import run2_HEPlan1_2017
run2_HEPlan1_2017.toReplaceWith(hbherecoMB, hbheplan1MB)
run2_HEPlan1_2017.toReplaceWith(hcalLocalRecoSequenceNZS, _plan1_hcalLocalRecoSequenceNZS)
run2_HEPlan1_2017.toReplaceWith(hcalLocalRecoTaskNZS, _plan1_hcalLocalRecoTaskNZS)

hbhecollapseMB = hbheplan1MB.clone()
_collapse_hcalLocalRecoSequenceNZS = _phase1_hcalLocalRecoSequenceNZS.copy()
_collapse_hcalLocalRecoSequenceNZS.insert(0,hbheprerecoMB)
_collapse_hcalLocalRecoTaskNZS = _phase1_hcalLocalRecoTaskNZS.copy()
_collapse_hcalLocalRecoTaskNZS.add(hbheprerecoMB)
from Configuration.ProcessModifiers.run2_HECollapse_2018_cff import run2_HECollapse_2018
run2_HECollapse_2018.toReplaceWith(hbherecoMB, hbhecollapseMB)
run2_HECollapse_2018.toReplaceWith(hcalLocalRecoSequenceNZS, _collapse_hcalLocalRecoSequenceNZS)
run2_HECollapse_2018.toReplaceWith(hcalLocalRecoTaskNZS, _collapse_hcalLocalRecoTaskNZS)
31 changes: 16 additions & 15 deletions RecoLocalCalo/Configuration/python/hcalLocalReco_cff.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@
from RecoLocalCalo.HcalRecProducers.HcalHitReconstructor_ho_cfi import *
from RecoLocalCalo.HcalRecProducers.HcalHitReconstructor_hf_cfi import *
from RecoLocalCalo.HcalRecProducers.HcalHitReconstructor_zdc_cfi import *
hcalLocalRecoSequence = cms.Sequence(hbheprereco+hfreco+horeco+zdcreco)
hcalLocalRecoTask = cms.Task(hbheprereco,hfreco,horeco,zdcreco)
hcalLocalRecoSequence = cms.Sequence(hcalLocalRecoTask)

from RecoLocalCalo.HcalRecProducers.hfprereco_cfi import hfprereco
from RecoLocalCalo.HcalRecProducers.HFPhase1Reconstructor_cfi import hfreco as _phase1_hfreco
Expand All @@ -24,33 +25,33 @@
# copy for cosmics
_default_hfreco = hfreco.clone()

_phase1_hcalLocalRecoSequence = hcalLocalRecoSequence.copy()
_phase1_hcalLocalRecoSequence.insert(0,hfprereco)
_phase1_hcalLocalRecoTask = hcalLocalRecoTask.copy()
_phase1_hcalLocalRecoTask.add(hfprereco)

from Configuration.Eras.Modifier_run2_HF_2017_cff import run2_HF_2017
run2_HF_2017.toReplaceWith( hcalLocalRecoSequence, _phase1_hcalLocalRecoSequence )
run2_HF_2017.toReplaceWith( hcalLocalRecoTask, _phase1_hcalLocalRecoTask )
run2_HF_2017.toReplaceWith( hfreco, _phase1_hfreco )
from Configuration.Eras.Modifier_run2_HCAL_2017_cff import run2_HCAL_2017
run2_HCAL_2017.toReplaceWith( hbheprereco, _phase1_hbheprereco )

_plan1_hcalLocalRecoSequence = _phase1_hcalLocalRecoSequence.copy()
_plan1_hcalLocalRecoSequence += hbheplan1
_plan1_hcalLocalRecoTask = _phase1_hcalLocalRecoTask.copy()
_plan1_hcalLocalRecoTask.add(hbheplan1)
from Configuration.Eras.Modifier_run2_HEPlan1_2017_cff import run2_HEPlan1_2017
run2_HEPlan1_2017.toReplaceWith(hcalLocalRecoSequence, _plan1_hcalLocalRecoSequence)
run2_HEPlan1_2017.toReplaceWith(hcalLocalRecoTask, _plan1_hcalLocalRecoTask)

hbhecollapse = hbheplan1.clone()
_collapse_hcalLocalRecoSequence = _phase1_hcalLocalRecoSequence.copy()
_collapse_hcalLocalRecoSequence += hbhecollapse
_collapse_hcalLocalRecoTask = _phase1_hcalLocalRecoTask.copy()
_collapse_hcalLocalRecoTask.add(hbhecollapse)
from Configuration.ProcessModifiers.run2_HECollapse_2018_cff import run2_HECollapse_2018
run2_HECollapse_2018.toReplaceWith(hcalLocalRecoSequence, _collapse_hcalLocalRecoSequence)
run2_HECollapse_2018.toReplaceWith(hcalLocalRecoTask, _collapse_hcalLocalRecoTask)

_phase2_hcalLocalRecoSequence = hcalLocalRecoSequence.copy()
_phase2_hcalLocalRecoSequence.remove(hbheprereco)
_phase2_hcalLocalRecoTask = hcalLocalRecoTask.copy()
_phase2_hcalLocalRecoTask.remove(hbheprereco)

from Configuration.Eras.Modifier_phase2_hcal_cff import phase2_hcal
phase2_hcal.toReplaceWith( hcalLocalRecoSequence, _phase2_hcalLocalRecoSequence )
phase2_hcal.toReplaceWith( hcalLocalRecoTask, _phase2_hcalLocalRecoTask )


_fastSim_hcalLocalRecoSequence = hcalLocalRecoSequence.copyAndExclude([zdcreco])
_fastSim_hcalLocalRecoTask = hcalLocalRecoTask.copyAndExclude([zdcreco])
from Configuration.Eras.Modifier_fastSim_cff import fastSim
fastSim.toReplaceWith( hcalLocalRecoSequence, _fastSim_hcalLocalRecoSequence )
fastSim.toReplaceWith( hcalLocalRecoTask, _fastSim_hcalLocalRecoTask )
13 changes: 7 additions & 6 deletions RecoLocalCalo/Configuration/python/hgcalLocalReco_cff.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,11 @@
from RecoLocalCalo.HGCalRecProducers.hgcalMultiClusters_cfi import *
from RecoLocalCalo.HGCalRecProducers.hgcalLayerClusters_cff import hgcalLayerClusters

hgcalLocalRecoSequence = cms.Sequence( HGCalUncalibRecHit+
HGCalRecHit+
hgcalLayerClusters+
hgcalMultiClusters+
particleFlowRecHitHGCSeq+
particleFlowClusterHGCal+
hgcalLocalRecoTask = cms.Task( HGCalUncalibRecHit,
HGCalRecHit,
hgcalLayerClusters,
hgcalMultiClusters,
particleFlowRecHitHGCTask,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder whether one couldn't simply add here particleFlowRecHitHGC from RecoParticleFlow.PFClusterProducer.particleFlowRecHitHGC_cfi, instead of the task which only contains that module.

@lgray @felicepantaleo @rovere : was there a reason for having originally a sequence defined with one single module in RecoParticleFlow/PFClusterProducer/python/particleFlowRecHitHGC_cff.py? (As a corollary: could that cff file be removed now when moving to unscheduled execution?)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot comment for the past history, but I see not special reason.
As for the Task, we could bypass it but I'm not sure if there is any added value.

particleFlowClusterHGCal,
particleFlowClusterHGCalFromMultiCl )
hgcalLocalRecoSequence = cms.Sequence(hgcalLocalRecoTask)
3 changes: 2 additions & 1 deletion RecoLocalCalo/HGCalRecProducers/python/HGCalLocalRecoTestBeamSequence_cff.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,5 @@
from RecoLocalCalo.HGCalRecProducers.hgcalLayerClusters_cff import hgcalLayerClusters
from RecoLocalCalo.HGCalRecProducers.hgcalMultiClusters_cfi import *

HGCalLocalRecoTestBeamSequence = cms.Sequence(HGCalUncalibRecHit*HGCalRecHit*hgcalLayerClusters*hgcalMultiClusters)
HGCalLocalRecoTestBeamTask = cms.Task(HGCalUncalibRecHit,HGCalRecHit,hgcalLayerClusters,hgcalMultiClusters)
HGCalLocalRecoTestBeamSequence = cms.Sequence(HGCalLocalRecoTestBeamTask)
3 changes: 2 additions & 1 deletion RecoParticleFlow/PFClusterProducer/python/particleFlowRecHitHGC_cff.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
from RecoParticleFlow.PFClusterProducer.particleFlowRecHitHGC_cfi import *

particleFlowRecHitHGCSeq = cms.Sequence( particleFlowRecHitHGC )
particleFlowRecHitHGCTask = cms.Task( particleFlowRecHitHGC )
particleFlowRecHitHGCSeq = cms.Sequence( particleFlowRecHitHGCTask )
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the sequence still needed? From a very quick look into CMSSW it is only referenced in RecoLocalCalo/Configuration/python/hgcalLocalReco_cff.py that you are moving to Task.

Copy link
Contributor Author

@jeongeun jeongeun Jul 10, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I will remove particleFlowRecHitHGCSeq = cms.Sequence( particleFlowRecHitHGCTask )
then the particleFlowRecHitHGC_cff.py files is no use anymore?