Move Xerces lock to Utilities/Xerces

[Dr15Jones]

PR description:

This removes an unnecessary external dependency on FWCore/Concurrency.

PR validation:

All the code compiles.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27214/10381

• This PR adds an extra 468KB to repository

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

Alignment/MuonAlignment
CalibCalorimetry/CaloMiscalibTools
CalibCalorimetry/HcalTPGAlgos
CalibPPS/ESProducers
Calibration/HcalCalibAlgos
CondCore/CondDB
CondCore/Utilities
CondTools/Ecal
CondTools/Hcal
DQM/CSCMonitorModule
DQM/EcalMonitorDbModule
DQM/SiPixelMonitorClient
DQM/SiStripMonitorClient
DQMServices/ClientConfig
DetectorDescription/Parser
DetectorDescription/RegressionTest
FWCore/Catalog
FWCore/Concurrency
FWCore/Services
GeneratorInterface/LHEInterface
L1Trigger/RPCTrigger
L1TriggerConfig/L1GtConfigProducers
PhysicsTools/MVATrainer
RecoBTag/XMLCalibration
RecoLuminosity/LumiProducer
Utilities/Xerces

@andrius-k, @schneiml, @ianna, @rekovic, @fioriNTU, @tlampen, @alberto-sanchez, @pohsun, @santocch, @perrotta, @civanch, @cmsbuild, @agrohsje, @smuzaffar, @Dr15Jones, @cvuosalo, @efeyazgan, @mdhildreth, @jfernan2, @tocheng, @slava77, @ggovi, @qliphy, @benkrikler, @kmaeshima, @christopheralanwest, @franzoni can you please review it and eventually sign? Thanks.
@abbiendi, @argiro, @Martin-Grunewald, @fioriNTU, @alberto-sanchez, @threus, @venturia, @pakhotin, @hdelanno, @makortel, @smoortga, @acaudron, @jhgoh, @agrohsje, @ferencek, @trocino, @barvic, @tocheng, @ptcox, @jandrea, @mschrode, @idebruyn, @mmusich, @HeinerTholen, @mkirsano, @adewit, @wddgit, @JyothsnaKomaragiri, @mverzett, @pvmulder this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[Dr15Jones]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/961/console Started: 2019/06/14 19:30

[cmsbuild]

-1

Tested at: bc3bac0

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d9ca00/961/summary.html

I found follow errors while testing this PR

Failed tests: Build HeaderConsistency

• Build:

I found compilation error when building:

tmp/slc7_amd64_gcc700/src/RecoBTag/XMLCalibration/src/RecoBTagXMLCalibration/CalibrationXML.cc.o: In function `CalibrationXML::~CalibrationXML()':
CalibrationXML.cc:(.text+0xda): undefined reference to `cms::concurrency::xercesTerminate()'
tmp/slc7_amd64_gcc700/src/RecoBTag/XMLCalibration/src/RecoBTagXMLCalibration/CalibrationXML.cc.o: In function `CalibrationXML::openFile(std::__cxx11::basic_string, std::allocator > const&)':
CalibrationXML.cc:(.text+0x47e): undefined reference to `cms::concurrency::xercesTerminate()'
CalibrationXML.cc:(.text+0x4bc): undefined reference to `cms::concurrency::xercesInitialize()'
collect2: error: ld returned 1 exit status
gmake: *** [tmp/slc7_amd64_gcc700/src/RecoBTag/XMLCalibration/src/RecoBTagXMLCalibration/libRecoBTagXMLCalibration.so] Error 1
Leaving library rule at RecoBTag/XMLCalibration
Entering library rule at src/RecoBTag/XMLCalibration/test
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-06-13-2300/src/RecoBTag/XMLCalibration/test/XMLCalibrationTest.cc 
>> Building edm plugin tmp/slc7_amd64_gcc700/src/RecoBTag/XMLCalibration/test/testRecoBTagXMLCalibration/libtestRecoBTagXMLCalibration.so


[cmsbuild]

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

[Dr15Jones]

unit test failure is not related to this pull request. It says that the voms proxy was not initialized. The same test is failing in the IBs.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d9ca00/970/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3254096
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3253761
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[perrotta]

+1

• Technical
• Jenkins tests pass (a part the UnitTest which is also failing in the IB)

[jfernan2]

+1

[cvuosalo]

+1

[fabiocos]

@christopheralanwest @ggovi @rekovic @efeyazgan @qliphy @santocch this looks technical and straightforward to me, I would like to integrate it quickly unless you have remarks. Please have a look

[qliphy]

+1

[christopheralanwest]

+1

[fabiocos]

+1

[fabiocos]

merge

[santocch]

+1