Run3-hcx201 Modify Hcal geometry in view of no HE (backporting PR #26749)

[bsunanda]

PR description:

Modify Hcal reconstruction geometry in view of absence of HE

PR validation:

Tested with runTheMattrix.py -l limited

if this PR is a backport please specify the original PR:

This is a backport of the PR #26749 to 10_6_X and it is a bug fix for all Phase2 geometry scenarios

[cmsbuild]

A new Pull Request was created by @bsunanda for CMSSW_10_6_X.

It involves the following packages:

CalibCalorimetry/HcalPlugins
Geometry/CaloTopology
Geometry/HcalCommonData

@civanch, @Dr15Jones, @cvuosalo, @christopheralanwest, @ianna, @mdhildreth, @cmsbuild, @franzoni, @tocheng, @tlampen, @pohsun can you please review it and eventually sign? Thanks.
@mmusich, @tocheng this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@cmsbuild Please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/232/console Started: 2019/05/15 18:24

[cmsbuild]

+1
Tested at: 6cbf57a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-291fd6/232/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-291fd6/232/summary.html

Comparison Summary:

• You potentially added 681 lines to the logs
• Reco comparison results: 1311 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3211772
• DQMHistoTests: Total failures: 30
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3211408
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -2953.454 KiB( 32 files compared)
• DQMHistoSizes: changed ( 27434.0,... ): -1332.594 KiB HcalDigisV/HcalDigiTask
• DQMHistoSizes: changed ( 27434.0,... ): -113.938 KiB HcalRecHitsD/HcalRecHitTask
• DQMHistoSizes: changed ( 27434.0,... ): -30.195 KiB HcalHitsV/SimHitsValidationHcal
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[cmsbuild]

Pull request #26787 was updated. @civanch, @Dr15Jones, @cvuosalo, @christopheralanwest, @ianna, @mdhildreth, @cmsbuild, @franzoni, @tocheng, @tlampen, @pohsun can you please check and sign again.

[bsunanda]

@cmsbuild Please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/274/console Started: 2019/05/16 20:12

[cmsbuild]

+1
Tested at: 621771f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-291fd6/274/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-291fd6/274/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 1303 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3211772
• DQMHistoTests: Total failures: 29
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3211409
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -2953.454 KiB( 32 files compared)
• DQMHistoSizes: changed ( 27434.0,... ): -1332.594 KiB HcalDigisV/HcalDigiTask
• DQMHistoSizes: changed ( 27434.0,... ): -113.938 KiB HcalRecHitsD/HcalRecHitTask
• DQMHistoSizes: changed ( 27434.0,... ): -30.195 KiB HcalHitsV/SimHitsValidationHcal
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[pohsun]

+1

[cvuosalo]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1