Running code-format for dqm

[cmsbuild]

Applying code-format for CMSSW category dqm.
See the build logs here https://cmssdt.cern.ch/jenkins/job/GitHub-refactor-cmssw-module/197//console

cms-bot has successfully run the following:

• scram build code-checks-all
• scram build code-format-all
• scram build

Fixes the code-formats suggested by #26628 (see #26686)

[cmsbuild]

please test

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26714/9700

• This PR adds an extra 8KB to repository

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/105/console Started: 2019/05/09 06:26

[cmsbuild]

A new Pull Request was created by @cmsbuild for master.

It involves the following packages:

DQM/EcalMonitorDbModule
DQM/SiPixelMonitorClient
DQM/SiStripMonitorSummary
DQMOffline/Ecal
DQMOffline/PFTau
DQMServices/Diagnostic
HLTriggerOffline/Common
HLTriggerOffline/Egamma
Validation/EcalClusters
Validation/GlobalDigis
Validation/HcalHits
Validation/Mixing
Validation/MuonCSCDigis
Validation/MuonDTDigis

@andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@barvic, @hdelanno, @mtosi, @jandrea, @argiro, @fioriNTU, @hatakeyamak, @idebruyn, @venturia, @threus, @rociovilar this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

-1

Tested at: f27611d

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0e3887/105/summary.html

I found follow errors while testing this PR

Failed tests: Build

• Build:

I found compilation warning when building: See details on the summary page.

[cmsbuild]

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26714/9706

• This PR adds an extra 8KB to repository

[cmsbuild]

Pull request #26714 was updated. @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please check and sign again.

[smuzaffar]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/114/console Started: 2019/05/09 09:15

[smuzaffar]

@fabiocos , looks like gcc is not happy with clang-format changes. I have opened a issue with clang-format team (https://bugs.llvm.org/show_bug.cgi?id=41807 ) . For now I propose that we fix this manually 1b332fd

[cmsbuild]

+1
Tested at: 1b332fd
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0e3887/114/summary.html

[cmsbuild]

Comparison job queued.

[andrius-k]

+1

[andrius-k]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

@smuzaffar ok, that was easily caught by the compiler, I quickly scrolled the diff report and did not see anything else obviously weird

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0e3887/114/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3211964
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3211759
• DQMHistoTests: Total skipped: 204
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[fabiocos]

+1