Get rid of useless repeated config_.exists() in SiPixelRawToDigi.cc

[perrotta]

PR description:

During the review of #26606/#26679 I noticed a number of useless checks for the existence of configuration parameters, not needed any more since those parameters are now always defined by the fillDescriptions method of the class.

In order not to interfere and delay the approval of #26679, this technical/cosmetic change has been kept separated here: from the practical point of view, no changes in outputs can be expected.

PR validation:

It builds

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26681/9643

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @perrotta for master.

It involves the following packages:

EventFilter/SiPixelRawToDigi

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @dkotlins, @VinInn this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/46/console Started: 2019/05/07 12:06

[cmsbuild]

+1
Tested at: f9603dc
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a71bc5/46/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a71bc5/46/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3211964
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3211759
• DQMHistoTests: Total skipped: 204
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[perrotta]

+1

• This is just code cleaning, with no effect on outputs whatsoever: jenkins tests pass and show no difference
• It does not interfere with the other SiPixelRawToDigi open pull request, Restore fed error treatment for phase0 pixel detector #26679

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1