Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump TObject versions for ROOT master #26537

Merged

Conversation

mrodozov
Copy link
Contributor

Copy of #26464
for testing against root master: cms-sw/cmsdist#4908
to be closed on merging #26464

Based on the numbers in commit 94610d9fbca67feb8 in the root repo.
@mrodozov mrodozov changed the title Bump TObject versions for ROOT 6.14. Bump TObject versions for ROOT 6.14. (for root master) Apr 25, 2019
@cmsbuild cmsbuild added this to the CMSSW_10_6_X milestone Apr 25, 2019
@mrodozov mrodozov changed the title Bump TObject versions for ROOT 6.14. (for root master) Bump TObject versions for ROOT master Apr 25, 2019
@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@mrodozov
Copy link
Contributor Author

please test with cms-sw/cmsdist#4908

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26537/9422

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 25, 2019

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmsdist#4908
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34346/console

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mrodozov (Mircho Rodozov) for master.

It involves the following packages:

DQMServices/Components

@andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@barvic this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26537/34346/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3211964
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3211759
  • DQMHistoTests: Total skipped: 204
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@mrodozov
Copy link
Contributor Author

mrodozov commented May 8, 2019

please test with cms-sw/cmsdist#4945

@smuzaffar
Copy link
Contributor

smuzaffar commented May 10, 2019

please test with cms-sw/cmsdist#4952

@cmsbuild
Copy link
Contributor

cmsbuild commented May 10, 2019

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmsdist#4952
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/141/console Started: 2019/05/10 10:51

@fabiocos
Copy link
Contributor

@andrius-k @schneiml @fioriNTU this setup has been tested already in the IB, so as soon as this test is finished I would like to integrate it into the master branch

@cmsbuild
Copy link
Contributor

-1

Tested at: 6291abd

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-891241/141/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

---> test testConditionDatabase_2 had ERRORS

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-891241/141/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-891241/11624.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2021_GenSimFull+DigiFull_2021+RecoFull_2021+HARVESTFull_2021+ALCAFull_2021

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3211964
  • DQMHistoTests: Total failures: 132
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3211628
  • DQMHistoTests: Total skipped: 204
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@fabiocos
Copy link
Contributor

@smuzaffar @andrius-k @schneiml the unit test failure has nothing to do with this PR, see #26741, and the DQM differences are also independent (and to be understood)

@fioriNTU
Copy link
Contributor

@smuzaffar @andrius-k @schneiml the unit test failure has nothing to do with this PR, see #26741, and the DQM differences are also independent (and to be understood)

Dear @fabiocos, what DQM differences are you referring to? I see only differences in the Timer Service plots. Can you please clarify?

@fabiocos
Copy link
Contributor

@fioriNTU interesting, you look at the bin-to-bin comparison recently added, i look at the usual RelMon report above (132 histograms, all in DT DCS information with nan)... I am testing whether my recent update, that removes lots of spurious warnings, is the cause for this new report

@fabiocos
Copy link
Contributor

Anyway I would like to move forward and merge this PR and the corresponding ROOT 6.14 update tonight

@fabiocos
Copy link
Contributor

+1

as in the ROOT614_X queue this is working since several IBs, I move forward with its integration, as it is useful for further developments

@fabiocos
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 6f20e2e into cms-sw:master May 11, 2019
@jfernan2
Copy link
Contributor

jfernan2 commented Jun 4, 2020

+1
For the records

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2020

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants