-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump TObject versions for ROOT master #26537
Bump TObject versions for ROOT master #26537
Conversation
Based on the numbers in commit 94610d9fbca67feb8 in the root repo.
The code-checks are being triggered in jenkins. |
please test with cms-sw/cmsdist#4908 |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26537/9422
|
The tests are being triggered in jenkins. |
A new Pull Request was created by @mrodozov (Mircho Rodozov) for master. It involves the following packages: DQMServices/Components @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
please test with cms-sw/cmsdist#4945 |
please test with cms-sw/cmsdist#4952 |
The tests are being triggered in jenkins. |
@andrius-k @schneiml @fioriNTU this setup has been tested already in the IB, so as soon as this test is finished I would like to integrate it into the master branch |
-1 Tested at: 6291abd You can see the results of the tests here: I found follow errors while testing this PR Failed tests: UnitTests
I found errors in the following unit tests: ---> test testConditionDatabase_2 had ERRORS |
Comparison job queued. |
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
@smuzaffar @andrius-k @schneiml the unit test failure has nothing to do with this PR, see #26741, and the DQM differences are also independent (and to be understood) |
Dear @fabiocos, what DQM differences are you referring to? I see only differences in the Timer Service plots. Can you please clarify? |
@fioriNTU interesting, you look at the bin-to-bin comparison recently added, i look at the usual RelMon report above (132 histograms, all in DT DCS information with nan)... I am testing whether my recent update, that removes lots of spurious warnings, is the cause for this new report |
Anyway I would like to move forward and merge this PR and the corresponding ROOT 6.14 update tonight |
+1 as in the ROOT614_X queue this is working since several IBs, I move forward with its integration, as it is useful for further developments |
merge |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2) |
Copy of #26464
for testing against root master: cms-sw/cmsdist#4908
to be closed on merging #26464