Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip nonexistent branch checks in L1TGlobalUtilHelper #26329

Merged
merged 1 commit into from
Apr 17, 2019

Conversation

slava77
Copy link
Contributor

@slava77 slava77 commented Apr 2, 2019

backport of #26328

this is expected to resolve #26182
thanks @Dr15Jones for suggesting a solution.

some notes leading to the resolution are in #26182 (comment) and following

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2019

A new Pull Request was created by @slava77 (Slava Krutelyov) for CMSSW_10_2_X.

It involves the following packages:

L1Trigger/L1TGlobal

@cmsbuild, @rekovic can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@slava77
Copy link
Contributor Author

slava77 commented Apr 2, 2019

@cmkuo
please check on your side that this resolves the problem that you reported earlier

@slava77
Copy link
Contributor Author

slava77 commented Apr 2, 2019

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33911/console Started: 2019/04/02 17:20

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26329/33911/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 3007400
  • DQMHistoTests: Total failures: 4
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3007206
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 129 log files, 14 edm output root files, 31 DQM output files

@cmkuo
Copy link
Contributor

cmkuo commented Apr 3, 2019

@slava77 Many thanks for looking into this problem. This fix cures the problem I reported.

@rekovic
Copy link
Contributor

rekovic commented Apr 10, 2019

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 58b66da into cms-sw:CMSSW_10_2_X Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants