-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New feature for the Payload Inspector: support for two tags/ single IOV plot generation #26294
New feature for the Payload Inspector: support for two tags/ single IOV plot generation #26294
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26294/8982
|
A new Pull Request was created by @ggovi for master. It involves the following packages: CondCore/CondDB @ggovi, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
output('currently discovered info: ', result) | ||
output('*** final output:', '') | ||
return json.dumps(result) | ||
|
||
def output(description, param): | ||
if args.verbose: | ||
print('') | ||
print(description, param) | ||
print '' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't this going back with the python3 changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#26484 addresses the problem created by this PR.
+1 |
In the payload Inspector application, we are adding the support of two tags for single iov payload comparison.
The same branch used for the PR has been deployed as the DEMO release in the Payload Inspector. A dedicated new plot based on the BasicPayload class has been created.