-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix HGCalValidator configuration for premixing #26287
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26287/8972
|
A new Pull Request was created by @fabiocos (Fabio Cossutti) for master. It involves the following packages: Validation/HGCalValidation @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test workflow 29034.0,20234.99 |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
+1 |
merge @andrius-k I want to quickly fix the problem before building 10_6_0_pre3 |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
PR description:
This PR addresses the problem described in #26284, after the integration of the HGCalValidator #26099 into the standard sequence. The class is configured to use CaloParticles from "mix", while for premixing they are from "mixData". See also #26001 . Here a simple addition of a modifier is proposed to circumvent the failure observed in the CMSSW_10_6_X_2019-03-27-2300 IB for workflow 20234.99 step4.
PR validation:
Both phase2 wf 29024.0 (D41 no PU) and 20234.99 (D17 Premixing) run smoothly.