Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide forward compatibility to HepMC::GenEvent reading #26211

Merged

Conversation

Dr15Jones
Copy link
Contributor

PR description:

Provide a iorule to allow reading data stored in CMSSW_10_6.

PR validation:

Tested with job that read a CMSSW_10_6 GENSIM+RAW data file.

Provide a iorule to allow reading data stored in CMSSW_10_6.
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 18, 2019

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_9_4_MAOD_X.

It involves the following packages:

SimDataFormats/GeneratorProducts

@alberto-sanchez, @cmsbuild, @efeyazgan, @perrozzi, @qliphy can you please review it and eventually sign? Thanks.
@rovere this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor

backport #26210

@fabiocos
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 27, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33798/console Started: 2019/03/27 15:01

@cmsbuild
Copy link
Contributor

-1
Tested at: UNKNOWN
I was not able to find a release to test this PR. See the Jenkins logs for more details.

@fabiocos
Copy link
Contributor

@smuzaffar @mrodozov CMSSW_9_4_MAOD_X_2019-03-24-0000 exists, but apparently the bot does not recognizes it as a valid reference...

@smuzaffar
Copy link
Contributor

please test
should be fix now

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 27, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33799/console Started: 2019/03/27 15:02

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26211/33799/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 27
  • DQMHistoTests: Total histograms compared: 2721493
  • DQMHistoTests: Total failures: 104
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2721227
  • DQMHistoTests: Total skipped: 162
  • DQMHistoTests: Total Missing objects: 0

@fabiocos
Copy link
Contributor

@alberto-sanchez @efeyazgan @qliphy this backport is needed to fix the issue observed in the UL processing chain

@alberto-sanchez
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_4_MAOD_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit ed8e450 into cms-sw:CMSSW_9_4_MAOD_X Mar 27, 2019
fabiocos added a commit to fabiocos/cmssw that referenced this pull request Apr 9, 2019
cmsbuild added a commit that referenced this pull request Apr 15, 2019
Import additions for UL from CMSSW_9_4_13_UL1 (#26168) and #26211
@Dr15Jones Dr15Jones deleted the forwardCompatGenEvent_9_4 branch May 26, 2019 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants