-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate to python3 compatible syntax for local imports #25917
Conversation
The code-checks are being triggered in jenkins. |
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25917/8398
|
The tests are being triggered in jenkins. |
A new Pull Request was created by @davidlange6 (David Lange) for master. It involves the following packages: Alignment/CommonAlignment @andrius-k, @schneiml, @cmsdoxy, @kpedro88, @Martin-Grunewald, @rekovic, @pohsun, @santocch, @perrotta, @civanch, @zhenhu, @cmsbuild, @fwyzard, @smuzaffar, @Dr15Jones, @tocheng, @jfernan2, @mdhildreth, @slava77, @ggovi, @nsmith-, @prebello, @kmaeshima, @pgunnell, @franzoni can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
-1 Tested at: dcca54f You can see the results of the tests here: I found follow errors while testing this PR Failed tests: UnitTests
I found errors in the following unit tests: ---> test TestFWCoreParameterSetDriver had ERRORS |
+upgrade |
checks have failed : Target 'check-headers' not remade because of errors. |
@prebello the header inconsistencies are not due to this pull request and happen to all pull requests which cause those headers to be checked. |
+1 Thank you @Dr15Jones .. approved |
+1 |
+1 |
+1 |
+1 |
+1 technical code update |
For packages with multiple python files, they must use
from . import Options
instead of
import Options
or
from .Options import myFunc
instead of
from Options import myFunc
as python3 does not allow relative imports. This was missed from my previous migrations as the futurize tool needed a correct python path to be set up before working for this tool. There maybe some others in this seme category - this was the first thing I stumbled on.