Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate to python3 compatible syntax for local imports #25917

Merged
merged 3 commits into from
Feb 26, 2019

Conversation

davidlange6
Copy link
Contributor

For packages with multiple python files, they must use

from . import Options
instead of
import Options

or

from .Options import myFunc
instead of
from Options import myFunc

as python3 does not allow relative imports. This was missed from my previous migrations as the futurize tool needed a correct python path to be set up before working for this tool. There maybe some others in this seme category - this was the first thing I stumbled on.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@davidlange6
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25917/8398

  • This PR adds an extra 620KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 12, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33098/console Started: 2019/02/12 17:49

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @davidlange6 (David Lange) for master.

It involves the following packages:

Alignment/CommonAlignment
Alignment/MillePedeAlignmentAlgorithm
Alignment/MuonAlignment
Alignment/OfflineValidation
CalibMuon/DTCalibration
CondCore/Utilities
CondTools/BTau
CondTools/Ecal
Configuration/PyReleaseValidation
DQM/Integration
Documentation/ReferenceManualScripts
FWCore/GuiBrowsers
FWCore/Integration
FWCore/ParameterSet
HLTrigger/Configuration
HLTrigger/Tools
L1Trigger/L1THGCal
PhysicsTools/Heppy
PhysicsTools/HeppyCore
RecoHI/HiTracking
RecoLocalCalo/HcalRecAlgos
RecoLuminosity/LumiDB
RecoMET/METFilters
RecoParticleFlow/PFClusterProducer
SLHCUpgradeSimulations/Configuration
Utilities/RelMon
Validation/Performance
Validation/RecoTau
Validation/RecoTrack

@andrius-k, @schneiml, @cmsdoxy, @kpedro88, @Martin-Grunewald, @rekovic, @pohsun, @santocch, @perrotta, @civanch, @zhenhu, @cmsbuild, @fwyzard, @smuzaffar, @Dr15Jones, @tocheng, @jfernan2, @mdhildreth, @slava77, @ggovi, @nsmith-, @prebello, @kmaeshima, @pgunnell, @franzoni can you please review it and eventually sign? Thanks.
@TaiSakuma, @gouskos, @felicepantaleo, @wmtford, @sviret, @argiro, @Martin-Grunewald, @wddgit, @thomreis, @tlampen, @ahinzmann, @lgray, @threus, @mmusich, @seemasharmafnal, @pakhotin, @mmarionncern, @imarches, @makortel, @smoortga, @acaudron, @mverzett, @jhgoh, @geoff-smith, @jdolen, @ferencek, @trocino, @HeinerTholen, @yetkinyilmaz, @abbiendi, @kurtejung, @GiacomoSguazzoni, @rovere, @VinInn, @jdamgov, @nhanvtran, @gkasieczka, @tocheng, @schoef, @mschrode, @ebrondol, @mtosi, @dgulhan, @clelange, @echapon, @batinkov, @adewit, @mandrenguyen, @jazzitup, @JyothsnaKomaragiri, @hatakeyamak, @yenjie, @cbernet, @mariadalfonso, @amarini, @pvmulder, @bachtis, @jbsauvan this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

-1

Tested at: dcca54f

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25917/33098/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

---> test TestFWCoreParameterSetDriver had ERRORS
---> test testTauEmbeddingProducers had ERRORS

@smuzaffar smuzaffar added this to the CMSSW_10_6_X milestone Feb 21, 2019
@kpedro88
Copy link
Contributor

+upgrade

@prebello
Copy link
Contributor

checks have failed : Target 'check-headers' not remade because of errors.
please, should PdmV approve it?

@Dr15Jones
Copy link
Contributor

@prebello the header inconsistencies are not due to this pull request and happen to all pull requests which cause those headers to be checked.

@prebello
Copy link
Contributor

+1

Thank you @Dr15Jones .. approved

@Martin-Grunewald
Copy link
Contributor

+1

@ggovi
Copy link
Contributor

ggovi commented Feb 25, 2019

+1

@santocch
Copy link

+1

@slava77
Copy link
Contributor

slava77 commented Feb 25, 2019

+1

for #25917 599ae2f

  • the technical configuration code changes are in line with the PR description
  • jenkins tests pass and comparisons with the baseline show no (relevant) differences

@fabiocos
Copy link
Contributor

@tocheng @civanch @rekovic @cmsdoxy could you please check and comment or sign it? I would like to avoid possibility of conflicts with future PRs and move forward with this PR, the update looks transparent

@civanch
Copy link
Contributor

civanch commented Feb 26, 2019

+1

@fabiocos
Copy link
Contributor

+1

technical code update

@fabiocos
Copy link
Contributor

merge

@tocheng @rekovic @cmsdoxy please check and sign it for reference in case

@cmsbuild cmsbuild merged commit c419f31 into cms-sw:master Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment