separate baseDataSetRelease values for fastsim 2017 #25626

kpedro88 · 2019-01-11T17:18:43Z

Implements suggestion in #25490 (comment)

cmsbuild · 2019-01-11T17:19:14Z

A new Pull Request was created by @kpedro88 (Kevin Pedro) for CMSSW_10_2_X.

It involves the following packages:

Configuration/PyReleaseValidation

@pgunnell, @zhenhu, @prebello, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

kpedro88 · 2019-01-11T17:24:14Z

please test workflow 25400.17,250399.0,250400.17,250402.17,250405.17,250406.17,250407.17,250408.17,250409.17
(here I am testing every fastsim workflow that failed in the last IB, for completeness)

cmsbuild · 2019-01-11T17:24:36Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32536/console Started: 2019/01/11 18:25

cmsbuild · 2019-01-11T19:36:19Z

-1

Tested at: 55227c1

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25626/32536/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

RelVals:

When I ran the RelVals I found an error in the following workflows:
250400.17 step1

runTheMatrix-results/250400.17_ZEE_13+FS_ZEE_13_PRMXUP17_PU50+HARVESTUP17FS+MINIAODMCUP17FS/step1_ZEE_13+FS_ZEE_13_PRMXUP17_PU50+HARVESTUP17FS+MINIAODMCUP17FS.log

250402.17 step1

runTheMatrix-results/250402.17_TTbar_13+FS_TTbar_13_PRMXUP17_PU50+HARVESTUP17FS+MINIAODMCUP17FS/step1_TTbar_13+FS_TTbar_13_PRMXUP17_PU50+HARVESTUP17FS+MINIAODMCUP17FS.log

250406.17 step1

runTheMatrix-results/250406.17_ZMM_13+FS_ZMM_13_PRMXUP17_PU50+HARVESTUP17FS+MINIAODMCUP17FS/step1_ZMM_13+FS_ZMM_13_PRMXUP17_PU50+HARVESTUP17FS+MINIAODMCUP17FS.log

250405.17 step1

runTheMatrix-results/250405.17_ZTT_13+FS_ZTT_13_PRMXUP17_PU50+HARVESTUP17FS+MINIAODMCUP17FS/step1_ZTT_13+FS_ZTT_13_PRMXUP17_PU50+HARVESTUP17FS+MINIAODMCUP17FS.log

250407.17 step1

runTheMatrix-results/250407.17_NuGun_UP17+FS_NuGun_UP17_PRMXUP17_PU50+HARVESTUP17FS+MINIAODMCUP17FS/step1_NuGun_UP17+FS_NuGun_UP17_PRMXUP17_PU50+HARVESTUP17FS+MINIAODMCUP17FS.log

250408.17 step1

runTheMatrix-results/250408.17_QCD_FlatPt_15_3000HS_13+FS_QCD_FlatPt_15_3000HS_13_PRMXUP17_PU50+HARVESTUP17FS+MINIAODMCUP17FS/step1_QCD_FlatPt_15_3000HS_13+FS_QCD_FlatPt_15_3000HS_13_PRMXUP17_PU50+HARVESTUP17FS+MINIAODMCUP17FS.log

250409.17 step1

runTheMatrix-results/250409.17_SMS-T1tttt_mGl-1500_mLSP-100_13+FS_SMS-T1tttt_mGl-1500_mLSP-100_13_PRMXUP17_PU50+HARVESTUP17FS+MINIAODMCUP17FS/step1_SMS-T1tttt_mGl-1500_mLSP-100_13+FS_SMS-T1tttt_mGl-1500_mLSP-100_13_PRMXUP17_PU50+HARVESTUP17FS+MINIAODMCUP17FS.log

cmsbuild · 2019-01-11T19:36:21Z

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

kpedro88 · 2019-01-11T20:49:23Z

@makortel @zhenhu @ssekmen we have encountered again the problem from #25513.

cmssw/Configuration/PyReleaseValidation/python/relval_steps.py

Line 1051 in 55227c1

"--pileup_input" : "dbs:/RelValFS_PREMIXUP17_PU50/%s/PREMIX"%(baseDataSetRelease[18],),

needs to have /PREMIX changed to /GEN-SIM-DIGI-RAW to select a dataset with the correct event content. I can make this change, however:
The only 10_2_X dataset for /RelValFS_PREMIXUP17_PU50 is /RelValFS_PREMIXUP17_PU50/CMSSW_10_2_8-PU25ns_102X_mc2017_realistic_v5_FastSim-v1/PREMIX, so we have nothing to provide that will work in this release.

What should we do about this? Can we launch another relval that will produce the needed output?

makortel · 2019-01-11T20:56:53Z

I'd think the only option is to produce a new pileup library with GEN-SIM-DIGI-RAW data tier and including L1,DIGI2RAW steps.

zhenhu · 2019-01-12T09:10:05Z

So, it seems a possible solution would be:
First get this PR merged and build an temporary official release (but missing the premix library input).
Then I will produce the missing input /RelValFS_PREMIXUP17_PU50/CMSSW_10_2_10-PU25ns_XXXXX/PREMIX in this new release, which will fix the input issue.

fabiocos · 2019-01-12T15:02:20Z

@zhenhu we may merge this PR, as it will fix part of the problem. But I do not think you need this to build the new library, all the ingredients should be already in the release, right?

zhenhu · 2019-01-12T15:37:20Z

OK, then I will build the new library with 10_2_9 plus these new changes. Once the job finished, we can update the input path here and test workflows again.

kpedro88 · 2019-01-12T16:15:03Z

@zhenhu yes, the missing library can be produced without this PR. I think that is a better way to go.

Please note, the library needs to be produced as GEN-SIM-DIGI-RAW (with the steps L1,DIGI2RAW included). You can read #25513 for details.

zhenhu · 2019-01-12T17:08:28Z

@kpedro88 premix library workflow injected

cmsDriver.py SingleNuE10_cfi  --conditions auto:phase1_2017_realistic --pileup_input das:/RelValMinBiasFS_13_UP17_ForMixing/CMSSW_10_2_8-102X_mc2017_realistic_v5_FastSim-v1/GEN-SIM-RECO --fast  --era Run2_2017_FastSim --eventcontent PREMIX --procModifiers premix_stage1 --relval 100000,500 -s GEN,SIM,RECOBEFMIX,DIGI,L1,DIGI2RAW --datatier GEN-SIM-DIGI-RAW --pileup AVE_50_BX_25ns --io FS_PREMIXUP17_PU50.io --python FS_PREMIXUP17_PU50.py

The output dataset name would be /RelValFS_PREMIXUP17_PU50/CMSSW_10_2_9-PU25ns_102X_mc2017_realistic_v5_FastSim-v1/GEN-SIM-DIGI-RAW

However, due to the computing issue reported in JIRA4232, all the relvals we submitted recently were stuck there. So we don't know when this file will be available.

zhenhu · 2019-01-15T06:18:23Z

Hi @kpedro88 , the premix library is ready
/RelValFS_PREMIXUP17_PU50/CMSSW_10_2_9-PU25ns_102X_mc2017_realistic_v5_FastSim-v1/GEN-SIM-DIGI-RAW
Could you please update the dataset name in this PR?

kpedro88 · 2019-01-15T16:15:20Z

please test workflow 25400.17,250399.0,250400.17,250402.17,250405.17,250406.17,250407.17,250408.17,250409.17
thanks @zhenhu

cmsbuild · 2019-01-15T16:15:31Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32619/console Started: 2019/01/15 17:16

cmsbuild · 2019-01-15T16:15:33Z

Pull request #25626 was updated. @pgunnell, @zhenhu, @prebello, @cmsbuild, @kpedro88 can you please check and sign again.

cmsbuild · 2019-01-15T18:31:51Z

+1
Tested at: a188375
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25626/32619/summary.html

cmsbuild · 2019-01-15T18:31:55Z

Comparison job queued.

zhenhu · 2019-01-15T18:34:59Z

+1

cmsbuild · 2019-01-15T19:54:37Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25626/32619/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-25626/250399.0_FS_PREMIXUP15_PU25+FS_PREMIXUP15_PU25
/build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-25626/250400.17_ZEE_13+FS_ZEE_13_PRMXUP17_PU50+HARVESTUP17FS+MINIAODMCUP17FS
/build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-25626/250402.17_TTbar_13+FS_TTbar_13_PRMXUP17_PU50+HARVESTUP17FS+MINIAODMCUP17FS
/build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-25626/250405.17_ZTT_13+FS_ZTT_13_PRMXUP17_PU50+HARVESTUP17FS+MINIAODMCUP17FS
/build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-25626/250406.17_ZMM_13+FS_ZMM_13_PRMXUP17_PU50+HARVESTUP17FS+MINIAODMCUP17FS
/build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-25626/250407.17_NuGun_UP17+FS_NuGun_UP17_PRMXUP17_PU50+HARVESTUP17FS+MINIAODMCUP17FS
/build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-25626/250408.17_QCD_FlatPt_15_3000HS_13+FS_QCD_FlatPt_15_3000HS_13_PRMXUP17_PU50+HARVESTUP17FS+MINIAODMCUP17FS
/build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-25626/250409.17_SMS-T1tttt_mGl-1500_mLSP-100_13+FS_SMS-T1tttt_mGl-1500_mLSP-100_13_PRMXUP17_PU50+HARVESTUP17FS+MINIAODMCUP17FS
/build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-25626/25400.17_ZEE_13+FS_ZEE_13_UP17_PU50+HARVESTUP17FS+MINIAODMCUP17FS

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 2 differences found in the comparisons
DQMHistoTests: Total files compared: 31
DQMHistoTests: Total histograms compared: 3007400
DQMHistoTests: Total failures: 2
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3007208
DQMHistoTests: Total skipped: 190
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
Checked 129 log files, 14 edm output root files, 31 DQM output files

kpedro88 · 2019-01-16T15:22:02Z

+upgrade

cmsbuild · 2019-01-16T15:22:31Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

fabiocos · 2019-01-16T16:31:30Z

+1

separate baseDataSetRelease values for fastsim 2017

55227c1

cmsbuild added this to the CMSSW_10_2_X milestone Jan 11, 2019

cmsbuild added comparison-pending orp-pending pdmv-pending pending-signatures tests-pending upgrade-pending labels Jan 11, 2019

cmsbuild added tests-started and removed tests-pending labels Jan 11, 2019

cmsbuild added comparison-notrun tests-rejected and removed comparison-pending tests-started labels Jan 11, 2019

update base dataset name and content

a188375

cmsbuild removed the comparison-notrun label Jan 15, 2019

cmsbuild added comparison-pending tests-pending and removed tests-rejected labels Jan 15, 2019

cmsbuild added tests-started and removed tests-pending labels Jan 15, 2019

cmsbuild added tests-approved and removed tests-started labels Jan 15, 2019

cmsbuild added pdmv-approved and removed pdmv-pending labels Jan 15, 2019

cmsbuild added comparison-available and removed comparison-pending labels Jan 15, 2019

cmsbuild added fully-signed upgrade-approved and removed pending-signatures upgrade-pending labels Jan 16, 2019

cmsbuild added orp-approved and removed orp-pending labels Jan 16, 2019

cmsbuild merged commit 2c0a243 into cms-sw:CMSSW_10_2_X Jan 16, 2019

fabiocos mentioned this pull request Jan 16, 2019

Revert "Backport FastSim2017 PU and pmx wfs to 10_2_X" #25623

Closed

kpedro88 mentioned this pull request Jan 16, 2019

Fastsim era 2018 and workflows #25683

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

separate baseDataSetRelease values for fastsim 2017 #25626

separate baseDataSetRelease values for fastsim 2017 #25626

kpedro88 commented Jan 11, 2019

cmsbuild commented Jan 11, 2019

kpedro88 commented Jan 11, 2019

cmsbuild commented Jan 11, 2019 •

edited

Loading

cmsbuild commented Jan 11, 2019

cmsbuild commented Jan 11, 2019

kpedro88 commented Jan 11, 2019

makortel commented Jan 11, 2019

zhenhu commented Jan 12, 2019

fabiocos commented Jan 12, 2019

zhenhu commented Jan 12, 2019

kpedro88 commented Jan 12, 2019

zhenhu commented Jan 12, 2019 •

edited

Loading

zhenhu commented Jan 15, 2019

kpedro88 commented Jan 15, 2019

cmsbuild commented Jan 15, 2019 •

edited

Loading

cmsbuild commented Jan 15, 2019

cmsbuild commented Jan 15, 2019

cmsbuild commented Jan 15, 2019

zhenhu commented Jan 15, 2019

cmsbuild commented Jan 15, 2019

kpedro88 commented Jan 16, 2019

cmsbuild commented Jan 16, 2019

fabiocos commented Jan 16, 2019

separate baseDataSetRelease values for fastsim 2017 #25626

separate baseDataSetRelease values for fastsim 2017 #25626

Conversation

kpedro88 commented Jan 11, 2019

cmsbuild commented Jan 11, 2019

kpedro88 commented Jan 11, 2019

cmsbuild commented Jan 11, 2019 • edited Loading

cmsbuild commented Jan 11, 2019

cmsbuild commented Jan 11, 2019

kpedro88 commented Jan 11, 2019

makortel commented Jan 11, 2019

zhenhu commented Jan 12, 2019

fabiocos commented Jan 12, 2019

zhenhu commented Jan 12, 2019

kpedro88 commented Jan 12, 2019

zhenhu commented Jan 12, 2019 • edited Loading

zhenhu commented Jan 15, 2019

kpedro88 commented Jan 15, 2019

cmsbuild commented Jan 15, 2019 • edited Loading

cmsbuild commented Jan 15, 2019

cmsbuild commented Jan 15, 2019

cmsbuild commented Jan 15, 2019

zhenhu commented Jan 15, 2019

cmsbuild commented Jan 15, 2019

kpedro88 commented Jan 16, 2019

cmsbuild commented Jan 16, 2019

fabiocos commented Jan 16, 2019

cmsbuild commented Jan 11, 2019 •

edited

Loading

zhenhu commented Jan 12, 2019 •

edited

Loading

cmsbuild commented Jan 15, 2019 •

edited

Loading