Fixes OOTPU for BTLDigitisation #25496
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25496/7631 |
|
A new Pull Request was created by @pmeridian for master. It involves the following packages: SimFastTiming/FastTimingCommon @cmsbuild, @civanch, @kpedro88, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@pmeridian 10_4_0_mtd2 was already created. Is this needed for any DIGI production? |
|
please test |
|
The tests are being triggered in jenkins. |
|
Yes. Launching the pilot production with mtd2 is OK, but for the 1M events production we will need this |
|
no PU samples should be ok, but there is a protection missing for negative times as moved by MixingModule that affects events with OOT. ETL should be unaffected, but the new digitizer by @casarsa for BTL needs this addition |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
type bug-fix @civanch @kpedro88 this is a critical bug fix for the MTD digitization with PU. According to checks done by @pmeridian and @casarsa this fixes the issue mentioned at the beginning with no observed further drawback |
|
+upgrade |
| (simHitIt->second).hit_info[0][0] += Npe; | ||
| (simHitIt->second).hit_info[0][1] += Npe; | ||
|
|
||
| double distR = 0.5*topo.pitch().second - 0.1*hit.localPosition().y(); |
There was a problem hiding this comment.
these calculations should be done in an "else" statement after the "if" statement below (otherwise the calculations can be done twice for no reason)
this can be addressed in a followup PR
There was a problem hiding this comment.
Indeed. I did not change it to keep it as much as "before", but there is no need to do this twice (anyway our reference D35 will not enter in the if statement)
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
Fixes a problem of using OOTPU hits in BTL giving rise to a large peak at saturated TDC value. Important to be taken for the ongoing DIGI-RECO MTD TDR campaign.
Plots are the BTL rechits time as obtained from a SingleMu Pt10 GUN with average 10 PU events before and after the fix:
Before
After