Add treatment for C-style arrays in friendly class names

[makortel]

I noticed that product class names like bar<foo<int[]>> lead to infinite loop within the friendly name system (to reproduce run edmToFriendlyClassName "bar<foo<int[]>>" ). I suppose that happens because the brackets [] have a special meaning in the regex syntax, and this replacement

cmssw/FWCore/Utilities/src/FriendlyName.cc

Lines 123 to 125 in 623eb35

	std::string theSub = handleTemplateArguments(aMatch);
	regex const eMatch(std::string("(^[^<]*)<")+aMatch+">");
	result = regex_replace(result,eMatch,theSub+"$1");

ends up doing nothing when theSub is int[]. Rather than to mess with the regexes, this PR suggests to add a "standard rename" for C-style arrays.

Tested in 10_4_0_pre3, no changes expected.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25477/7582

[cmsbuild]

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

FWCore/Utilities

@cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @felicepantaleo, @wddgit this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[makortel]

@cmsbuild, please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32129/console Started: 2018/12/11 23:27

[Dr15Jones]

Given std::vector<int> becomes ints, maybe int[] should be intAs in order to keep the plural?

[makortel]

(summarizing short discussion with @Dr15Jones for later reference)
So my intention is not to make C-style arrays to be persisted, but I encountered this when playing with CUDA and smart pointers for CUDA memory (and std::unique_ptr uses [] in the type name for array allocations). Eventually we should build abstractions on top of the unique_ptrs, so this really affects only simple testing.

[makortel]

@Dr15Jones Sounds good (I used pointer as the example).

[makortel]

@cmsbuild, please abort

[cmsbuild]

Jenkins tests are aborted.

[cmsbuild]

The code-checks are being triggered in jenkins.

[makortel]

Done (squashed to the same commit).

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25477/7584

[cmsbuild]

Pull request #25477 was updated. @cmsbuild, @smuzaffar, @Dr15Jones can you please check and sign again.

[davidlange6]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32131/console Started: 2018/12/12 00:43

[Dr15Jones]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[cmsbuild]

+1
Tested at: 2d312b7
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25477/32131/summary.html

[cmsbuild]

Comparison job queued.

[makortel]

I realized that this one is not sufficient to solve the problem I had in hand, but I end to infinite recursion because of std::function as a custom deleter of the unique_ptr (didn't try yet to understand why). I'm not sure though if we want to add support for std::function here. Anyway, my main dislike was the infinite recursion, so maybe we/I should look how change that to an exception?

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25477/32131/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3136422
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3136217
• DQMHistoTests: Total skipped: 204
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[fabiocos]

@makortel not sure how to interpret you last remark: are you still willing to move forward with this code as approved by @Dr15Jones or are you having in mind some further update to this PR?

[makortel]

@fabiocos We discussed with @Dr15Jones and came to the conclusion that it's better to have this PR in as it covers a corner case not covered before.

[fabiocos]

+1