squashed #23799 (New pixel RecHit infrastructure for FastSim (for Phases 0, 1, 2, and beyond))) -- backport to 10_2_X

[ssekmen]

New pixel RecHit infrastructure for FastSim (for Phases 0, 1, 2, and beyond)
backport of squashed #23799 to 10_2_X.

[ssekmen]

please test

[cmsbuild]

A new Pull Request was created by @ssekmen (Sezen Sekmen) for CMSSW_10_2_X.

It involves the following packages:

FastSimulation/TrackingRecHitProducer

@cmsbuild, @ssekmen, @lveldere, @mdhildreth, @civanch can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @matt-komm this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31780/console Started: 2018/11/20 23:51

[cmsbuild]

-1

Tested at: 78e0983

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25309/31780/summary.html

I found follow errors while testing this PR

Failed tests: RelVals AddOn

• RelVals:

When I ran the RelVals I found an error in the following worklfows:
5.1 step1

runTheMatrix-results/5.1_TTbar+TTbarFS+HARVESTFS/step1_TTbar+TTbarFS+HARVESTFS.log

135.4 step1

runTheMatrix-results/135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step1_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log

• AddOn:

I found errors in the following addon tests:

cmsDriver.py TTbar_8TeV_TuneCUETP8M1_cfi --conditions auto:run1_mc --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot Realistic8TeVCollision : FAILED - time: date Wed Nov 21 01:56:22 2018-date Wed Nov 21 01:55:10 2018 s - exit: 21248
cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc_l1stage1 --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_25ns : FAILED - time: date Wed Nov 21 01:56:40 2018-date Wed Nov 21 01:55:26 2018 s - exit: 21248
cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_2016 : FAILED - time: date Wed Nov 21 01:58:41 2018-date Wed Nov 21 01:56:28 2018 s - exit: 21248

[cmsbuild]

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

[fabiocos]

@ssekmen it looks like a file is missing in the backport:

----- Begin Fatal Exception 21-Nov-2018 00:01:06 CET-----------------------
An exception of category 'FileInPathError' occurred while
[0] Constructing the EventProcessor
[1] Constructing module: class=TrackingRecHitProducer label='fastTrackerRecHits'
Exception Message:
edm::FileInPath unable to find file FastSimulation/TrackingRecHitProducer/data/BarrelBig2017.root anywhere in the search path.

Could you please fix it?

[ssekmen]

@fabiocos , this should hopefully be fixed by
cms-sw/cmsdist#4527

[fabiocos]

please test with cms-sw/cmsdist#4527

[cmsbuild]

The tests are being triggered in jenkins.
Using externals from cms-sw/cmsdist#4527
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31892/console

[cmsbuild]

+1
Tested at: 78e0983
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25309/31892/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25309/31892/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 13 differences found in the comparisons
• DQMHistoTests: Total files compared: 31
• DQMHistoTests: Total histograms compared: 3007299
• DQMHistoTests: Total failures: 30774
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2976335
• DQMHistoTests: Total skipped: 190
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
• Checked 129 log files, 14 edm output root files, 31 DQM output files

[ssekmen]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1