Implement an EDFilter to select events based on their bunch crossing number (master) #25018

fwyzard · 2018-10-26T14:14:43Z

Implement a global EDFilter BunchCrossingFilter to select events based on their bunch crossing number (between 1 and 3564 inclusive).
Include a test configuration based on 2018 data.

cmsbuild · 2018-10-26T14:15:00Z

The code-checks are being triggered in jenkins.

fwyzard · 2018-10-26T14:16:09Z

type new-feature

fwyzard · 2018-10-26T14:16:29Z

@cmsbuild, please test

cmsbuild · 2018-10-26T14:20:12Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25018/6993

cmsbuild · 2018-10-26T14:20:31Z

The tests are being triggered in jenkins.

cmsbuild · 2018-10-26T14:20:33Z

A new Pull Request was created by @fwyzard (Andrea Bocci) for master.

It involves the following packages:

FWCore/Modules

@cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @wddgit this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

makortel · 2018-10-26T14:25:06Z

FWCore/Modules/src/BunchCrossingFilter.cc

+  void
+  BunchCrossingFilter::fillDescriptions(ConfigurationDescriptions& descriptions) {
+    ParameterSetDescription desc;
+    desc.add<unsigned int>("bunches")->setComment("Accept an event if its bunch crossing is in the list.");


This is inconsistent with line 28 that gets std::vector<unsigned int>.

Thanks for catching it.

Martin-Grunewald · 2018-10-26T14:48:13Z

Whats the difference to #25017

cmsbuild · 2018-10-26T14:57:38Z

The code-checks are being triggered in jenkins.

cmsbuild · 2018-10-26T14:59:08Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25018/6996

cmsbuild · 2019-01-09T21:31:07Z

The code-checks are being triggered in jenkins.

Implement a global EDFilter "BunchCrossingFilter" to select events based on their bunch crossing number (between 1 and 3564 inclusive). Include a test configuration based on 2018 data.

cmsbuild · 2019-01-09T21:34:34Z

The code-checks are being triggered in jenkins.

fwyzard · 2019-01-09T21:37:04Z

@cmsbuild, please test

cmsbuild · 2019-01-09T21:40:13Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25018/7912

This PR adds an extra 16KB to repository

cmsbuild · 2019-01-09T21:40:38Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32506/console Started: 2019/01/09 22:42

cmsbuild · 2019-01-09T21:40:41Z

Pull request #25018 was updated. @cmsbuild, @smuzaffar, @Dr15Jones can you please check and sign again.

Dr15Jones · 2019-01-09T21:46:20Z

+1

cmsbuild · 2019-01-09T21:46:46Z

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild · 2019-01-10T00:00:13Z

+1
Tested at: 18d72fb
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25018/32506/summary.html

cmsbuild · 2019-01-10T00:00:19Z

Comparison job queued.

cmsbuild · 2019-01-10T01:40:34Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25018/32506/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 2 differences found in the comparisons
DQMHistoTests: Total files compared: 33
DQMHistoTests: Total histograms compared: 3153717
DQMHistoTests: Total failures: 2
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3153511
DQMHistoTests: Total skipped: 204
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
Checked 137 log files, 14 edm output root files, 33 DQM output files

fabiocos · 2019-01-10T09:58:39Z

+1

cmsbuild added this to the CMSSW_10_4_X milestone Oct 26, 2018

cmsbuild added code-checks-pending comparison-pending core-pending orp-pending pending-signatures tests-pending labels Oct 26, 2018

This was referenced Oct 26, 2018

Implement an EDFilter to select events based on their bunch crossing number (10.3.x) #25019

Closed

Implement an EDFilter to select events based on their bunch crossing number (10.2.x) #25020

Merged

cmsbuild added the new-feature label Oct 26, 2018

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 26, 2018

cmsbuild added tests-started and removed tests-pending labels Oct 26, 2018

makortel reviewed Oct 26, 2018

View reviewed changes

Martin-Grunewald mentioned this pull request Oct 26, 2018

add EDFilter for selecting / vetoing events based on their BX #25017

Closed

cmsbuild added code-checks-pending tests-pending and removed code-checks-approved tests-started labels Oct 26, 2018

cmsbuild removed the code-checks-pending label Oct 26, 2018

Implement an EDFilter to select events based on their bunch crossing

18d72fb

Implement a global EDFilter "BunchCrossingFilter" to select events based on their bunch crossing number (between 1 and 3564 inclusive). Include a test configuration based on 2018 data.

fwyzard force-pushed the BunchCrossingFilter_104x branch from e2c4085 to 18d72fb Compare January 9, 2019 21:34

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 9, 2019

cmsbuild added tests-started and removed tests-pending labels Jan 9, 2019

cmsbuild added core-approved fully-signed and removed core-pending pending-signatures labels Jan 9, 2019

cmsbuild added tests-approved and removed tests-started labels Jan 10, 2019

cmsbuild added comparison-available and removed comparison-pending labels Jan 10, 2019

cmsbuild added orp-approved and removed orp-pending labels Jan 10, 2019

cmsbuild merged commit 634409f into cms-sw:master Jan 10, 2019

fwyzard deleted the BunchCrossingFilter_104x branch January 10, 2019 10:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement an EDFilter to select events based on their bunch crossing number (master) #25018

Implement an EDFilter to select events based on their bunch crossing number (master) #25018

fwyzard commented Oct 26, 2018 •

edited

Loading

cmsbuild commented Oct 26, 2018

fwyzard commented Oct 26, 2018

fwyzard commented Oct 26, 2018

cmsbuild commented Oct 26, 2018

cmsbuild commented Oct 26, 2018

cmsbuild commented Oct 26, 2018

makortel Oct 26, 2018

fwyzard Oct 26, 2018

Martin-Grunewald commented Oct 26, 2018

cmsbuild commented Oct 26, 2018

cmsbuild commented Oct 26, 2018

cmsbuild commented Jan 9, 2019

cmsbuild commented Jan 9, 2019

fwyzard commented Jan 9, 2019

cmsbuild commented Jan 9, 2019

cmsbuild commented Jan 9, 2019 •

edited

Loading

cmsbuild commented Jan 9, 2019

Dr15Jones commented Jan 9, 2019

cmsbuild commented Jan 9, 2019

cmsbuild commented Jan 10, 2019

cmsbuild commented Jan 10, 2019

cmsbuild commented Jan 10, 2019

fabiocos commented Jan 10, 2019

Implement an EDFilter to select events based on their bunch crossing number (master) #25018

Implement an EDFilter to select events based on their bunch crossing number (master) #25018

Conversation

fwyzard commented Oct 26, 2018 • edited Loading

cmsbuild commented Oct 26, 2018

fwyzard commented Oct 26, 2018

fwyzard commented Oct 26, 2018

cmsbuild commented Oct 26, 2018

cmsbuild commented Oct 26, 2018

cmsbuild commented Oct 26, 2018

makortel Oct 26, 2018

Choose a reason for hiding this comment

fwyzard Oct 26, 2018

Choose a reason for hiding this comment

Martin-Grunewald commented Oct 26, 2018

cmsbuild commented Oct 26, 2018

cmsbuild commented Oct 26, 2018

cmsbuild commented Jan 9, 2019

cmsbuild commented Jan 9, 2019

fwyzard commented Jan 9, 2019

cmsbuild commented Jan 9, 2019

cmsbuild commented Jan 9, 2019 • edited Loading

cmsbuild commented Jan 9, 2019

Dr15Jones commented Jan 9, 2019

cmsbuild commented Jan 9, 2019

cmsbuild commented Jan 10, 2019

cmsbuild commented Jan 10, 2019

cmsbuild commented Jan 10, 2019

fabiocos commented Jan 10, 2019

fwyzard commented Oct 26, 2018 •

edited

Loading

cmsbuild commented Jan 9, 2019 •

edited

Loading