Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HCALDQM: Add FCDTask for FCD demonstrator (10_3_X) #24605

Merged
merged 2 commits into from
Sep 27, 2018

Conversation

DryRun
Copy link
Contributor

@DryRun DryRun commented Sep 20, 2018

Adds a new task to the online DQM HCAL application for monitoring the FCD (forward Cherenkov detector) demonstrator.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@DryRun DryRun changed the title HCALDQM: Add FCDTask for FCD demonstrator HCALDQM: Add FCDTask for FCD demonstrator (10_3_X) Sep 20, 2018
@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @DryRun (David Yu) for master.

It involves the following packages:

DQM/HcalTasks
DQM/Integration

@kmaeshima, @cmsbuild, @andrius-k, @jfernan2, @schneiml can you please review it and eventually sign? Thanks.
@makortel, @deguio, @threus, @batinkov, @thomreis this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@andrius-k
Copy link

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 21, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30550/console Started: 2018/09/21 15:10

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24605/30550/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3146746
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3146548
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@andrius-k
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

@DryRun @andrius-k as far as I can see this code is not running anywhere in the test workflows, am I correct? How was it practically tested?

@andrius-k
Copy link

@fabiocos this is a forwardport of PR #24607 which was tested in online playback.

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 6cb583d into cms-sw:master Sep 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants