10_2_X backport of PF HEM mitigation

[gpetruc]

Backport of #24212 + #24367 + #24320
As said in the RECO meeting, we I don't know if we want to integrate this backport or not, but it's useful to have the PR in case we do.

[cmsbuild]

A new Pull Request was created by @gpetruc (Giovanni Petrucciani) for CMSSW_10_2_X.

It involves the following packages:

Configuration/Eras
Configuration/StandardSequences
DataFormats/CaloRecHit
DataFormats/EgammaCandidates
Geometry/CaloTopology
HLTrigger/Configuration
RecoEgamma/EgammaElectronAlgos
RecoEgamma/EgammaElectronProducers
RecoEgamma/EgammaIsolationAlgos
RecoEgamma/EgammaPhotonProducers
RecoJets/JetProducers
RecoLocalCalo/CaloTowersCreator
RecoParticleFlow/PFClusterProducer
RecoParticleFlow/PFProducer

@perrotta, @cmsbuild, @civanch, @Dr15Jones, @silviodonato, @cvuosalo, @fwyzard, @ianna, @mdhildreth, @Martin-Grunewald, @franzoni, @slava77, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@TaiSakuma, @yslai, @felicepantaleo, @jainshilpi, @rappoccio, @Martin-Grunewald, @lgray, @geoff-smith, @seemasharmafnal, @mmarionncern, @makortel, @varuns23, @jdolen, @Sam-Harper, @GiacomoSguazzoni, @rovere, @VinInn, @jdamgov, @nhanvtran, @gkasieczka, @schoef, @dgulhan, @clelange, @ahinzmann, @cbernet, @mariadalfonso, @bachtis this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[gpetruc]

type backport

[gpetruc]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30124/console Started: 2018/08/29 16:16

[cmsbuild]

+1
Tested at: 25d771d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24407/30124/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24407/30124/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 31
• DQMHistoTests: Total histograms compared: 2893368
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2893176
• DQMHistoTests: Total skipped: 190
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
• Checked 129 log files, 14 edm output root files, 31 DQM output files

[ianna]

+1

[slava77]

+1

for #24407 25d771d

• the joint backport is correct: changes are the same as a combination of Code for PF HEM 15-16 mitigation #24212 + Run2-hcx181 Correct accessing constituents of CaloTower #24367 + Dataformats and inputs only for PF HEM 15-16 mitigation #24320
• jenkins tests pass and comparisons with the baseline show no differences

@fabiocos @kpedro88
This PR has additions in the data formats which fill hcal validity booleans in electrons and photons.
Addition of a value was usually acceptable in the past as an exception for the policy for production releases.
We will need to change the prompt reco output version if a release with this PR is deployed at T0.

[Martin-Grunewald]

+1

[kpedro88]

+1

[kpedro88]

merge