New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run2-hcx183 Try remove some comments from Static Analyzer reported in #24361 #24386

Merged

cmsbuild merged 2 commits into cms-sw:master from bsunanda:Run2-hcx183

Aug 30, 2018

Contributor

bsunanda commented Aug 24, 2018

No description provided.


          Try remove some comments from Static Analyzer reported in cms-sw#24361

a70e353

cmsbuild added this to the CMSSW_10_3_X milestone

cmsbuild added code-checks-pending comparison-pending dqm-pending geometry-pending orp-pending pending-signatures simulation-pending tests-pending labels

Contributor

cmsbuild commented Aug 24, 2018

The code-checks are being triggered in jenkins.

bsunanda changed the title ~~RUn2-hcx183 Try remove some comments from Static Analyzer reported in #24361~~ Run2-hcx183 Try remove some comments from Static Analyzer reported in #24361

Contributor

cmsbuild commented Aug 24, 2018

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24386/6159

cmsbuild added code-checks-approved and removed code-checks-pending labels

Contributor

cmsbuild commented Aug 24, 2018

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

Geometry/HcalCommonData
SimG4CMS/Calo
Validation/HcalHits

@andrius-k, @Dr15Jones, @kmaeshima, @cvuosalo, @schneiml, @ianna, @mdhildreth, @cmsbuild, @jfernan2, @civanch can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

bsunanda mentioned this pull request

Phase2-hgx142 Change partitioning scintillator tiles along eta for constant radius #24361

Merged

Contributor

davidlange6 commented Aug 24, 2018

please test

Contributor

cmsbuild commented Aug 24, 2018 •

edited

Loading

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30052/console Started: 2018/08/25 01:48

cmsbuild added tests-started and removed tests-pending labels

Contributor

cmsbuild commented Aug 25, 2018

+1
Tested at: a70e353
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24386/30052/summary.html

Contributor

cmsbuild commented Aug 25, 2018

Comparison job queued.

cmsbuild added tests-approved and removed tests-started labels

Contributor

cmsbuild commented Aug 25, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24386/30052/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 31
DQMHistoTests: Total histograms compared: 2992850
DQMHistoTests: Total failures: 2
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2992658
DQMHistoTests: Total skipped: 190
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
Checked 129 log files, 14 edm output root files, 31 DQM output files

cmsbuild added comparison-available and removed comparison-pending labels

ianna suggested changes

View reviewed changes

SimG4CMS/Calo/interface/HcalTestAnalysis.h Outdated

-                std::vector<CaloHit>      caloHitCache;
-                std::vector<int>          group_, tower_;
-                int                       nGroup, nTower;
+                std::vector<CaloHit>                     caloHitCache;

Contributor

ianna Aug 27, 2018

@bsunanda - please, rename all private members to have trailing underscore for consistency.

SimG4CMS/Calo/interface/HcalTestAnalysis.h Outdated

    
                int                       nGroup, nTower;

                std::vector<CaloHit>                     caloHitCache; 

                std::vector<int>                         group_, tower_;

                int                                      nGroup, nTower;

Contributor

ianna Aug 27, 2018

@bsunanda - please, rename all private members to have trailing underscore for consistency.

SimG4CMS/Calo/interface/HcalTestAnalysis.h Outdated

    
                unsigned int                             count;                  

                double                                   edepEB, edepEE, edepHB, edepHE;

                double                                   edepHO, edepl[20];

                double                                   mudist[20];   // Distance of muon from central part

Contributor

ianna Aug 27, 2018

@bsunanda - please, rename all private members to have trailing underscore for consistency.

SimG4CMS/Calo/interface/HcalTestAnalysis.h Outdated

-                double                    mudist[20];   // Distance of muon from central part
+                unsigned int                             count;
+                double                                   edepEB, edepEE, edepHB, edepHE;
+                double                                   edepHO, edepl[20];

Contributor

ianna Aug 27, 2018

@bsunanda - please, rename all private members to have trailing underscore for consistency.

SimG4CMS/Calo/interface/HcalTestAnalysis.h Outdated

-                double                    edepl[20];
-                double                    mudist[20];   // Distance of muon from central part
+                unsigned int                             count;
+                double                                   edepEB, edepEE, edepHB, edepHE;

Contributor

ianna Aug 27, 2018

@bsunanda - please, rename all private members to have trailing underscore for consistency.

SimG4CMS/Calo/interface/HcalTestAnalysis.h Outdated

-                double                    edepEB, edepEE, edepHB, edepHE, edepHO;
-                double                    edepl[20];
-                double                    mudist[20];   // Distance of muon from central part
+                unsigned int                             count;

Contributor

ianna Aug 27, 2018

@bsunanda - please, rename all private members to have trailing underscore for consistency.

andrius-k commented Aug 27, 2018

+1
Fine for DQM (no significant changes)

Contributor

cmsbuild commented Aug 27, 2018

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24386/6177

cmsbuild added code-checks-approved and removed code-checks-pending labels

Contributor

cmsbuild commented Aug 27, 2018 •

edited

Loading

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30071/console Started: 2018/08/27 16:58

Contributor

cmsbuild commented Aug 27, 2018

Pull request #24386 was updated. @andrius-k, @Dr15Jones, @kmaeshima, @cvuosalo, @schneiml, @ianna, @mdhildreth, @cmsbuild, @jfernan2, @civanch can you please check and sign again.

cmsbuild added tests-started and removed tests-pending labels

Contributor

cmsbuild commented Aug 27, 2018

+1
Tested at: e18171c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24386/30071/summary.html

Contributor

cmsbuild commented Aug 27, 2018

Comparison job queued.

cmsbuild added tests-approved and removed tests-started labels

Contributor

cmsbuild commented Aug 27, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24386/30071/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 2 differences found in the comparisons
DQMHistoTests: Total files compared: 31
DQMHistoTests: Total histograms compared: 2992850
DQMHistoTests: Total failures: 7
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2992653
DQMHistoTests: Total skipped: 190
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
Checked 129 log files, 14 edm output root files, 31 DQM output files

cmsbuild added comparison-available and removed comparison-pending labels

andrius-k commented Aug 27, 2018

+1
No changes for DQM

cmsbuild added dqm-approved and removed dqm-pending labels

Contributor

ianna commented Aug 28, 2018

+1

cmsbuild added geometry-approved and removed geometry-pending labels

Contributor

civanch commented Aug 28, 2018

+1

cmsbuild added fully-signed simulation-approved and removed pending-signatures simulation-pending labels

Contributor

cmsbuild commented Aug 28, 2018

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

Contributor

kpedro88 commented Aug 30, 2018

+1

cmsbuild added orp-approved and removed orp-pending labels

cmsbuild merged commit 3d33c11 into cms-sw:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code-checks-approved comparison-available dqm-approved fully-signed geometry-approved orp-approved simulation-approved tests-approved