DeepFlavour deltaR calculation fix

[emilbols]

In DeepFlavour deltaR between the vertex and jet should be calculated using the sv momentum instead of the sv flight direction. This also means that its not necessary to do any special treatment of deltaR in the negative tagger, so no flip is performed.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23781/5470

[cmsbuild]

A new Pull Request was created by @emilbols for master.

It involves the following packages:

RecoBTag/TensorFlow

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@imarches, @smoortga, @acaudron, @HeinerTholen, @JyothsnaKomaragiri, @mverzett, @ferencek, @pvmulder this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/29088/console Started: 2018/07/12 14:04

[cmsbuild]

+1
Tested at: 319c283
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23781/29088/summary.html

[cmsbuild]

Comparison job queued.

[slava77]

type bugfix

[slava77]

@fabiocos we will need this for 10_2_X

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23781/29088/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 105 differences found in the comparisons
• DQMHistoTests: Total files compared: 31
• DQMHistoTests: Total histograms compared: 2892290
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2892099
• DQMHistoTests: Total skipped: 190
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
• Checked 128 log files, 14 edm output root files, 31 DQM output files

[fabiocos]

@slava77 @perrotta ok, please let me know when this is going to be approved, I understand this affects the b-tagging quality

[slava77]

+1

for #23781 319c283

• implemented as described
• jenkins tests pass and comparisons with the baseline show (somewhat small) differences in the b-tagging variables in the miniAOD outputs.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1