Revert "Run2-hcx180 Fix a bug for HcalDetId which affects DQM of calibration channels"

[fabiocos]

Reverts #23688

This fix is causing a list of reproducible crashes in the IB CMSSW_9_4_X_2018-07-03-2300 in 2016 workflows within DQM with the exception

----- Begin Fatal Exception 04-Jul-2018 10:09:31 CEST-----------------------
An exception of category 'Conditions not found' occurred while
[0] Processing Event run: 283877 lumi: 17 event: 27631378 stream: 1
[1] Running path 'dqmoffline_step'
[2] Calling method for module DigiTask/'digiTask'
Exception Message:
Unavailable Conditions of type HcalQIEData for cell (0x4e280440) (CastorRadFacility 1 / 2 / 0)
----- End Fatal Exception -------------------------------------------------

triggered from

https://cmssdt.cern.ch/lxr/source/CondFormats/CastorObjects/interface/CastorCondObjectContainer.h#0090

as used in the module https://cmssdt.cern.ch/lxr/source/DQM/HcalTasks/python/DigiTask.py for what I can see.

I temporarily revert it, pending a clarification and a fix for this problem.

[fabiocos]

@bsunanda FYI

[fabiocos]

please test workflow 136.77,136.775,136.779

[cmsbuild]

A new Pull Request was created by @fabiocos (Fabio Cossutti) for CMSSW_9_4_X.

It involves the following packages:

DataFormats/HcalDetId

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel, @mariadalfonso, @rovere this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28999/console Started: 2018/07/04 10:47

[cmsbuild]

+1
Tested at: 39406d3
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23739/28999/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23739/28999/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-23739/136.775_RunSingleEl2016H+RunSingleEl2016H+HLTDR2_2016+RECODR2_2016reHLT_Prompt+HARVESTDR2
• /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-23739/136.779_RunMuOnia2016H+RunMuOnia2016H+HLTDR2_2016+RECODR2_2016reHLT_skimMuOnia_Prompt+HARVESTDR2
• /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-23739/136.77_RunDoubleEG2016H+RunDoubleEG2016H+HLTDR2_2016+RECODR2_2016reHLT_skimDoubleEG_Prompt+HARVESTDR2

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 27
• DQMHistoTests: Total histograms compared: 2721493
• DQMHistoTests: Total failures: 105
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2721226
• DQMHistoTests: Total skipped: 162
• DQMHistoTests: Total Missing objects: 0

[fabiocos]

+1

[fabiocos]

merge

[bsunanda]

I believe this bug fix has opened up a bug in the DQM system which is supposed not to look into condition objects for some of the special DetId's. These are the ones for CRF channels. I believe the current code is good but the DQM code involving condition objects for the special channels needs a fix. It is good that this is exposed. The code for 8_0_X will not face this because the CRF channels did not exist in the data for that period.

[fabiocos]

@bsunanda thanks, in any case if this backport is desired, the whole chain should be functional. @DryRun I guess you are looking after the HCAL DQM, could you please check?

[DryRun]

Hi @fabiocos, yes, I'll try to check this today!