Phase2-hgx119 HGCDigi can work with generic DetId

[bsunanda]

DetId class changed for HGC from HGCal to HGCSilicon and from Hcal to HGCScintillator. Accordingly Digi collection now depends on generic DetId

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23690/5349

[cmsbuild]

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

DataFormats/HGCDigi
SimCalorimetry/HGCalSimProducers

@cmsbuild, @civanch, @kpedro88, @mdhildreth can you please review it and eventually sign? Thanks.
@vandreev11, @sethzenz, @makortel, @rovere, @lgray, @cseez, @pfs, @kpedro88 this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@cmsbuild Please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28914/console Started: 2018/06/26 21:32

[bsunanda]

@fabiocos This may be the last change to DataFormats

[kpedro88]

@bsunanda I do think this makes more sense in general. But a few questions/comments:

1. Removing the old definitions prevents us from reading old files.
2. If the first template parameter of the HGCDataFrame class will always be DetId, it doesn't need to be a template parameter at all.

However, if we keep the old dataframe types defined, we can keep the first template parameter in HGCDataFrame. Then we could just have a new typedef HGCDataFrame<DetId,HGCSample> HGCalDataFrame or something, and use that everywhere in the code from now on.

[bsunanda]

@kpedro88 I agree with you. I shall restore the old definitions in classes.h and the xml files. Do I need to change the typedef for DigiCollections? Are Digi's stored as persistent objects?

[kpedro88]

Yes, digis are stored persistently, so it's better not to change the typedefs.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23690/5351

[kpedro88]

@bsunanda will you update the digitizer code (HGCDigitizer, HGCDigiProducer, PreMixingHGCalWorker) and local reco code (HGCalUncalibRecHit... classes) to use the new digi collection type for the new geometry?
See f2629c3 and 6a053c5 from when I changed the BH collection in #23545.

[bsunanda]

@kpedro88 Could you please take care of them? I am concentrating on geometry issue now

[bsunanda]

@cmsbuild Please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28915/console Started: 2018/06/26 23:34

[kpedro88]

@bsunanda okay, I will do it once this is merged.

[cmsbuild]

+1
Tested at: b2a4013
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23690/28915/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23690/28915/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 31
• DQMHistoTests: Total histograms compared: 2899480
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2899289
• DQMHistoTests: Total skipped: 190
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
• Checked 128 log files, 14 edm output root files, 31 DQM output files

[civanch]

+1

[kpedro88]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

@bsunanda @kpedro88 were these DataFormats already used in past productions?

[kpedro88]

@fabiocos yes, that's why we kept them here.

[fabiocos]

@kpedro88 sorry, I obviously mean the removed ones: anHGCEEDataFrame, anHGCHEDataFrame...

[bsunanda]

I tried to explain that the removed ones were not used at least for 2 years once the hexagonal design is chosen and became operational. The codes for square cells do not exist in other parts of CMSSW. So there is no scope to use them anywhere anymore

________________________________ From: Fabio Cossutti [[email protected]] Sent: 06 July 2018 09:33 To: cms-sw/cmssw Cc: Sunanda Banerjee; Mention Subject: Re: [cms-sw/cmssw] Phase2-hgx119 HGCDigi can work with generic DetId (#23690) @fabiocos commented on this pull request.

________________________________ In DataFormats/HGCDigi/src/classes.h<#23690 (comment)>:

@@ -18,22 +24,6 @@ namespace DataFormats_HGCDigi {

std::vector<HGCDataFrame<HcalDetId,HGCSample> > vHGCalBHDataFrames; edm::SortedCollection< HGCDataFrame<HcalDetId,HGCSample> > scHGCalBHDataFrames; edm::Wrapper< edm::SortedCollection< HGCDataFrame<HcalDetId,HGCSample> > > prodHGCalBHDataFrames; - @kpedro88<https://github.com/kpedro88> sorry, I obviously mean the removed ones: anHGCEEDataFrame, anHGCHEDataFrame... — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#23690 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AEzMurFXoucFJSLJB8ABbMRvaFxvjd3Bks5uDxLIgaJpZM4U4iqP>.

[fabiocos]

+1