Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speedup puppi [94X] #23271

Merged
merged 6 commits into from
Jun 3, 2018
Merged

Speedup puppi [94X] #23271

merged 6 commits into from
Jun 3, 2018

Conversation

kpedro88
Copy link
Contributor

backport of #23270

intended to speed up analysis, no changes expected

@cmsbuild
Copy link
Contributor

cmsbuild commented May 21, 2018

A new Pull Request was created by @kpedro88 (Kevin Pedro) for CMSSW_9_4_X.

It involves the following packages:

CommonTools/PileupAlgos

@perrotta, @monttj, @cmsbuild, @slava77, @gpetruc, @arizzi can you please review it and eventually sign? Thanks.
@ahinzmann, @jdolen, @rappoccio, @gkasieczka this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@kpedro88
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 21, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28087/console Started: 2018/05/21 16:50

@slava77
Copy link
Contributor

slava77 commented May 21, 2018

no backports, please

@kpedro88
Copy link
Contributor Author

why not?

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23271/28087/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 27
  • DQMHistoTests: Total histograms compared: 2721493
  • DQMHistoTests: Total failures: 103
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2721228
  • DQMHistoTests: Total skipped: 162
  • DQMHistoTests: Total Missing objects: 0

@slava77
Copy link
Contributor

slava77 commented May 31, 2018

@kpedro88
please bring this in sync with #23270.
thank you.

@cmsbuild
Copy link
Contributor

Pull request #23271 was updated. @perrotta, @monttj, @cmsbuild, @slava77, @gpetruc, @arizzi can you please check and sign again.

@kpedro88
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 31, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28346/console Started: 2018/05/31 21:51

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23271/28346/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 27
  • DQMHistoTests: Total histograms compared: 2721493
  • DQMHistoTests: Total failures: 111
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2721220
  • DQMHistoTests: Total skipped: 162
  • DQMHistoTests: Total Missing objects: 0

@slava77
Copy link
Contributor

slava77 commented Jun 1, 2018

+1

for #23271 ef92a19

  • technical changes (not affecting the physics output) to speedup the execution
  • the backport is correct (the same changes as in Speedup puppi #23270 d0482fd)
  • jenkins tests pass and comparisons with the baseline show no differences

@fabiocos
Copy link
Contributor

fabiocos commented Jun 3, 2018

+1

to be validated in parallelo to its master version in the test build for reminiAOD 2016

@fabiocos
Copy link
Contributor

fabiocos commented Jun 3, 2018

merge

@cmsbuild cmsbuild merged commit 124ccfa into cms-sw:CMSSW_9_4_X Jun 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants