Use FormulaEvaluator for JER [94X]

[kpedro88]

backport of #23106

also includes a patch from #22354 to prevent segfaults

intended to speed up analysis; no changes were observed in my private tests, so I think it can go to the main branch rather than the analysis branch.

[cmsbuild]

A new Pull Request was created by @kpedro88 (Kevin Pedro) for CMSSW_9_4_X.

It involves the following packages:

CommonTools/Utils
CondFormats/JetMETObjects

@perrotta, @monttj, @cmsbuild, @gpetruc, @slava77, @ggovi, @arizzi can you please review it and eventually sign? Thanks.
@TaiSakuma, @jdolen, @makortel, @rappoccio, @mmarionncern, @jdamgov, @ahinzmann, @nhanvtran, @gkasieczka, @schoef, @mmusich, @mariadalfonso, @seemasharmafnal this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

• Backported from Use FormulaEvaluator for JER #23106

[kpedro88]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27737/console Started: 2018/05/01 23:55

[cmsbuild]

Pull request #23107 was updated. @perrotta, @monttj, @cmsbuild, @gpetruc, @slava77, @ggovi, @arizzi can you please check and sign again.

[kpedro88]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27738/console Started: 2018/05/02 00:57

[cmsbuild]

+1
Tested at: 159a6c2
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23107/27738/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23107/27738/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 27
• DQMHistoTests: Total histograms compared: 2721493
• DQMHistoTests: Total failures: 107
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2721224
• DQMHistoTests: Total skipped: 162
• DQMHistoTests: Total Missing objects: 0

[ggovi]

+1

[slava77]

+1

for #23107 159a6c2

• code changes are in line with the PR description ; this is a technical change to speedup execution

• the backport from the master version (Use FormulaEvaluator for JER #23106 4a4479a) is correct, with an addition of the other technical change in CommonTools/Utils/src/FormulaEvaluator.cc from Properly handle parsing failure in FormulaEvaluator #22354 present in the master since March 2. The port from from Properly handle parsing failure in FormulaEvaluator #22354 does not include the updates in CommonTools/Utils/test/testFormulaEvaluator.cc, which is ~OK in this case of a backport.

• jenkins tests pass and comparisons with the baseline show no differences

[Dr15Jones]

ping
@fabiocos Is anyone signing for analysis?

[fabiocos]

@Dr15Jones as usual there is nobody signing for it (apart for the AN branch and NanoAOD stuff). The master version has been merged and is being validated in pre3. As this PR affects miniAOD as far as I understand, I will merge it after a positive conclusion of that validation

[kpedro88]

To clarify, the code modified by this PR runs in miniAOD, but there should be no changes. Hopefully this will be confirmed in the 10_2_0_pre3 validation.

[fabiocos]

+1

[kpedro88]

@fabiocos needs to be merged manually because of analysis signature

[fabiocos]

merge