Simplify pat jet constituent access 10_1_X

[ahinzmann]

Backport of #22914

[cmsbuild]

A new Pull Request was created by @ahinzmann for CMSSW_10_1_X.

It involves the following packages:

CommonTools/RecoAlgos
DataFormats/Candidate
DataFormats/PatCandidates
PhysicsTools/NanoAOD

@perrotta, @monttj, @cmsbuild, @slava77, @gpetruc, @arizzi can you please review it and eventually sign? Thanks.
@rappoccio, @gouskos, @makortel, @abbiendi, @rovere, @jdolen, @gkasieczka, @jhgoh, @cbernet, @gpetruc this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

• Backported from Simplify jet constituent access in MiniAOD #22914

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27589/console Started: 2018/04/20 14:50

[cmsbuild]

+1
Tested at: 54c85b9
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23018/27589/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23018/27589/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 29
• DQMHistoTests: Total histograms compared: 2506331
• DQMHistoTests: Total failures: 27
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2506128
• DQMHistoTests: Total skipped: 176
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1.06000000017 KiB( 23 files compared)
• Checked 119 log files, 9 edm output root files, 29 DQM output files

[slava77]

+1

for #23018 54c85b9

• this changes pat::Jet accessor implementation for use cases which are apparently restricted to analysis use cases. No changes are expected in persisted quantities in miniAOD or nanoAOD.
• the backport from Simplify jet constituent access in MiniAOD #22914 9b04b8b is correct.
• jenkins tests pass and comparisons with the baseline show differences only in DQM plots of slimmedJetsAK8 jets which count the jet constituents. These differences are expected.
  • higher stat tests in the nanoAOD CI Monitor CMSSW-master branch cms-nanoAOD/cmssw#90 (comment) show no differences in the nanoAOD variables

[fabiocos]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27740/console Started: 2018/05/02 10:18

[cmsbuild]

+1
Tested at: 54c85b9
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23018/27740/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23018/27740/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 29
• DQMHistoTests: Total histograms compared: 2506331
• DQMHistoTests: Total failures: 27
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2506128
• DQMHistoTests: Total skipped: 176
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.752 KiB( 28 files compared)
• DQMHistoSizes: changed ( 1306.0 ): 0.009 KiB HLT/EventInfo
• DQMHistoSizes: changed ( 1306.0 ): 0.008 KiB L1T/EventInfo
• DQMHistoSizes: changed ( 1306.0,... ): 0.005 KiB RecoTauV/EventInfo
• DQMHistoSizes: changed ( 1306.0,... ): 0.005 KiB Ecal/EventInfo
• DQMHistoSizes: changed ( 1306.0,... ): 0.004 KiB L1TEMU/EventInfo
• DQMHistoSizes: changed ( 1306.0,... ): 0.004 KiB Pixel/EventInfo
• DQMHistoSizes: changed ( 1306.0,... ): 0.003 KiB SiStrip/EventInfo
• DQMHistoSizes: changed ( 1306.0,... ): 0.003 KiB Muons/EventInfo
• DQMHistoSizes: changed ( 1306.0,... ): 0.002 KiB Tracking/EventInfo
• DQMHistoSizes: changed ( 1306.0,... ): 0.002 KiB DT/EventInfo
• DQMHistoSizes: changed ( 1306.0 ): ...
• Checked 119 log files, 9 edm output root files, 29 DQM output files

[fabiocos]

+1

[fabiocos]

merge