Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CTPPS: updated DQM for 2018 data taking (10_1_X) #22858

Merged
merged 5 commits into from
Apr 6, 2018

Conversation

forthommel
Copy link
Contributor

backport of #22447

This PR updates the DQM:

  • Tomography is now using pixel detectors instead of strip (not installed anymore)
  • Efficiency of diamond channels wrt to other diamonds and wrt to pixel detectors
  • Increased flexibility of hitmaps: the horizontal position of diamond (horizontalShiftOfDiamond_) is retrieved from the geometry and this value is subtracted such that the hitmaps are always starting from x=0. In a similar way, the offset with pixel detectors is used to properly display the tomography.
  • Updated tests to cope with CTPPS geometry for 2018 data taking #22264

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2018

A new Pull Request was created by @forthommel (Laurent Forthomme) for CMSSW_10_1_X.

It involves the following packages:

DQM/CTPPS

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor

fabiocos commented Apr 5, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27318/console Started: 2018/04/05 20:04

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22858/27318/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 29
  • DQMHistoTests: Total histograms compared: 2500779
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2500601
  • DQMHistoTests: Total skipped: 176
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 3061.89 KiB( 22 files compared)
  • Checked 119 log files, 9 edm output root files, 29 DQM output files

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2018

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Apr 6, 2018

+1

@cmsbuild cmsbuild merged commit cf4bfbe into cms-sw:CMSSW_10_1_X Apr 6, 2018
@forthommel forthommel deleted the ctpps_diamond_dqm_2018-10_1_X branch April 6, 2018 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants