Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GT Updates : CTPPS Geometry update #22739

Merged
merged 1 commit into from
Mar 26, 2018

Conversation

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@arunhep
Copy link
Contributor Author

arunhep commented Mar 26, 2018

please test

@arunhep
Copy link
Contributor Author

arunhep commented Mar 26, 2018

FYI @ianna @fabferro

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 26, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27108/console Started: 2018/03/26 12:37

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @arunhep (Arun Kumar) for master.

It involves the following packages:

Configuration/AlCa

@ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @lpernie can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @mmusich, @ghellwig, @tocheng this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@fabferro
Copy link
Contributor

@arunhep : thanks Arun.
BTW, CTPPS Ideal geometry is also used as a base for RECOnstruction. Are the corresponding GT's already up to date?

@arunhep
Copy link
Contributor Author

arunhep commented Mar 26, 2018

@fabferro

BTW, CTPPS Ideal geometry is also used as a base for RECOnstruction. Are the corresponding GT's already up to date?

the update was requested in all MC GTs for 2018 and beyond so this PR updates all of them.
For data, the update will be done via IOV appending.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@fabiocos
Copy link
Contributor

@arunhep if this is needed as I understand for 10_1_0 it should enter asap

@arunhep
Copy link
Contributor Author

arunhep commented Mar 26, 2018

+1
(no relvals in matrix here can probe the change) this has been tested by @fabferro in his private tests.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22739/27108/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2560 differences found in the comparisons
  • DQMHistoTests: Total files compared: 29
  • DQMHistoTests: Total histograms compared: 2498300
  • DQMHistoTests: Total failures: 11518
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2486606
  • DQMHistoTests: Total skipped: 176
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.4000000001 KiB( 22 files compared)
  • Checked 118 log files, 9 edm output root files, 29 DQM output files

@fabiocos
Copy link
Contributor

+1

differences look induced by the tag included with the geometry without TOTEM

@cmsbuild cmsbuild merged commit 0d4a53c into cms-sw:master Mar 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants