-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New 2017 5TeV pp beamspot parameters from data (minus pixel barycenter) #22722
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22722/4091 |
A new Pull Request was created by @gsfs for master. It involves the following packages: IOMC/EventVertexGenerators @cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
Comparison is ready Comparison Summary:
|
The affected campaigns are HINppWinter17GS and HINppWinter17wmLHEGS. The requests run in these campaigns (primarily for testing purposes) used beamspot Realistic25ns13TeVEarly2017Collision. The beamspot Realistic5TeVppCollision2017 has not been used in any production. |
+1 |
Port of PR#22703 (which was in 9_3_X) to master
This beamspot will only be used for MC GEN-SIM in 9_3_X but porting to master for future compatibility