Sort GenVisTau collection by their pT in GenVisTauProducer

[ktht]

Discussion: cms-nanoAOD#118

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22683/4053

[cmsbuild]

A new Pull Request was created by @ktht (Karl Ehatäht) for master.

It involves the following packages:

PhysicsTools/HepMCCandAlgos

@gpetruc, @cmsbuild, @arizzi, @monttj can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[gpetruc]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27019/console Started: 2018/03/21 14:25

[gpetruc]

+1
this is only used in NanoAOD at the moment.
Also, previous behaviour was to return the objects in the original order they had in the gen particles, which is arbitrary, so nobody could have been relying on the older ordering.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[cmsbuild]

-1

Tested at: f6e6b08

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22683/27019/summary.html

I found follow errors while testing this PR

Failed tests: AddOn

• AddOn:

I found errors in the following addon tests:

cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_2016 : FAILED - time: date Wed Mar 21 15:39:47 2018-date Wed Mar 21 15:33:57 2018 s - exit: 35584

[cmsbuild]

Comparison job queued.

[arizzi]

it seems the crash is in the fastSimProducer, so likely unrelated to this PR

[arizzi]

I confirm that the crash cannot be repoduced on IB + this PR

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22683/27019/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 29
• DQMHistoTests: Total histograms compared: 2497880
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2497703
• DQMHistoTests: Total skipped: 176
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1.33000000014 KiB( 21 files compared)
• Checked 118 log files, 9 edm output root files, 29 DQM output files

[fabiocos]

please test

I have seen once that issue but was not easily reproducible

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27041/console Started: 2018/03/22 16:32

[cmsbuild]

+1
Tested at: f6e6b08
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22683/27041/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22683/27041/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 29
• DQMHistoTests: Total histograms compared: 2497880
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2497703
• DQMHistoTests: Total skipped: 176
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1.00000000001 KiB( 22 files compared)
• Checked 118 log files, 9 edm output root files, 29 DQM output files

[fabiocos]

+1

pure analysis code