Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import first bunch of features for NanoAOD v2 #22679

Merged
merged 12 commits into from
Mar 26, 2018
Merged

Import first bunch of features for NanoAOD v2 #22679

merged 12 commits into from
Mar 26, 2018

Conversation

arizzi
Copy link
Contributor

@arizzi arizzi commented Mar 20, 2018

  • minor fixes (genlevel masses of bosons and isEE is EB)
  • era switches for MiniAOD V1 vs V2 inputs

Christian Veelken and others added 11 commits February 7, 2018 10:55
added comment that L2L3Residual JEC are safe to use for MC
f04ccd1
@ktht
Whitelist gen-level W,Z from >10 GeV mass cut
6761ec1 
Issue described here: #114
@gpetruc
Merge pull request #116 from ktht/genWZmassFix
e5daf9d 
Whitelist gen-level W,Z from >10 GeV mass cut
@gpetruc
Merge pull request #104 from veelken/nanoAOD
fb8502c 
added comment that L2L3Residual JEC are safe to use for MC
@arizzi
Merge pull request #111 from HEP-KBFI/fixSIGSEGV
2aa9689 
fixed segmentation violation that occurred in subjet analyses in case…
added photon sc eta EB/EE classification
741aa3c
correct eta boundary
fe61d1c
add new variables to DQM plots
aaff8b6
@gpetruc
Merge pull request #123 from AndrewLevin/add_photon_sc_eta_to_nanoaod
9b36db1 
Add two photon sc eta bits to nanoaod
@gpetruc
Add eras run2_nanoAOD_94XMiniAODv1 and run2_nanoAOD_94XMiniAODv2
dad13dc
@gpetruc
Merge pull request #128 from gpetruc/nanoAOD_94X_eras
cf1b841 
Add eras run2_nanoAOD_94XMiniAODv1 and run2_nanoAOD_94XMiniAODv2
@cmsbuild cmsbuild added this to the CMSSW_9_4_AN_X milestone Mar 20, 2018
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @arizzi for CMSSW_9_4_AN_X.

It involves the following packages:

Configuration/Eras
Configuration/StandardSequences
PhysicsTools/NanoAOD

@monttj, @cmsbuild, @franzoni, @gpetruc, @arizzi, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @gpetruc, @ebrondol, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@arizzi
Copy link
Contributor Author

arizzi commented Mar 20, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 20, 2018 •
edited
Loading

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26995/console Started: 2018/03/20 17:34

@arizzi arizzi mentioned this pull request Mar 20, 2018
Merged
@cmsbuild
Copy link
Contributor

+1
Tested at: cf1b841
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22679/26995/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
cf1b841
9b36db1
2aa9689
fb8502c
e5daf9d
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22679/26995/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22679/26995/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22679/26995/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2718773
  • DQMHistoTests: Total failures: 115
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2718496
  • DQMHistoTests: Total skipped: 162
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0 KiB( 0 files compared)
  • Checked 107 log files, 9 edm output root files, 26 DQM output files

@arizzi arizzi changed the base branch from CMSSW_9_4_X to CMSSW_9_4_AN_X March 23, 2018 07:19
@arizzi
Copy link
Contributor Author

arizzi commented Mar 23, 2018

done... I'm not sure anyhow if the bot will recompute the signatures needed

@arizzi
Copy link
Contributor Author

arizzi commented Mar 23, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 23, 2018 •
edited
Loading

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27061/console Started: 2018/03/23 08:49

@arizzi
Copy link
Contributor Author

arizzi commented Mar 23, 2018

@slava77 I think they were separated, it was just github not recomputing the base.

@fabiocos
Copy link
Contributor

@arizzi @gpetruc I understand that this PR is submitted only in the 9_4_AN_X and not in the 9_4_X release because it is based on the port of 9_4_MAOD_X that will not be done in 9_4_X until the code is validated. But then of course it should, I do not see reasons to leave it behind

@arizzi
Copy link
Contributor Author

arizzi commented Mar 23, 2018

it is submitted to 9_4_AN_X also because we need it integrated and built on short timescale, possibly bypassing some code review checks as agreed in the scope of AN releases.
Please note that a second PR will follow today.

cmsbuild added a commit that referenced this pull request Mar 23, 2018
@cmsbuild
Merge pull request #22680 from cms-nanoAOD/master-cmsswmaster
ba0f5ba 
Import first bunch of features for NanoAOD v2 (same as 94XAN #22679)
@cmsbuild
Copy link
Contributor

+1
Tested at: 4a9085a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22679/27061/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
4a9085a
cf1b841
9b36db1
2aa9689
fb8502c
e5daf9d
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22679/27061/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22679/27061/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison job queued.

@prebello
Copy link
Contributor

+1
(based on approved tests)

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22679/27061/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 27
  • DQMHistoTests: Total histograms compared: 2721493
  • DQMHistoTests: Total failures: 107
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2721224
  • DQMHistoTests: Total skipped: 162
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0 KiB( 0 files compared)
  • Checked 110 log files, 9 edm output root files, 27 DQM output files

@arizzi arizzi mentioned this pull request Mar 23, 2018
Merged
@cmsbuild cmsbuild merged commit 4a9085a into cms-sw:CMSSW_9_4_AN_X Mar 26, 2018
@gpetruc gpetruc deleted the masterUpTo128 branch July 17, 2018 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
analysis-approved comparison-available operations-pending orp-pending pending-signatures tests-approved
Projects
None yet
Milestone
CMSSW_9_4_AN_X
Development

Successfully merging this pull request may close these issues.
9 participants
@arizzi @cmsbuild @davidlange6 @makortel @gpetruc @slava77 @fabiocos @prebello @ktht