-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add relval steps for Charmonium PD and MuonPOGSkim (Restart from newer IB) #22665
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22665/4022 |
A new Pull Request was created by @kfjack (Kai-Feng Chen) for master. It involves the following packages: Configuration/PyReleaseValidation @GurpreetSinghChahal, @cmsbuild, @prebello, @kpedro88, @fabozzi can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test workflow 136.835,136.848 |
The tests are being triggered in jenkins. |
-1 Tested at: 90f1ad1 You can see the results of the tests here: I found follow errors while testing this PR Failed tests: RelVals
When I ran the RelVals I found an error in the following worklfows: runTheMatrix-results/136.848_RunCharmonium2017F+RunCharmonium2017F+HLTDR2_2017+RECODR2_2017reHLT_skimCharmonium_Prompt+HARVEST2017/step2_RunCharmonium2017F+RunCharmonium2017F+HLTDR2_2017+RECODR2_2017reHLT_skimCharmonium_Prompt+HARVEST2017.log |
Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped) |
Somehow the input raw files for Charmonium PD are not available from the servers. Could we retest it again? Or try the workflows for other era, e.g. 136.844 for 2017B, 136.845 for 2017C, 136.846 for 2017D, 136.847 for 2017E? |
We should check if they are available at CERN T2 (if not, we have to request a transfer to disk) |
Ok let me check! |
please test workflow 136.835,136.845 |
The tests are being triggered in jenkins. |
Comparison job queued. |
@kfjack can you ask the skim contacts to check the output of this test before we sign off? |
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
@fabozzi I received the confirmation, the skim content is okay. |
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
@fabozzi @prebello are all the needed input files available now? Deploying tests that systematically fail for several days is not very useful. @smuzaffar FYI |
We have tested on the datasets available at CERN T2. Should we ask a Phedex transfer also for the IB? |
+1 |
Add relval steps for MuonPOGSkim and MuonPOGJPsiSkim, restart from newer IB.
MuonPOGSkim is added to the SingleMuon PD relvals
Add new workflow for Charmonium PD and MuonPOGJPsiSkim
For testing MuonPOGSkim with 2017F relval: 136.835
For testing MuonPOGJPsiSkim with 2017F relval: 136.848