Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GT Updates with GEM electronics map, hadronic PF calibrations, JECs for 2017 MC #22642

Merged

Conversation

arunhep
Copy link
Contributor

@arunhep arunhep commented Mar 16, 2018

Summary of changes in Global Tags

RunI simulation

RunII simulation

RunI data

RunII data

Upgrade

2017_MC

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @arunhep (Arun Kumar) for master.

It involves the following packages:

Configuration/AlCa

@ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @lpernie can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @mmusich, @ghellwig, @tocheng this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

This was referenced Mar 16, 2018
@arunhep
Copy link
Contributor Author

arunhep commented Mar 16, 2018

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 16, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26905/console Started: 2018/03/16 12:29

@cmsbuild
Copy link
Contributor

-1

Tested at: e37ad82

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
d19a033
06dde77
767c579
19c3d8d
beb4bef
f0b49cd
a687825
854267e
e589052
cf7c57b
17419b8
d4b1947
b11093b
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22642/26905/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22642/26905/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22642/26905/summary.html

I found follow errors while testing this PR

Failed tests: Build

  • Build:

I found an error when building:

>> Compiling python modules src/DQM/SiStripMonitorCluster/python
>> Done generating edm plugin poisoned information
>> All python modules compiled
>> Plugins of all types refreshed.
gmake[1]: Leaving directory '/build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_1_X_2018-03-14-2300'
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 1


The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
d19a033
06dde77
767c579
19c3d8d
beb4bef
f0b49cd
a687825
854267e
e589052
cf7c57b
17419b8
d4b1947
b11093b
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22642/26905/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22642/26905/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

@arunhep
Copy link
Contributor Author

arunhep commented Mar 16, 2018

the build errors are unrelated to this PR.
Let me try again with the tests.

@arunhep
Copy link
Contributor Author

arunhep commented Mar 16, 2018

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@arunhep
Copy link
Contributor Author

arunhep commented Mar 17, 2018

@perrotta
thanks for pointing it out. i changed the version of frozen GT by mistake. corrected now.

@arunhep
Copy link
Contributor Author

arunhep commented Mar 17, 2018

@cmsbuild please test

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 17, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26938/console Started: 2018/03/17 18:41

@cmsbuild
Copy link
Contributor

Pull request #22642 was updated. @ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @lpernie can you please check and sign again.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22642/26938/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 7795 differences found in the comparisons
  • DQMHistoTests: Total files compared: 29
  • DQMHistoTests: Total histograms compared: 2477528
  • DQMHistoTests: Total failures: 2024
  • DQMHistoTests: Total nulls: 11
  • DQMHistoTests: Total successes: 2475317
  • DQMHistoTests: Total skipped: 176
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.609999999891 KiB( 23 files compared)
  • Checked 118 log files, 9 edm output root files, 29 DQM output files

@arunhep
Copy link
Contributor Author

arunhep commented Mar 19, 2018

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

@arunhep I notice in the comparison differences in Run1 workflows, these are justified by the updates there I assume. This PR also includes all the updates inserted in 9_4_MAOD_X, right?

@arunhep
Copy link
Contributor Author

arunhep commented Mar 19, 2018

@fabiocos

I notice in the comparison differences in Run1 workflows, these are justified by the updates there I assume. This PR also includes all the updates inserted in 9_4_MAOD_X, right?

yes because PF hadronic calibration updates also entered in Run1 workflows.
and yes the JECs which entered 9_4_MAOD_X are also part of this PR.

@fabiocos
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants