-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tau reconstruction based on miniAOD event content #22594
Merged
cmsbuild
merged 129 commits into
cms-sw:master
from
cms-tau-pog:CMSSW_10_1_X_tau-pog_recoOnMiniAOD
Apr 6, 2019
Merged
Changes from all commits
Commits
Show all changes
129 commits
Select commit
Hold shift + click to select a range
6936e12
Tau reco: Moving from PFJet to Jet, and from PFCandidate to Candidate
steggema 46aa930
Tau reco: Moving from PFJet to Jet, and from PFCandidate to Candidate…
steggema da78114
Tau reco: Moving from PFJet to Jet, and from PFCandidate to Candidate…
steggema cc1f640
Tau reco: Moving from PFJet to Jet, and from PFCandidate to Candidate…
steggema c1c0e8c
Tau reco: Moving from PFJet to Jet, and from PFCandidate to Candidate…
steggema 934eb5f
PFTau: Use Candidates instead of PFCandidates, and reference to base …
steggema 0bf3efa
Adapt pat::Tau and related classes/producers to change from PFCandida…
steggema fa7b9f0
Adapt first set of tau algorithms to changes in PFTau data format
steggema eb8795a
Add chargedHadronFromLostTrack builder and adapt related dataformats/…
mbluj 9f728b2
Use Candidate instead of PFCandidate in PFTauTagInfo, following chang…
steggema c013bea
Various adaptions in tau plugins for change in PFTau data format
steggema 47c179e
Adapt rest of plugins and other code in RecoTauTag/RecoTau to changes…
steggema 68e208e
Adapt all tau tag tools to changes in PFTau class
steggema 1264f2c
correct parameter name
mbluj fa59a88
Add Michal's configuration files and simple anti-muon discriminator
steggema 250ff2d
Add tau jet region producer based on PAT Jets
steggema b9f79af
More adaptions due to changes in PFTau class
steggema 5c5c338
More adaptions due to changes in PFTau class
steggema 785e783
Adaptions for changes in PFTau data format
steggema 8e10bcf
Fix Ptr conversion, and remove unused method from common tau utilities
steggema 5f1bf05
Directly construct taus with packed candidate collections filled, if …
steggema ae50708
Make two-prong track pT cleaner plugin work properly for taus from Mi…
steggema ca859e0
Add ioread rules for changes in PFTau
steggema 2065b6e
Add ioread rules for a few changes in data formats
steggema 99a3384
Cleanup following tau code review
steggema 5294f0e
Add specific tau PV producer for taus produced from MiniAOD input (ba…
steggema c9aab96
Add specific tau PV producer for taus produced from MiniAOD input (ba…
steggema 9abe1a1
Add specific tau PV producer for taus produced from MiniAOD input (ba…
steggema f15e59d
Fill additional information also for taus built from MiniAOD input
steggema 3f51e17
Merge pull request #72 from steggema/TauRecoMiniAODSinglePFTauClass_10X
roger-wolf 08863b0
Merge branch 'from-CMSSW_10_1_X_2018-03-02-2300' into CMSSW_10_1_X_ta…
roger-wolf c6437da
added whitespace in template definition
roger-wolf 907147b
new test file
roger-wolf 1379757
adding cfg as initial test file for tau reco based on miniAOD
roger-wolf b77fdca
Fix muon-tau overlap removal
steggema 413e8fb
Update/remove comments for tau reco at MiniAOD
steggema 95d5cef
Remove commented code, and update comments related to tau reco at Min…
steggema 4bdc092
Merge pull request #74 from steggema/TauRecoMiniAODSinglePFTauClass_10X
roger-wolf 78e824d
commiting to be able to swithc branches
roger-wolf 8001aa7
Merge branch 'from-CMSSW_10_1_X_2018-03-12-2300' into CMSSW_10_1_X_ta…
roger-wolf 8bba3d3
moved class definitions from TauReco to JetReco on request by duplica…
roger-wolf d0c7a05
code corrections by clang
roger-wolf 22f3af2
Merge commit 'refs/pull/22594/head' of https://github.com/cms-sw/cmss…
steggema 494f855
Rename Candidate accessors in PFTau, add back PFCandidate accessors, …
steggema 51bdf51
Address various code review comments
steggema 5a25a5b
Address various code review comments
steggema 1b1fff7
Remove leftover exception
steggema 1814e22
Only convert to edm::Ptr if candidate is present
steggema 6098eba
Merged CMSSW_10_1_X_TauRecoMiniAODReview from repository steggema wit…
mbluj ea83bd4
Address style comments: range loops, lower case for variables, duplic…
mbluj 7902388
PV produceres, PF and Mini, prepared to unification
mbluj 83313a1
Unify PVProducers on top of common Base
mbluj 126c000
check both tracks and gsf-tracks in case of electrons
mbluj 962fe35
Rationalize includes and implementation of other Jan's comments
mbluj be005e9
Merge pull request #1 from mbluj/CMSSW_10_1_X_TauRecoMiniAODReviewMB
steggema a827bdf
Merge pull request #75 from steggema/CMSSW_10_1_X_TauRecoMiniAODReview
steggema 32f2eea
Merge branch 'from-CMSSW_10_2_X_2018-04-17-2300' into CMSSW_10_1_X_ta…
roger-wolf 5c0ad96
Unify charged-hadron-from-track plugins, and minor review modifications
steggema d175721
Only allow lost tracks that have a pseudoTrack(), since otherwise the…
steggema 334ffa0
Simplify setting up tau reco@MiniAOD sequence
steggema f77ae6c
adding runtest for tau reconstruction based on miniAOD input
roger-wolf c1f1fce
Allow also charged hadrons to be reconstructed from PackedCandidates …
steggema a73d590
After allowing lost tracks candidates without additional track inform…
steggema 75804b8
Merge branch 'CMSSW_10_1_X_tau-pog_recoOnMiniAOD' into CMSSW_10_1_X_T…
steggema 80b90b2
Merge pull request #76 from steggema/CMSSW_10_1_X_TauRecoMiniAODReview
roger-wolf 01d1881
input file had been overwritten unexpectedly during merge
roger-wolf 71ec9f0
Address a number of code review comments
steggema c7d6c56
Cache also single-PFCandidate returns, and address other review comments
steggema 61ed8c5
Merge remote-tracking branch 'my-cmssw/CMSSW_10_1_X_TauRecoMiniAODRev…
steggema e47442d
Merge branch 'CMSSW_10_1_X_tau-pog_recoOnMiniAOD' into CMSSW_10_1_X_T…
steggema 7289b39
Update configuration for tau reconstruction at MiniAOD, and revert to…
steggema 565657a
Merge remote-tracking branch 'my-cmssw/CMSSW_10_1_X_TauRecoMiniAODRev…
steggema 4285c06
Merge pull request #77 from steggema/CMSSW_10_1_X_TauRecoMiniAODReview
steggema af45120
Avoid casts to PFCandidate
steggema cd2db40
Remove PF from local variable name
steggema 3715377
Merge pull request #78 from steggema/CMSSW_10_1_X_TauRecoMiniAODReview
steggema 5623774
Add I/O directives for new transient data members, and update to more…
steggema 2117526
Merge pull request #79 from steggema/CMSSW_10_1_X_TauRecoMiniAODReview
steggema 3693f3c
Merge branch 'CMSSW_10_3_X' into CMSSW_10_1_X_tau-pog_recoOnMiniAOD
mbluj 9998cdc
Merged CMSSW_10_3_X_recoOnMiniAOD from repository mbluj with cms-merg…
mbluj 0647e3e
update to adjust with changes for tauRecoAtMini
mbluj dc3f2fc
adjust to changes for tauRecoAtMini
mbluj 28881c0
Merge branch 'CMSSW_10_3_X_recoOnMiniAOD_2' of https://github.com/mbl…
mbluj 767d2c4
small fix
mbluj ef7525d
update test configuration
mbluj 0859991
Merge pull request #86 from mbluj/CMSSW_10_3_X_recoOnMiniAOD_2
mbluj 9990723
Merged CMSSW_10_3_X from repository cms-sw with cms-merge-topic
mbluj d2654d6
correct indentation
mbluj 1f32af3
Merge pull request #90 from mbluj/CMSSW_10_3_X_recoOnMiniAOD_3
mbluj ac3ae41
use modern pointer
mbluj bbb94f8
Constraints on input values against unphysical outliers
mbluj 5f18399
usePhiAtEcalEntranceExtrapolation becomes an internal parameter of th…
mbluj 40d2d37
looser protection boundaries
mbluj 43c7f88
fix name of input param
mbluj 234e4a9
Range-based loops -- fix cherry-pick conflicts
mbluj 75cd1cf
Range-based loops -- fix cherry-pick conflicts
mbluj c169cdf
synch with remote
mbluj f3d2173
fixes: PFCands -> Cands
mbluj 48d50d0
Merge pull request #93 from mbluj/CMSSW_10_3_X_recoOnMiniAOD_3
mbluj fe9b636
Merged CMSSW_10_1_X_tau-pog_recoOnMiniAOD from repository cms-tau-pog…
mbluj 43e2c1b
Merged CMSSW_10_4_X from repository cms-sw with cms-merge-topic
mbluj 12b994c
post merge fixes
mbluj 92b023d
Merge pull request #94 from mbluj/CMSSW_10_4_X_recoOnMiniAOD
mbluj f8c7d83
Remove unnecessary catch(...) expressions
mbluj a4ca868
Merge pull request #95 from mbluj/CMSSW_10_4_X_recoOnMiniAOD
mbluj 2cd2c40
Remove incorrectly used std::move
mbluj 2c2ee20
Merge pull request #97 from mbluj/CMSSW_10_4_X_recoOnMiniAOD
mbluj 2cf812e
Reset properly transient PFTau data via ioread rules
mbluj 70aa61e
Merge pull request #104 from mbluj/CMSSW_10_4_X_recoOnMiniAOD
mbluj a4e7896
Loop using tempory var for the size
mbluj 01c61c9
Merge branch 'CMSSW_10_5_X' into CMSSW_10_1_X_tau-pog_recoOnMiniAOD
mbluj 3db017f
Merge pull request #116 from mbluj/CMSSW_10_5_X_recoOnMiniAOD
mbluj 8b8bd0a
updated inputs for tests
mbluj 26c6f8f
Merge pull request #117 from mbluj/CMSSW_10_5_X_recoOnMiniAOD
mbluj 98e35ce
Merge branch 'CMSSW_10_5_X' into CMSSW_10_5_X_recoOnMiniAOD
mbluj a52e3b6
Merge pull request #118 from mbluj/CMSSW_10_5_X_recoOnMiniAOD
mbluj d67e5db
Merge tag 'CMSSW_10_5_0_pre2' into CMSSW_10_5_X_recoOnMiniAOD
mbluj 4468872
Merge pull request #119 from mbluj/CMSSW_10_5_X_recoOnMiniAOD
mbluj b9bcea9
Merge commit 'refs/pull/22594/head' of https://github.com/cms-sw/cmss…
steggema af55ca3
Update PFTau I/O rules to circumvent issue when restoring edm::Ptr<re…
steggema f0ded3c
Merge remote-tracking branch 'official-cmssw/CMSSW_10_6_X' into CMSSW…
steggema a5228c2
Merge pull request #120 from steggema/CMSSW_10_6_0_pre2_TauRecoMiniAO…
steggema d140276
Adapt tau primary vertex finding to changes in fillDescriptions, and …
steggema 0ce14b4
Merge branch 'CMSSW_10_6_0_pre2_TauRecoMiniAOD_ResolveConflicts' of h…
steggema 692e548
Re-add quality cuts to pi0 plugin to allow it to be easily overwritte…
steggema 420ade7
Merge pull request #121 from steggema/CMSSW_10_6_0_pre2_TauRecoMiniAO…
steggema 604dcb1
Use bare and not the tau-reco charged hadron to determine distance fo…
steggema 36006f1
Rectify coding style and adhere to naming convention
steggema 005c7ef
Merge pull request #122 from steggema/CMSSW_10_6_0_pre2_TauRecoMiniAO…
steggema File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,9 +13,9 @@ | |
#include "DataFormats/TauReco/interface/BaseTau.h" | ||
#include "DataFormats/TauReco/interface/PFTauFwd.h" | ||
#include "DataFormats/TauReco/interface/PFTauTagInfo.h" | ||
#include "DataFormats/JetReco/interface/PFJetCollection.h" | ||
#include "DataFormats/ParticleFlowCandidate/interface/PFCandidate.h" | ||
#include "DataFormats/ParticleFlowCandidate/interface/PFCandidateFwd.h" | ||
#include "DataFormats/JetReco/interface/JetCollection.h" | ||
#include "DataFormats/Candidate/interface/Candidate.h" | ||
#include "DataFormats/Candidate/interface/CandidateFwd.h" | ||
#include "DataFormats/TauReco/interface/RecoTauPiZero.h" | ||
#include "DataFormats/TauReco/interface/RecoTauPiZeroFwd.h" | ||
#include "DataFormats/TauReco/interface/PFRecoTauChargedHadron.h" | ||
|
@@ -58,59 +58,72 @@ class PFTau : public BaseTau { | |
~PFTau() override {}; | ||
PFTau* clone() const override; | ||
|
||
const PFJetRef& jetRef() const; | ||
void setjetRef(const PFJetRef&); | ||
const JetBaseRef& jetRef() const; | ||
void setjetRef(const JetBaseRef&); | ||
|
||
// functions to access the PFTauTagInfoRef used by HLT | ||
const PFTauTagInfoRef& pfTauTagInfoRef() const; | ||
void setpfTauTagInfoRef(const PFTauTagInfoRef); | ||
|
||
PFRecoTauChargedHadronRef leadTauChargedHadronCandidate() const; | ||
const PFCandidatePtr& leadPFChargedHadrCand() const; | ||
const PFCandidatePtr& leadPFNeutralCand() const; | ||
const CandidatePtr& leadChargedHadrCand() const; | ||
const CandidatePtr& leadNeutralCand() const; | ||
//Can be either the charged or the neutral one | ||
const PFCandidatePtr& leadPFCand() const; | ||
const CandidatePtr& leadCand() const; | ||
|
||
void setleadPFChargedHadrCand(const PFCandidatePtr&); | ||
void setleadPFNeutralCand(const PFCandidatePtr&); | ||
void setleadPFCand(const PFCandidatePtr&); | ||
void setleadChargedHadrCand(const CandidatePtr&); | ||
void setleadNeutralCand(const CandidatePtr&); | ||
void setleadCand(const CandidatePtr&); | ||
|
||
/// Signed transverse impact parameter significance of the Track | ||
/// associated to the leading charged PFCandidate | ||
float leadPFChargedHadrCandsignedSipt() const; | ||
void setleadPFChargedHadrCandsignedSipt(const float&); | ||
|
||
/// PFCandidates in signal region | ||
const std::vector<reco::PFCandidatePtr>& signalPFCands() const; | ||
void setsignalPFCands(const std::vector<reco::PFCandidatePtr>&); | ||
/// Candidates in signal region | ||
const std::vector<reco::CandidatePtr>& signalCands() const; | ||
void setsignalCands(const std::vector<reco::CandidatePtr>&); | ||
|
||
/// Charged hadrons in signal region | ||
const std::vector<reco::PFCandidatePtr>& signalPFChargedHadrCands() const; | ||
void setsignalPFChargedHadrCands(const std::vector<reco::PFCandidatePtr>&); | ||
const std::vector<reco::CandidatePtr>& signalChargedHadrCands() const; | ||
void setsignalChargedHadrCands(const std::vector<reco::CandidatePtr>&); | ||
|
||
/// Neutral hadrons in signal region | ||
const std::vector<reco::PFCandidatePtr>& signalPFNeutrHadrCands() const; | ||
void setsignalPFNeutrHadrCands(const std::vector<reco::PFCandidatePtr>&); | ||
const std::vector<reco::CandidatePtr>& signalNeutrHadrCands() const; | ||
void setsignalNeutrHadrCands(const std::vector<reco::CandidatePtr>&); | ||
|
||
/// Gamma candidates in signal region | ||
const std::vector<reco::PFCandidatePtr>& signalPFGammaCands() const; | ||
void setsignalPFGammaCands(const std::vector<reco::PFCandidatePtr>&); | ||
const std::vector<reco::CandidatePtr>& signalGammaCands() const; | ||
void setsignalGammaCands(const std::vector<reco::CandidatePtr>&); | ||
|
||
/// PFCandidates in isolation region | ||
const std::vector<reco::PFCandidatePtr>& isolationPFCands() const; | ||
void setisolationPFCands(const std::vector<reco::PFCandidatePtr>&); | ||
/// Candidates in isolation region | ||
const std::vector<reco::CandidatePtr>& isolationCands() const; | ||
void setisolationCands(const std::vector<reco::CandidatePtr>&); | ||
|
||
/// Charged candidates in isolation region | ||
const std::vector<reco::PFCandidatePtr>& isolationPFChargedHadrCands() const; | ||
void setisolationPFChargedHadrCands(const std::vector<reco::PFCandidatePtr>&); | ||
const std::vector<reco::CandidatePtr>& isolationChargedHadrCands() const; | ||
void setisolationChargedHadrCands(const std::vector<reco::CandidatePtr>&); | ||
|
||
//// Neutral hadrons in isolation region | ||
const std::vector<reco::PFCandidatePtr>& isolationPFNeutrHadrCands() const; | ||
void setisolationPFNeutrHadrCands(const std::vector<reco::PFCandidatePtr>&); | ||
const std::vector<reco::CandidatePtr>& isolationNeutrHadrCands() const; | ||
void setisolationNeutrHadrCands(const std::vector<reco::CandidatePtr>&); | ||
|
||
/// Gamma candidates in isolation region | ||
const std::vector<reco::CandidatePtr>& isolationGammaCands() const; | ||
void setisolationGammaCands(const std::vector<reco::CandidatePtr>&); | ||
|
||
/// Getters for different PFCandidates for PFTaus made from PFCandidates | ||
const PFCandidatePtr leadPFChargedHadrCand() const; | ||
const PFCandidatePtr leadPFNeutralCand() const; | ||
const PFCandidatePtr leadPFCand() const; | ||
const std::vector<reco::PFCandidatePtr>& signalPFCands() const; | ||
const std::vector<reco::PFCandidatePtr>& signalPFChargedHadrCands() const; | ||
const std::vector<reco::PFCandidatePtr>& signalPFNeutrHadrCands() const; | ||
const std::vector<reco::PFCandidatePtr>& signalPFGammaCands() const; | ||
const std::vector<reco::PFCandidatePtr>& isolationPFCands() const; | ||
const std::vector<reco::PFCandidatePtr>& isolationPFChargedHadrCands() const; | ||
const std::vector<reco::PFCandidatePtr>& isolationPFNeutrHadrCands() const; | ||
const std::vector<reco::PFCandidatePtr>& isolationPFGammaCands() const; | ||
void setisolationPFGammaCands(const std::vector<reco::PFCandidatePtr>&); | ||
|
||
/// Sum of charged hadron candidate PT in isolation cone; returns NaN | ||
/// if isolation region is undefined. | ||
|
@@ -244,24 +257,39 @@ class PFTau : public BaseTau { | |
|
||
float signalConeSize_; | ||
|
||
reco::PFJetRef jetRef_; | ||
reco::JetBaseRef jetRef_; | ||
PFTauTagInfoRef PFTauTagInfoRef_; | ||
reco::PFCandidatePtr leadPFChargedHadrCand_; | ||
reco::PFCandidatePtr leadPFNeutralCand_; | ||
reco::PFCandidatePtr leadPFCand_; | ||
reco::CandidatePtr leadChargedHadrCand_; | ||
reco::CandidatePtr leadNeutralCand_; | ||
reco::CandidatePtr leadCand_; | ||
reco::TrackRef electronPreIDTrack_; | ||
|
||
// Signal candidates | ||
std::vector<reco::PFCandidatePtr> selectedSignalPFCands_; | ||
std::vector<reco::PFCandidatePtr> selectedSignalPFChargedHadrCands_; | ||
std::vector<reco::PFCandidatePtr> selectedSignalPFNeutrHadrCands_; | ||
std::vector<reco::PFCandidatePtr> selectedSignalPFGammaCands_; | ||
std::vector<reco::CandidatePtr> selectedSignalCands_; | ||
std::vector<reco::CandidatePtr> selectedSignalChargedHadrCands_; | ||
std::vector<reco::CandidatePtr> selectedSignalNeutrHadrCands_; | ||
std::vector<reco::CandidatePtr> selectedSignalGammaCands_; | ||
|
||
// Isolation candidates | ||
std::vector<reco::PFCandidatePtr> selectedIsolationPFCands_; | ||
std::vector<reco::PFCandidatePtr> selectedIsolationPFChargedHadrCands_; | ||
std::vector<reco::PFCandidatePtr> selectedIsolationPFNeutrHadrCands_; | ||
std::vector<reco::PFCandidatePtr> selectedIsolationPFGammaCands_; | ||
std::vector<reco::CandidatePtr> selectedIsolationCands_; | ||
std::vector<reco::CandidatePtr> selectedIsolationChargedHadrCands_; | ||
std::vector<reco::CandidatePtr> selectedIsolationNeutrHadrCands_; | ||
std::vector<reco::CandidatePtr> selectedIsolationGammaCands_; | ||
|
||
// Transient caches for PFCandidate-based accessors | ||
edm::AtomicPtrCache<reco::PFCandidatePtr> leadPFChargedHadrCand_; | ||
edm::AtomicPtrCache<reco::PFCandidatePtr> leadPFNeutralCand_; | ||
edm::AtomicPtrCache<reco::PFCandidatePtr> leadPFCand_; | ||
|
||
edm::AtomicPtrCache<std::vector<reco::PFCandidatePtr> > selectedTransientSignalPFCands_; | ||
edm::AtomicPtrCache<std::vector<reco::PFCandidatePtr> > selectedTransientSignalPFChargedHadrCands_; | ||
edm::AtomicPtrCache<std::vector<reco::PFCandidatePtr> > selectedTransientSignalPFNeutrHadrCands_; | ||
edm::AtomicPtrCache<std::vector<reco::PFCandidatePtr> > selectedTransientSignalPFGammaCands_; | ||
|
||
edm::AtomicPtrCache<std::vector<reco::PFCandidatePtr> > selectedTransientIsolationPFCands_; | ||
edm::AtomicPtrCache<std::vector<reco::PFCandidatePtr> > selectedTransientIsolationPFChargedHadrCands_; | ||
edm::AtomicPtrCache<std::vector<reco::PFCandidatePtr> > selectedTransientIsolationPFNeutrHadrCands_; | ||
edm::AtomicPtrCache<std::vector<reco::PFCandidatePtr> > selectedTransientIsolationPFGammaCands_; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do you have evidence that caching these results is actually beneficial? You could just return a copy of the vector from the function if it is called. |
||
|
||
RecoTauPiZeroRefVector signalPiZeroCandidatesRefs_; | ||
RecoTauPiZeroRefVector isolationPiZeroCandidatesRefs_; | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why bother making these three be member data? Why not just do the conversion when the function requesting them is called?