-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update of the HLT menu (101X) #22561
Conversation
The code-checks are being triggered in jenkins. |
please test |
hold |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22561/3886 |
Pull request has been put on hold by @silviodonato |
The tests are being triggered in jenkins. |
A new Pull Request was created by @silviodonato (Silvio Donato) for master. It involves the following packages: Configuration/HLT @Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
-1 Tested at: 832c9ab You can see the results of the tests here: I found follow errors while testing this PR Failed tests: RelVals
When I ran the RelVals I found an error in the following worklfows: runTheMatrix-results/10824.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+ALCAFull_2018+HARVESTFull_2018/step2_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+ALCAFull_2018+HARVESTFull_2018.log |
Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped) |
Of course it is failing because of the new L1 menu: We'll contact AlCa to prepare a GT with the new L1 menu |
We should be sure this is the "final" L1T menu. |
please test |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
Comparison is ready Comparison Summary:
|
+1 |
Update of the HLT menu to /dev/CMSSW_10_0_0/HLT/V140
based on L1Menu_Collisions2018_v0_0_1.
(base release: CMSSW_10_1_0_pre3)
100X: #22562