Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update of the HLT menu (101X) #22561

Merged
merged 3 commits into from
Mar 23, 2018
Merged

Conversation

silviodonato
Copy link
Contributor

@silviodonato silviodonato commented Mar 9, 2018

Update of the HLT menu to /dev/CMSSW_10_0_0/HLT/V140
based on L1Menu_Collisions2018_v0_0_1.

(base release: CMSSW_10_1_0_pre3)

100X: #22562

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2018

The code-checks are being triggered in jenkins.

@silviodonato
Copy link
Contributor Author

please test

@silviodonato
Copy link
Contributor Author

hold

@cmsbuild cmsbuild added the hold label Mar 9, 2018
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2018

Pull request has been put on hold by @silviodonato
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26749/console Started: 2018/03/09 22:41

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2018

A new Pull Request was created by @silviodonato (Silvio Donato) for master.

It involves the following packages:

Configuration/HLT
HLTrigger/Configuration

@Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @geoff-smith, @jalimena, @Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

-1

Tested at: 832c9ab

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22561/26749/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

When I ran the RelVals I found an error in the following worklfows:
10824.0 step2

runTheMatrix-results/10824.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+ALCAFull_2018+HARVESTFull_2018/step2_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+ALCAFull_2018+HARVESTFull_2018.log

@cmsbuild
Copy link
Contributor

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

@Martin-Grunewald
Copy link
Contributor

We should be sure this is the "final" L1T menu.

@silviodonato
Copy link
Contributor Author

please test

@silviodonato
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 22, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27044/console Started: 2018/03/22 16:37

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@silviodonato
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22561/27044/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 29
  • DQMHistoTests: Total histograms compared: 2496654
  • DQMHistoTests: Total failures: 1272
  • DQMHistoTests: Total nulls: 11
  • DQMHistoTests: Total successes: 2495195
  • DQMHistoTests: Total skipped: 176
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.579999999856 KiB( 22 files compared)
  • Checked 118 log files, 9 edm output root files, 29 DQM output files

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 6e8ea57 into cms-sw:master Mar 23, 2018
@Martin-Grunewald Martin-Grunewald deleted the HLTmenu101X branch November 17, 2018 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants