Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary updating of bx mask arrays #22519

Merged

Conversation

apana
Copy link
Contributor

@apana apana commented Mar 8, 2018

Remove code that updates the bx mask arrays for every event. Updates only need to be made at run transitions.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2018

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2018

A new Pull Request was created by @apana (Leonard Apanasvich) for master.

It involves the following packages:

L1Trigger/L1TGlobal

@nsmith-, @rekovic, @cmsbuild, @thomreis can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @kreczko this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@slava77
Copy link
Contributor

slava77 commented Mar 8, 2018

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26684/console Started: 2018/03/08 06:33

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22519/26684/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 29
  • DQMHistoTests: Total histograms compared: 2480211
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2480034
  • DQMHistoTests: Total skipped: 176
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.26000000019 KiB( 23 files compared)
  • Checked 118 log files, 9 edm output root files, 29 DQM output files

@fabiocos
Copy link
Contributor

fabiocos commented Mar 9, 2018

@nsmith- @rekovic @thomreis could you please have a look? This is needed for 94X (where there is also the corresponding back-port)

@slava77
Copy link
Contributor

slava77 commented Mar 12, 2018

@nsmith- @rekovic @thomreis
l1 signature is still needed here
Please check and sign or suggest changes.
Thank you.

@rekovic
Copy link
Contributor

rekovic commented Mar 13, 2018

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@rekovic
Copy link
Contributor

rekovic commented Mar 13, 2018

@slava77
Copy link
Contributor

slava77 commented Mar 14, 2018

@fabiocos
please clarify the situation with this PR.
FWIW, it is technical and should be OK for 10_1_X.
Also, it should resolve potential issues with reading prescales that were so far seen only in 80XLegacy but apparently can happen elsewhere.

@fabiocos
Copy link
Contributor

@slava77 this is effectively a fix to my mind, so I see no reasons not to merge it.

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 17419b8 into cms-sw:master Mar 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants