-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New psets for Phase2PixelNtuple #22464
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22464/3746 |
A new Pull Request was created by @emiglior (Ernesto Migliore) for master. It involves the following packages: SLHCUpgradeSimulations/Geometry @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@@ -0,0 +1,66 @@ | |||
This is a short description of the content of the ntuple produced by Phase2PixelNtuple.cc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please actually use markdown in this file so it is readable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @emiglior , I guess this comment should be adressed , thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kpedro88 sorry for the slow reaction... any suggestion, reference, cmssw example for md style is welcome
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22464/3920 |
Pull request #22464 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please check and sign again. |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
Comparison is ready Comparison Summary:
|
+1 |
This is an update of PR #22204. Two psets are provided:
1/ phase2_reco_pixelntuple_cfg.py: ntuples from DIGI to perform RECO level studies, e.g. CPE errors calibration)
2/ phase2_digi_reco_pixelntuple_cfg.py ntuples from SIM to produce "stimuli" for RD53 studies (InnerTracker PROC deisgn)