SiPixel Quality PCL for cmssw 10_1_X #22455
Conversation
|
The code-checks are being triggered in jenkins. |
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22455/3729 Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22455/3729/git-diff.patch You can run |
cmsbuild
added
code-checks-rejected
code-checks-pending
and removed
code-checks-pending
code-checks-rejected
labels
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22455/3734 |
|
A new Pull Request was created by @tocheng (Tongguang) for master. It involves the following packages: CalibTracker/SiPixelQuality The following packages do not have a category, yet: CalibTracker/SiPixelQuality @ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @lpernie, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@cmsbuild A PR is made to update the category map at cms-sw/cms-bot#957. |
|
please test |
|
The tests are being triggered in jenkins. |
|
-1 Tested at: 9c09636 You can see the results of the tests here: I found follow errors while testing this PR Failed tests: RelVals
When I ran the RelVals I found an error in the following worklfows: runTheMatrix-results/4.22_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC/step2_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC.log4.53 step3 runTheMatrix-results/4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODR1reHLT+HARVESTDR1reHLT/step3_RunPhoton2012B+RunPhoton2012B+HLTD+RECODR1reHLT+HARVESTDR1reHLT.log7.3 step3 runTheMatrix-results/7.3_CosmicsSPLoose_UP17+CosmicsSPLoose_UP17+DIGICOS_UP17+RECOCOS_UP17+ALCACOS_UP17+HARVESTCOS_UP17/step3_CosmicsSPLoose_UP17+CosmicsSPLoose_UP17+DIGICOS_UP17+RECOCOS_UP17+ALCACOS_UP17+HARVESTCOS_UP17.log8.0 step4 runTheMatrix-results/8.0_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS/step4_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS.log136.731 step3 runTheMatrix-results/136.731_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2/step3_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2.log136.788 step3 runTheMatrix-results/136.788_RunSinglePh2017B+RunSinglePh2017B+HLTDR2_2017+RECODR2_2017reHLT_skimSinglePh_Prompt+HARVEST2017/step3_RunSinglePh2017B+RunSinglePh2017B+HLTDR2_2017+RECODR2_2017reHLT_skimSinglePh_Prompt+HARVEST2017.log140.53 step2 runTheMatrix-results/140.53_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI/step2_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI.log25.0 step3 runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT/step3_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT.log1000.0 step2 runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step2_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log1001.0 step2 runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4+ALCAHARVD5/step2_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4+ALCAHARVD5.log10042.0 step4 runTheMatrix-results/10042.0_ZMM_13+ZMM_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017/step4_ZMM_13+ZMM_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017.log10024.0 step4 runTheMatrix-results/10024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017/step4_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017.log10824.0 step4 runTheMatrix-results/10824.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+ALCAFull_2018+HARVESTFull_2018/step4_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+ALCAFull_2018+HARVESTFull_2018.log11624.0 step4 runTheMatrix-results/11624.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2019_GenSimFull+DigiFull_2019+RecoFull_2019+ALCAFull_2019+HARVESTFull_2019/step4_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2019_GenSimFull+DigiFull_2019+RecoFull_2019+ALCAFull_2019+HARVESTFull_2019.log |
|
Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped) |
|
+1 |
|
please test workflow 1001.2,1040,1040.1 |
cmsbuild
added
comparison-pending
tests-pending
and removed
comparison-available
tests-approved
labels
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready The workflows 1001.0 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
|
+operations |
|
+1 |
cmsbuild
added
fully-signed
operations-approved
orp-approved
and removed
operations-pending
orp-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
Hello,
this PR is meant to embed the SiPixel quality offline analysis into PCL workflow.
The idea is to monitor the Pixel ROC quality based on its DIGI occupancy, and tag the ROC bad if its DIGI occupancy is extremely small compared with average per ROC DIGI occupancy.
Furthermore, the sources of Pixel bad components can be categorised as:
permanent bad components which is the one in current DB;
stuck TBM, can be tracked down using "FED error 25" packed in RAW data (permanent bad components also gives "FED error 25". One may want to subtract the permanent bad components from "FED error 25" list to monitor on the stuck TBM);
other sources, could be a ROC SEU, or some other reasons.
The current PCL workflow in the PR will analyse the ZeroBias triggered events in Express,
produce payload for each source of bad components, and produce one payload for prompt reconstruction which includes permanent bad components and other sources; stuck TBM is handled by PixelFEDCollection consumed by tracking event-by-event, hence not included in the tag (for prompt reco).
The information related to the SiPixel offline analysis can be found at https://indico.cern.ch/event/688098/contributions/2841553/attachments/1580192/2496819/20180109_PixelOffline_BadComponentAutomatization.pdf. (There was something wrong with the validation plots in the slides because some of the scripts used in the validation are not updated to Phase-I detector geometry.)
The PCL implementation was presented at Pixel Offline DPG meeting at
https://indico.cern.ch/event/688859/contributions/2913583/attachments/1607768/2551726/PixelQualityPCL_Feb27th_2018_PixelOffline.pdf.
The workflow is validated as the following:
a tag is produced using a single run in 2017.
MC samples is generated using ideal condition and unpacked/reconstructed using the SiPixelQuality produced using single run in 2017 (useSiPixelQuality=true for RAW-to-DIGI). Cluster occupancy plots are produced (using SiPixel offline tool) and compared with the same plots in the same run on DQM offline GUI.
More details about the PCL implementation and validation plots will be presented at the Pixel Offline group meeting on March 6th.
https://indico.cern.ch/event/688839/#25-bad-component-detection-at
On the relval workflow, the new ALCARECO and ALCAPROMPT are added into 1001 and a new workflow 1001.2 as Run-II version of 1001 is included. Workflow 1040.0 and 1040.1 are the workflow for Tier-0 production of the payload for SiPixelQuality alone. The validation using the tag produced I by workflow 1040.1 at https://www.dropbox.com/s/lxut72xnvb2nbb7/PixelQualityPCL_Mar16th_2018_Validation.pptx?dl=0.
The destination tags for the tags produced in the outputDB can be found at slide 8
https://indico.cern.ch/event/688839/contributions/2923209/attachments/1612420/2560916/20180307_TrackerDPG_PixelBadComponentMonitoring.pdf.