[muon id] added a few more working points #22420

drkovalskyi · 2018-03-02T14:40:52Z

For details see:

https://its.cern.ch/jira/browse/CMSMUONS-95
https://its.cern.ch/jira/browse/CMSMUONS-97
MultiIso was requested by SUSY PAG

cmsbuild · 2018-03-02T14:41:10Z

The code-checks are being triggered in jenkins.

cmsbuild · 2018-03-02T14:43:35Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22420/3673

cmsbuild · 2018-03-02T14:43:54Z

A new Pull Request was created by @drkovalskyi for master.

It involves the following packages:

DataFormats/MuonReco
PhysicsTools/PatAlgos

@perrotta, @monttj, @cmsbuild, @slava77, @gpetruc, @arizzi can you please review it and eventually sign? Thanks.
@TaiSakuma, @gouskos, @abbiendi, @rappoccio, @seemasharmafnal, @mmarionncern, @imarches, @ahinzmann, @acaudron, @jhgoh, @jdolen, @JyothsnaKomaragiri, @ferencek, @trocino, @rovere, @jdamgov, @nhanvtran, @gkasieczka, @schoef, @amagitte, @HuguesBrun, @battibass, @calderona, @mverzett, @bachtis, @gpetruc, @mariadalfonso, @pvmulder, @folguera this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

perrotta · 2018-03-02T15:11:21Z

please test

cmsbuild · 2018-03-02T15:11:39Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26449/console Started: 2018/03/02 16:13

perrotta · 2018-03-02T15:12:43Z

@drkovalskyi : please allow somehow "muon" or "muon ID" in the title, so that the topic of the PR can be easily understood from it

cmsbuild · 2018-03-02T18:13:51Z

+1
Tested at: 09a915b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22420/26449/summary.html

cmsbuild · 2018-03-02T18:13:53Z

Comparison job queued.

cmsbuild · 2018-03-02T19:11:47Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22420/26449/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 38 differences found in the comparisons
DQMHistoTests: Total files compared: 29
DQMHistoTests: Total histograms compared: 2479021
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2478844
DQMHistoTests: Total skipped: 176
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 1.33000000003 KiB( 23 files compared)
Checked 118 log files, 9 edm output root files, 29 DQM output files

perrotta · 2018-03-11T15:19:42Z

DataFormats/MuonReco/src/MuonSelectors.cc

@@ -1004,6 +1022,7 @@ void muon::setCutBasedSelectorFlags(reco::Muon& muon,
  if (dbCorectedRelIso<0.20)    selectors |= reco::Muon::PFIsoMedium;
  if (dbCorectedRelIso<0.15)    selectors |= reco::Muon::PFIsoTight;
  if (dbCorectedRelIso<0.10)    selectors |= reco::Muon::PFIsoVeryTight;
+  if (dbCorectedRelIso<0.05)    selectors |= reco::Muon::PFIsoVeryVeryTight;


The point is ultra-minor... However, I let you decide if you want to fix the spelling of the name of this variable ("Corected" -> "Corrected") or not. Just either fix it or let us know that you don't plan doing it.
(I have no other issues with this PR)

perrotta · 2018-03-12T09:22:27Z

@drkovalskyi : by the way, do you plan to backport this PR to 94X for the re-miniAOD?

perrotta · 2018-03-13T06:08:24Z

please test
(just to re-create the jenkins outputs, which have disappeared in the meanwhile)

cmsbuild · 2018-03-14T09:09:41Z

The code-checks are being triggered in jenkins.

cmsbuild · 2018-03-14T09:12:17Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22420/3940

cmsbuild · 2018-03-14T09:12:36Z

Pull request #22420 was updated. @perrotta, @monttj, @cmsbuild, @slava77, @gpetruc, @arizzi can you please check and sign again.

perrotta · 2018-03-14T09:30:30Z

please test

cmsbuild · 2018-03-14T09:30:45Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26838/console Started: 2018/03/14 10:32

cmsbuild · 2018-03-14T11:26:45Z

+1
Tested at: 5c80988
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22420/26838/summary.html

cmsbuild · 2018-03-14T11:26:49Z

Comparison job queued.

cmsbuild · 2018-03-14T13:04:29Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22420/26838/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 37 differences found in the comparisons
DQMHistoTests: Total files compared: 29
DQMHistoTests: Total histograms compared: 2477528
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2477351
DQMHistoTests: Total skipped: 176
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 1.08999999997 KiB( 23 files compared)
Checked 118 log files, 9 edm output root files, 29 DQM output files

perrotta · 2018-03-14T14:25:14Z

+1

Four extra bits added for the additional selectors in reco and miniAOD outputs
Changes in jenkins outputs just reflect it

fabiocos · 2018-03-21T17:44:13Z

+1

fabiocos · 2018-03-21T17:44:39Z

merge

added a few more working points

09a915b

cmsbuild added this to the CMSSW_10_1_X milestone Mar 2, 2018

cmsbuild added analysis-pending code-checks-pending comparison-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Mar 2, 2018

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 2, 2018

cmsbuild added tests-started and removed tests-pending labels Mar 2, 2018

cmsbuild added tests-approved and removed tests-started labels Mar 2, 2018

cmsbuild added comparison-available and removed comparison-pending labels Mar 2, 2018

drkovalskyi changed the title ~~added a few more working points~~ [muon id] added a few more working points Mar 5, 2018

perrotta reviewed Mar 11, 2018

View reviewed changes

cmsbuild added code-checks-pending comparison-pending tests-pending and removed tests-approved labels Mar 14, 2018

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 14, 2018

cmsbuild added tests-started and removed tests-pending labels Mar 14, 2018

cmsbuild added tests-approved and removed tests-started labels Mar 14, 2018

cmsbuild added comparison-available and removed comparison-pending labels Mar 14, 2018

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Mar 14, 2018

arizzi mentioned this pull request Mar 15, 2018

new muon IDs cms-nanoAOD/cmssw#106

Closed

cmsbuild added orp-approved and removed orp-pending labels Mar 21, 2018

cmsbuild merged commit 6e763a8 into cms-sw:master Mar 21, 2018

perrotta mentioned this pull request Mar 7, 2019

Fixing MultiIso in muon Selector: Removing the double declaration of the variable "miniIsoValue " #26093

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[muon id] added a few more working points #22420

[muon id] added a few more working points #22420

drkovalskyi commented Mar 2, 2018

cmsbuild commented Mar 2, 2018

cmsbuild commented Mar 2, 2018

cmsbuild commented Mar 2, 2018

perrotta commented Mar 2, 2018

cmsbuild commented Mar 2, 2018 •

edited

Loading

perrotta commented Mar 2, 2018

cmsbuild commented Mar 2, 2018

cmsbuild commented Mar 2, 2018

cmsbuild commented Mar 2, 2018

perrotta Mar 11, 2018

perrotta commented Mar 12, 2018

perrotta commented Mar 13, 2018

cmsbuild commented Mar 14, 2018

cmsbuild commented Mar 14, 2018

cmsbuild commented Mar 14, 2018

perrotta commented Mar 14, 2018

cmsbuild commented Mar 14, 2018 •

edited

Loading

cmsbuild commented Mar 14, 2018

cmsbuild commented Mar 14, 2018

cmsbuild commented Mar 14, 2018

perrotta commented Mar 14, 2018

fabiocos commented Mar 21, 2018

fabiocos commented Mar 21, 2018

[muon id] added a few more working points #22420

[muon id] added a few more working points #22420

Conversation

drkovalskyi commented Mar 2, 2018

cmsbuild commented Mar 2, 2018

cmsbuild commented Mar 2, 2018

cmsbuild commented Mar 2, 2018

perrotta commented Mar 2, 2018

cmsbuild commented Mar 2, 2018 • edited Loading

perrotta commented Mar 2, 2018

cmsbuild commented Mar 2, 2018

cmsbuild commented Mar 2, 2018

cmsbuild commented Mar 2, 2018

perrotta Mar 11, 2018

Choose a reason for hiding this comment

perrotta commented Mar 12, 2018

perrotta commented Mar 13, 2018

cmsbuild commented Mar 14, 2018

cmsbuild commented Mar 14, 2018

cmsbuild commented Mar 14, 2018

perrotta commented Mar 14, 2018

cmsbuild commented Mar 14, 2018 • edited Loading

cmsbuild commented Mar 14, 2018

cmsbuild commented Mar 14, 2018

cmsbuild commented Mar 14, 2018

perrotta commented Mar 14, 2018

fabiocos commented Mar 21, 2018

fabiocos commented Mar 21, 2018

cmsbuild commented Mar 2, 2018 •

edited

Loading

cmsbuild commented Mar 14, 2018 •

edited

Loading