Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.0.X] Add few more CondFormats to Module_2XML to speed up payload dump #22144

Merged

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Feb 7, 2018

backport of #22143

Greetings,
this is a follow-up PR to #22054, adding more support for fast payload dump for other CondFormats that are either not in MC or live HLT Global Tags (e.g. Express or Prompt Reco Global Tag) or are not (yet) in any Global Tag, but still used.
The complete list is taken from https://github.com/cms-sw/cmssw/blob/master/CondCore/Utilities/src/CondDBImport.cc#L41-L322

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2018

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_10_0_X.

It involves the following packages:

CondCore/Utilities

@ggovi, @cmsbuild can you please review it and eventually sign? Thanks.
@ghellwig, @mmusich this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@ggovi
Copy link
Contributor

ggovi commented Feb 7, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25950/console Started: 2018/02/07 20:18

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22144/25950/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-22144/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017+HARVESTNANOAODMC2017

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 27
  • DQMHistoTests: Total histograms compared: 2469477
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2469307
  • DQMHistoTests: Total skipped: 169
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.560000000078 KiB( 22 files compared)
  • Checked 111 log files, 9 edm output root files, 27 DQM output files

@ggovi
Copy link
Contributor

ggovi commented Feb 8, 2018

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 8, 2018

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit a416752 into cms-sw:CMSSW_10_0_X Feb 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants