-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Report CPU time spent in child processes of ExternalLHEProducer [9_4] #22101
Conversation
The CPU time is not accumulated per stream and the place where we want addToCPUTime to be called is during global begin run.
Report the CPU time spent in child processes launched.
backport #22100 |
A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_9_4_X. It involves the following packages: FWCore/Services @cmsbuild, @smuzaffar, @efeyazgan, @Dr15Jones, @perrozzi can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
I guess this is needed in 93x (used for GEN-SIM) and not 94x (used for DIGI-RECO) right? |
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
+1 |
sorry to ask again: is this really needed in 94x? |
@perrozzi This is not strongly needed for 94X, as no massive GEN production is expected here to my knowledge, but it is in production in master since quite sometime, and it doesn't harm either |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
When accounting for CPU time used by a cmsRun job, we need to also include the CPU time of the child processes launched by ExternalLHEProducer.