Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dire integration (for internal partons) #22098

Merged
merged 1 commit into from
Feb 13, 2018
Merged

Dire integration (for internal partons) #22098

merged 1 commit into from
Feb 13, 2018

Conversation

mseidel42
Copy link
Contributor

@cmsbuild cmsbuild added this to the CMSSW_10_1_X milestone Feb 2, 2018
@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2018

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2018

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22098/3227

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2018

A new Pull Request was created by @intrepid42 (Markus Seidel) for master.

It involves the following packages:

GeneratorInterface/Pythia8Interface

@cmsbuild, @efeyazgan, @perrozzi can you please review it and eventually sign? Thanks.
@alberto-sanchez, @agrohsje, @mkirsano this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@perrozzi
Copy link

perrozzi commented Feb 3, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2018 •
edited
Loading

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25888/console Started: 2018/02/03 08:01

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2018

-1

Tested at: 6ad6c0a

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22098/25888/summary.html

I found follow errors while testing this PR

Failed tests: Build ClangBuild

  • Build:

I found an error when building:

>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_1_X_2018-02-02-2300/src/RecoParticleFlow/PFSimProducer/plugins/modulesSim.cc 
Entering library rule at FastSimulation/ParticleDecay
>> Compiling  /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_1_X_2018-02-02-2300/src/GeneratorInterface/Pythia8Interface/src/Py8GunBase.cc 
In file included from /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_1_X_2018-02-02-2300/src/GeneratorInterface/Pythia8Interface/interface/Py8GunBase.h:23:0,
                 from /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_1_X_2018-02-02-2300/src/GeneratorInterface/Pythia8Interface/src/Py8GunBase.cc:1:
/build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_1_X_2018-02-02-2300/src/GeneratorInterface/Pythia8Interface/interface/Py8InterfaceBase.h:15:23: fatal error: Dire/Dire.h: No such file or directory
 #include 
                       ^
compilation terminated.
>> Compiling  /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_1_X_2018-02-02-2300/src/GeneratorInterface/Pythia8Interface/src/ResonanceDecayFilterHook.cc 
gmake: *** [tmp/slc6_amd64_gcc630/src/GeneratorInterface/Pythia8Interface/src/GeneratorInterfacePythia8Interface/Py8GunBase.o] Error 1
  • Clang:

I found a compilation error while trying to compile with clang:
I used this command:
scram b vclean && scram build -k -j 16 USER_CXXFLAGS='-fsyntax-only' COMPILER='llvm compile'

>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_1_X_2018-02-02-2300/src/GeneratorInterface/Pythia8Interface/plugins/PowhegResHook.cc 
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_1_X_2018-02-02-2300/src/GeneratorInterface/Pythia8Interface/plugins/JetMatchingHook.cc 
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_1_X_2018-02-02-2300/src/GeneratorInterface/Pythia8Interface/plugins/EmissionVetoHook1.cc 
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_1_X_2018-02-02-2300/src/GeneratorInterface/Pythia8Interface/plugins/LHAupLesHouches.cc 
In file included from /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_1_X_2018-02-02-2300/src/GeneratorInterface/Pythia8Interface/src/Py8InterfaceBase.cc:1:
/build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_1_X_2018-02-02-2300/src/GeneratorInterface/Pythia8Interface/interface/Py8InterfaceBase.h:15:10: fatal error: 'Dire/Dire.h' file not found
#include 
         ^~~~~~~~~~~~~
1 error generated.
In file included from /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_1_X_2018-02-02-2300/src/GeneratorInterface/Pythia8Interface/src/Py8GunBase.cc:1:
In file included from /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_1_X_2018-02-02-2300/src/GeneratorInterface/Pythia8Interface/interface/Py8GunBase.h:23:

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2018

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

@perrozzi
Copy link

perrozzi commented Feb 3, 2018

please test with cms-sw/cmsdist#3711

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2018 •
edited
Loading

The tests are being triggered in jenkins.
Using externals from cms-sw/cmsdist#3711
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25889/console

@cmsbuild cmsbuild mentioned this pull request Feb 3, 2018
Merged
@mseidel42
Copy link
Contributor Author

I forgot to put dire in the cmssw-tool-conf.spec, fixed now!

@perrozzi
Copy link

perrozzi commented Feb 3, 2018

please test with cms-sw/cmsdist#3711

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2018 •
edited
Loading

The tests are being triggered in jenkins.
Using externals from cms-sw/cmsdist#3711
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25891/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2018

+1
Tested at: 6ad6c0a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22098/25891/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22098/25891/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-22098/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2465763
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2465593
  • DQMHistoTests: Total skipped: 169
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.79000000011 KiB( 22 files compared)
  • Checked 110 log files, 9 edm output root files, 26 DQM output files

@perrozzi
Copy link

perrozzi commented Feb 4, 2018

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2018

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

@perrozzi do you have some validation material? Is Dire supposed to be part of a pythia8 standard workflow?

@perrozzi
Copy link

@intrepid42 should comment

@mseidel42
Copy link
Contributor Author

I verified that the Dire shower runs and test events (e+e-) are produced, including shower weights

--> I have a small output file with validation events but no high-stats comparison against other generators.

@fabiocos
Copy link
Contributor

@intrepid42 sorry, is the example in this PR, where I see that Dire is used, running and producing events for processing correctly out of the box? I mean a technical test, physics checks will come later...

@mseidel42
Copy link
Contributor Author

Yes, I added the test config file GeneratorInterface/Pythia8Interface/test/pythia8ex14_cfg.py

@mseidel42
Copy link
Contributor Author

Hi, I hope somebody can help with this: I want to generate pp>ttbar events but the code hangs in pythia::next().

  • It works when I turn off initial-state shower
  • It works when I set '-s 4000000' and turn off additional analysis modules that I would like to run
  • It works without problems and 10x faster with a standalone Pythia+Dire installation on my desktop PC

I am not an expert on shared libraries and thread safety etc...
Do you have any idea on that?

@smuzaffar smuzaffar merged commit 2634b66 into cms-sw:master Feb 13, 2018
@mseidel42 mseidel42 mentioned this pull request Feb 14, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code-checks-approved comparison-available fully-signed generators-approved orp-pending requires-external tests-approved
Projects
None yet
Milestone
CMSSW_10_1_X
Development

Successfully merging this pull request may close these issues.
5 participants
@mseidel42 @cmsbuild @perrozzi @fabiocos @smuzaffar