Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instrument cmssw for nvidia nvprof/nvvm (10.0.x) #21947

Merged

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Jan 24, 2018

Instrument cmssw for nvprof/nvvm

  • implement a Service to provide CMSSW-aware annotations to nvprof/nvvm
  • highlight selected modules and delayed modules
  • update for CMSSW 10.0.x

@fwyzard
Copy link
Contributor Author

fwyzard commented Jan 24, 2018

backport #21946

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 24, 2018

A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_10_0_X.

It involves the following packages:

FWCore/CUDAServices

The following packages do not have a category, yet:

FWCore/CUDAServices
Please create a PR for https://github.com/cms-sw/cms-bot/blob/master/categories_map.py to assign category

@cmsbuild can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @wddgit this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@fwyzard fwyzard force-pushed the instrument_CMSSW_for_Nvidia_nvprof_100x branch from c5258f7 to ba6aee5 Compare January 24, 2018 17:59
@cmsbuild
Copy link
Contributor

Pull request #21947 was updated. @cmsbuild can you please check and sign again.

@fwyzard fwyzard force-pushed the instrument_CMSSW_for_Nvidia_nvprof_100x branch from ba6aee5 to 8fd6dda Compare January 25, 2018 09:12
@cmsbuild
Copy link
Contributor

Pull request #21947 was updated. @cmsbuild can you please check and sign again.

@fwyzard
Copy link
Contributor Author

fwyzard commented Jan 25, 2018

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 25, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25616/console Started: 2018/01/25 10:16

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21947/25616/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-21947/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2467599
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2467429
  • DQMHistoTests: Total skipped: 169
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.00000000006 KiB( 22 files compared)
  • Checked 110 log files, 9 edm output root files, 26 DQM output files

@fabiocos
Copy link
Contributor

fabiocos commented Feb 6, 2018

@fwyzard is this really needed in 10_0_X as well, or it is enough to integrate it in the development release?

@fwyzard
Copy link
Contributor Author

fwyzard commented Feb 6, 2018

I would rather have it in10.0.x as well, since this is the base release we are currently using for the GPU development, and because it can be used for profiling non-GPU modules as well.

@fabiocos
Copy link
Contributor

+1

@fabiocos
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 244f740 into cms-sw:CMSSW_10_0_X Feb 12, 2018
@fwyzard fwyzard deleted the instrument_CMSSW_for_Nvidia_nvprof_100x branch February 16, 2018 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants