Adding PFClusterIsolation to reco Egamma objects #21811

Sam-Harper · 2018-01-08T14:45:44Z

PFCluster isolation is used in the HLT and is becoming more popular in E/gamma as useful isolation.

It is already stored in AOD via value maps and is embedded into pat::Electrons and pat::Photons. This change puts it directly in the reco::GsfElectron and reco::Photon for ease of use. It should be CPU and diskspace neutral (if anything, slightly less diskspace as it replaces valuemaps) as its simply changing where the isolation value is stored.

The value maps are now added to the electron,photon during the finalisation step in the same way as PFIsolations are. As such the event content is modified to drop these ValueMaps as they are unnecessary (and keyed to the tmp versions of the electrons/photons). The reducedEgamma and pat configs were updated to not to store the PF cluster isolation. However they still have a capability to read in value maps and set the PFCluster isolation. This is done incase we wish to use this release to re-miniAOD 8X or 9X samples where a customisation function would configure these modules to read the value maps. Note, I wasnt sure how to do such a customisation function so any advice here would be welcome.

The only slightly tricky part was with the OOT photons which dont have PF isolation and so dont have a finalisation step. I added one for them and they should be untouched otherwise. @kmcdermo FYI

…::Photon

cmsbuild · 2018-01-08T14:46:07Z

The code-checks are being triggered in jenkins.

cmsbuild · 2018-01-08T14:48:15Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-21811/2802

cmsbuild · 2018-01-08T14:48:36Z

A new Pull Request was created by @Sam-Harper for master.

It involves the following packages:

DataFormats/EgammaCandidates
DataFormats/PatCandidates
PhysicsTools/PatAlgos
RecoEgamma/Configuration
RecoEgamma/EgammaElectronProducers
RecoEgamma/EgammaIsolationAlgos
RecoEgamma/EgammaPhotonProducers

@perrotta, @cmsbuild, @monttj, @slava77 can you please review it and eventually sign? Thanks.
@TaiSakuma, @gouskos, @jainshilpi, @rappoccio, @varuns23, @seemasharmafnal, @mmarionncern, @imarches, @ahinzmann, @acaudron, @lgray, @jdolen, @ferencek, @rovere, @jdamgov, @nhanvtran, @gkasieczka, @schoef, @JyothsnaKomaragiri, @mverzett, @cbernet, @gpetruc, @mariadalfonso, @pvmulder this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

slava77 · 2018-01-08T14:53:18Z

@cmsbuild please test

cmsbuild · 2018-01-08T14:53:36Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25327/console Started: 2018/01/08 15:54

kmcdermo · 2018-01-08T15:41:08Z

RecoEgamma/EgammaPhotonProducers/python/ootPhotons_cff.py

+
+ootPhotons = _gedPhotons.clone(
+    photonProducer = 'ootPhotonsTmp',
+    candidateP4type = "fromEcalEnergy",


@Sam-Harper , checking https://github.com/Sam-Harper/cmssw/blob/6e6a25fd65e53bbf5a43d99fecab8a2f46712896/RecoEgamma/EgammaPhotonProducers/src/GEDPhotonProducer.cc#L841-L843, this means that the regression is effectively skipped in the final step for ootPhotons, correct?

I guess the nice thing here is that, now the symmetry between ged and oot photons is closer with a tmp and final step for both, even if nothing really happens in the final step for oot photons.

Yes, the intention was to skip the regression for OOT photons.

cmsbuild · 2018-01-08T17:46:31Z

-1

Tested at: 6e6a25f

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21811/25327/summary.html

I found follow errors while testing this PR

Failed tests: RelVals AddOn

RelVals:

When I ran the RelVals I found an error in the following worklfows:
136.7611 step2

runTheMatrix-results/136.7611_RunJetHT2016E_reminiaod+RunJetHT2016E_reminiaod+REMINIAOD_data2016_HIPM+HARVESTDR2_REMINIAOD_data2016_HIPM/step2_RunJetHT2016E_reminiaod+RunJetHT2016E_reminiaod+REMINIAOD_data2016_HIPM+HARVESTDR2_REMINIAOD_data2016_HIPM.log

140.53 step2

runTheMatrix-results/140.53_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI/step2_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI.log

AddOn:

I found errors in the following addon tests:

cmsDriver.py RelVal -s HLT:HIon,RAW2DIGI,L1Reco,RECO --data --scenario=HeavyIons -n 10 --conditions auto:run2_data_HIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016,Run2_HI --processName=HLTRECO --filein file:RelVal_Raw_HIon_DATA.root --fileout file:RelVal_Raw_HIon_DATA_HLT_RECO.root : FAILED - time: date Mon Jan 8 18:19:37 2018-date Mon Jan 8 18:13:01 2018 s - exit: 16640
cmsDriver.py RelVal -s HLT:HIon,RAW2DIGI,L1Reco,RECO --mc --scenario=HeavyIons -n 10 --conditions auto:run2_mc_HIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_HI --processName=HLTRECO --filein file:RelVal_Raw_HIon_MC.root --fileout file:RelVal_Raw_HIon_MC_HLT_RECO.root : FAILED - time: date Mon Jan 8 18:24:37 2018-date Mon Jan 8 18:17:31 2018 s - exit: 16640

cmsbuild · 2018-01-08T17:46:33Z

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

Sam-Harper · 2018-01-31T14:52:34Z

thanks Andrea and Slava, I've updated the name now

cmsbuild · 2018-01-31T14:55:28Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-21811/3172

cmsbuild · 2018-01-31T14:55:52Z

Pull request #21811 was updated. @perrotta, @monttj, @cmsbuild, @franzoni, @slava77, @fabiocos, @davidlange6 can you please check and sign again.

slava77 · 2018-01-31T14:57:36Z

@cmsbuild please test

cmsbuild · 2018-01-31T14:57:56Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25803/console Started: 2018/01/31 15:58

cmsbuild · 2018-01-31T18:23:13Z

+1
Tested at: 8f2fc22
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21811/25803/summary.html

cmsbuild · 2018-01-31T18:23:15Z

Comparison job queued.

cmsbuild · 2018-01-31T19:45:17Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21811/25803/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-21811/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017

Comparison Summary:

No significant changes to the logs found
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 50 differences found in the comparisons
DQMHistoTests: Total files compared: 26
DQMHistoTests: Total histograms compared: 2463035
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2462865
DQMHistoTests: Total skipped: 169
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 1.00000000002 KiB( 22 files compared)
Checked 110 log files, 9 edm output root files, 26 DQM output files

perrotta · 2018-01-31T22:10:01Z

+1

ecal/hcalPFClusterIso() are filled for ged electrons/photons
output sizes do not increase: in fact the reco output even tinily shrinks, thanks to the removal of the floatedmValueMap's (as anticipated in the PR description)
latest jenkins tests show 50 differences in the comparisons: this is simply due to the introduction of those ecal/hcalPFClusterIso() in the monitored quantities for miniAOD. No other differences are observed, as expected

slava77 · 2018-02-02T18:30:52Z

@fabiocos
Please clarify your plans for this PR.
This contains a new modifier run2_miniAOD_94XFall17 which will be needed for re-miniAOD PRs and backports. If this PR will take longer than until Monday, then perhaps the feature introducing the new modifier will need to be split off into a separate PR (assuming that it can go in quickly).

fabiocos · 2018-02-06T19:01:28Z

+operations

fabiocos · 2018-02-06T19:01:39Z

+1

fabiocos · 2018-02-06T19:02:22Z

merge

moving PFCluster isolation to being stored in reco::GsfElectron, reco…

33ce9c9

…::Photon

cmsbuild added this to the CMSSW_10_0_X milestone Jan 8, 2018

cmsbuild added analysis-pending code-checks-pending comparison-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Jan 8, 2018

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 8, 2018

cmsbuild added tests-started and removed tests-pending labels Jan 8, 2018

kmcdermo reviewed Jan 8, 2018

View reviewed changes

cmsbuild added comparison-notrun tests-rejected and removed comparison-pending tests-started labels Jan 8, 2018

Sam-Harper force-pushed the EGPFClusterIsoInRECO branch from 6e6a25f to 29ee74c Compare January 9, 2018 14:21

cmsbuild added code-checks-pending and removed code-checks-approved comparison-notrun tests-rejected labels Jan 9, 2018

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 31, 2018

cmsbuild added tests-started and removed tests-pending labels Jan 31, 2018

cmsbuild added tests-approved and removed tests-started labels Jan 31, 2018

cmsbuild added comparison-available and removed comparison-pending labels Jan 31, 2018

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Jan 31, 2018

cmsbuild added operations-approved orp-approved and removed operations-pending orp-pending labels Feb 6, 2018

cmsbuild merged commit 6a6af8a into cms-sw:master Feb 6, 2018

slava77 mentioned this pull request Feb 13, 2018

matrix test workflows with run2_miniAOD_94XFall17 #22197

Closed

slava77 mentioned this pull request Feb 20, 2018

New trainings for mvaTauID + one backport from CMSSW_10_0_X #21977

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding PFClusterIsolation to reco Egamma objects #21811

Adding PFClusterIsolation to reco Egamma objects #21811

Sam-Harper commented Jan 8, 2018

cmsbuild commented Jan 8, 2018

cmsbuild commented Jan 8, 2018

cmsbuild commented Jan 8, 2018

slava77 commented Jan 8, 2018

cmsbuild commented Jan 8, 2018 •

edited

Loading

kmcdermo Jan 8, 2018

Sam-Harper Jan 8, 2018

cmsbuild commented Jan 8, 2018

cmsbuild commented Jan 8, 2018

Sam-Harper commented Jan 31, 2018

cmsbuild commented Jan 31, 2018

cmsbuild commented Jan 31, 2018

slava77 commented Jan 31, 2018

cmsbuild commented Jan 31, 2018 •

edited

Loading

cmsbuild commented Jan 31, 2018

cmsbuild commented Jan 31, 2018

cmsbuild commented Jan 31, 2018

perrotta commented Jan 31, 2018

slava77 commented Feb 2, 2018

fabiocos commented Feb 6, 2018

fabiocos commented Feb 6, 2018

fabiocos commented Feb 6, 2018

Adding PFClusterIsolation to reco Egamma objects #21811

Adding PFClusterIsolation to reco Egamma objects #21811

Conversation

Sam-Harper commented Jan 8, 2018

cmsbuild commented Jan 8, 2018

cmsbuild commented Jan 8, 2018

cmsbuild commented Jan 8, 2018

slava77 commented Jan 8, 2018

cmsbuild commented Jan 8, 2018 • edited Loading

kmcdermo Jan 8, 2018

Choose a reason for hiding this comment

Sam-Harper Jan 8, 2018

Choose a reason for hiding this comment

cmsbuild commented Jan 8, 2018

cmsbuild commented Jan 8, 2018

Sam-Harper commented Jan 31, 2018

cmsbuild commented Jan 31, 2018

cmsbuild commented Jan 31, 2018

slava77 commented Jan 31, 2018

cmsbuild commented Jan 31, 2018 • edited Loading

cmsbuild commented Jan 31, 2018

cmsbuild commented Jan 31, 2018

cmsbuild commented Jan 31, 2018

perrotta commented Jan 31, 2018

slava77 commented Feb 2, 2018

fabiocos commented Feb 6, 2018

fabiocos commented Feb 6, 2018

fabiocos commented Feb 6, 2018

cmsbuild commented Jan 8, 2018 •

edited

Loading

cmsbuild commented Jan 31, 2018 •

edited

Loading