Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

impose TMPDIR=/tmp/$USER #21682

Merged
merged 2 commits into from
Dec 13, 2017
Merged

impose TMPDIR=/tmp/$USER #21682

merged 2 commits into from
Dec 13, 2017

Conversation

perrozzi
Copy link

further evolution of #21419
according to
https://www.open-mpi.org/faq/?category=osx#startup-errors-with-open-mpi-2.0.x
The workaround for the Open MPI 2.0.x and v2.1.x release series is to set the TMPDIR environment variable to /tmp or other short directory name.
As far as I see from the example, the directory created in the TMPDIR path should be unique and related to the MPI session.
Most important, the written data seems to be cleaned up by MPI after use (i.e. if I point TMPDIR to any directory, it is empty after the job has either succeeded or failed)
@Dr15Jones @bbockelm

@perrozzi perrozzi changed the title impose TMPDIR=/tmp/perrozzi impose TMPDIR=/tmp/$USER Dec 11, 2017
@cmsbuild cmsbuild added this to the CMSSW_10_0_X milestone Dec 11, 2017
@perrozzi
Copy link
Author

please test

@cms-sw cms-sw deleted a comment from cmsbuild Dec 11, 2017
@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21682/2524

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 11, 2017 •
edited
Loading

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25026/console Started: 2017/12/11 11:31

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @perrozzi for master.

It involves the following packages:

GeneratorInterface/SherpaInterface

@cmsbuild, @efeyazgan, @perrozzi can you please review it and eventually sign? Thanks.
@alberto-sanchez, @agrohsje, @mkirsano, @thuer this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@efeyazgan
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

+1
Tested at: 7c73816
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21682/25026/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
d5a2e16
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21682/25026/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21682/25026/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21682/25026/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins-workarea/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-21682/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 27
  • DQMHistoTests: Total histograms compared: 2835241
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2835062
  • DQMHistoTests: Total skipped: 178
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.08999999997 KiB( 22 files compared)
  • Checked 113 log files, 9 edm output root files, 27 DQM output files

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@perrozzi
Copy link
Author

please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21682/2560

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 12, 2017 •
edited
Loading

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25063/console Started: 2017/12/12 22:34

@cmsbuild
Copy link
Contributor

Pull request #21682 was updated. @cmsbuild, @efeyazgan, @perrozzi can you please check and sign again.

@perrozzi perrozzi mentioned this pull request Dec 12, 2017
Merged
@perrozzi
Copy link
Author

implemented and tested suggestion from @bbockelm, it does what it supposed to do.
the problem might not be fully solved (i.e. is not for sure, but error rate should be much lower, in fact as discussed elsewhere and reminded by Liz at the ORP, we might need a "global strategy" for temporary directories, there as also issues of other kind, cfr https://hypernews.cern.ch/HyperNews/CMS/get/generators/3745)

@bbockelm
Copy link
Contributor

Yeah - it's best-practice to follow $TMPDIR when possible. However, this illustrates a case when $TMPDIR isn't usable.

On the site side, it's best to make /tmp unique per-job as not all software is adapted for $TMPDIR. In the case of Florida, there are available plugins for their batch system to do precisely this, but they choose not to run them. So, they've effectively nominated themselves as the sentinel for large files in /tmp; we update software we control on a best-effort basis and otherwise file bugs.

@cmsbuild
Copy link
Contributor

+1
Tested at: 10aeda2
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21682/25063/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
e2188ba
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21682/25063/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21682/25063/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21682/25063/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins-workarea/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-21682/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 27
  • DQMHistoTests: Total histograms compared: 2835241
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2835062
  • DQMHistoTests: Total skipped: 178
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.989999999969 KiB( 23 files compared)
  • Checked 113 log files, 9 edm output root files, 27 DQM output files

@davidlange6
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit e55ec72 into cms-sw:master Dec 13, 2017
@makortel makortel mentioned this pull request Sep 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code-checks-approved comparison-available generators-pending orp-approved pending-signatures tests-approved
Projects
None yet
Milestone
CMSSW_10_0_X
Development

Successfully merging this pull request may close these issues.
6 participants
@perrozzi @cmsbuild @efeyazgan @davidlange6 @Dr15Jones @bbockelm