-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added 3 sets of PS weights variations #21477
Conversation
The code-checks are being triggered in jenkins. |
+code-checks |
A new Pull Request was created by @jfernan2 for master. It involves the following packages: Configuration/Generator @cmsbuild, @efeyazgan, @perrozzi, @thuer, @govoni can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
The code-checks are being triggered in jenkins. |
Sorry, the right file now: it seems I did git add and the edit the file, so git took the file I used as starting point... |
+code-checks |
probably worth adding a sub-directory, like |
even if it is just a single file? |
yes to ease its search, otherwise one has to find it among other 400+ files... |
The code-checks are being triggered in jenkins. |
+code-checks |
please test |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
sorry naive question, I remember that there was a sqrt or square to apply from scale variations mu and pythia parameters, do I remember incorrectly? |
Not in this case since the weights nomenclature is taking that into account according to Pythia manual and Steve: |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Validation on:
I have tested the 3 PS weights configurations:
against central default.
As expected, the Conservative one gives large uncertainty in the FSR contribution specially at high jet multiplicities since weights get very large. Differences between Reduced and Default are small at large pT except at high jet multiplicities.
Conservative vs Default:
http://test-project-rivet.web.cern.ch/test-project-rivet/12041PSweightsConVSDef/CMS_2015_I1397174/index.html#CMS_2015_I1397174-d01-x01-y01
Reduced vs Default:
http://test-project-rivet.web.cern.ch/test-project-rivet/12041PSweightsRedVSDef/CMS_2015_I1397174/index.html#CMS_2015_I1397174-d01-x01-y01