Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 3 sets of PS weights variations #21477

Merged
merged 4 commits into from
Dec 12, 2017
Merged

Conversation

jfernan2
Copy link
Contributor

Validation on:
I have tested the 3 PS weights configurations:

  • sqrt(2) and 1/sqrt(2) (reduced)
  • 2 and 0.5 (default) -> this is the variation considered up to now in CMS samples
  • 4 and 0.25 (conservative)

against central default.

As expected, the Conservative one gives large uncertainty in the FSR contribution specially at high jet multiplicities since weights get very large. Differences between Reduced and Default are small at large pT except at high jet multiplicities.

Conservative vs Default:

http://test-project-rivet.web.cern.ch/test-project-rivet/12041PSweightsConVSDef/CMS_2015_I1397174/index.html#CMS_2015_I1397174-d01-x01-y01

Reduced vs Default:

http://test-project-rivet.web.cern.ch/test-project-rivet/12041PSweightsRedVSDef/CMS_2015_I1397174/index.html#CMS_2015_I1397174-d01-x01-y01

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21477/2217

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @jfernan2 for master.

It involves the following packages:

Configuration/Generator

@cmsbuild, @efeyazgan, @perrozzi, @thuer, @govoni can you please review it and eventually sign? Thanks.
@ghellwig, @Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@jfernan2
Copy link
Contributor Author

Sorry, the right file now: it seems I did git add and the edit the file, so git took the file I used as starting point...
Apologies...

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21477/2218

@cmsbuild
Copy link
Contributor

Pull request #21477 was updated. @cmsbuild, @efeyazgan, @perrozzi, @thuer, @govoni can you please check and sign again.

@perrozzi
Copy link

probably worth adding a sub-directory, like PSweigts or similar ?

@jfernan2
Copy link
Contributor Author

even if it is just a single file?

@perrozzi
Copy link

yes to ease its search, otherwise one has to find it among other 400+ files...
(and we could also store mulitple snippets in case of need)

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21477/2221

@cmsbuild
Copy link
Contributor

Pull request #21477 was updated. @cmsbuild, @efeyazgan, @perrozzi, @thuer, @govoni can you please check and sign again.

@efeyazgan
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 28, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24728/console Started: 2017/11/28 20:14

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21477/24728/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 27
  • DQMHistoTests: Total histograms compared: 2833444
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2833265
  • DQMHistoTests: Total skipped: 178
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.43000000005 KiB( 23 files compared)
  • Checked 111 log files, 8 edm output root files, 27 DQM output files

@perrozzi
Copy link

sorry naive question, I remember that there was a sqrt or square to apply from scale variations mu and pythia parameters, do I remember incorrectly?

@jfernan2
Copy link
Contributor Author

Not in this case since the weights nomenclature is taking that into account according to Pythia manual and Steve:
http://home.thep.lu.se/~torbjorn/pythia82html/Variations.html

@efeyazgan
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants