-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
StallMonitor handles case where module does not prefetch #20964
StallMonitor handles case where module does not prefetch #20964
Conversation
The PathStatusInserter framework modules do not prefetch data (since they do not need it) and therefore the signal about prefetching is never set. This caused StallMonitor to incorrectly assign large stall times to these modules.
There has been a request to have StallMonitor in all production jobs. This change will avoid having the StallMonitor give bogus results for the PathStatus generators. |
A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_9_3_X. It involves the following packages: FWCore/Services @cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
please test |
+1 |
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_3_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_9_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2) |
backport #20678 |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
The PathStatusInserter framework modules do not prefetch data (since they do not need it) and therefore the signal about prefetching is never set. This caused StallMonitor to incorrectly assign large stall times to these modules.