-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NanoAOD: runTheMatrix and cmsDriver support #20905
Conversation
The code-checks are being triggered in jenkins. |
+code-checks |
A new Pull Request was created by @arizzi for master. It involves the following packages: Configuration/Applications @prebello, @kpedro88, @fabozzi, @cmsbuild, @franzoni, @GurpreetSinghChahal, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@arizzi |
@slava77 I explicitelly removed it because we are not sure if the production infrastructure will handle it when making relvals. The plan is:
(in fact 2659b76 explictelly disable those workflows) |
adding a workflow to runTheMatrix has no effect on what is submitted to the relval system... Go ahead and add it back so it gets tested (aside from the production infrastructure) normally (and we can all more easily agree on what _should_ be tested in relvals once ready to do so.
… On Oct 12, 2017, at 2:40 PM, arizzi ***@***.***> wrote:
@slava77 I explicitelly removed it because we are not sure if the production infrastructure will handle it when making relvals. The plan is:
• in pre3 we test injecting by hand that Nano do not spoil anything
• once the above is verified we enable the workflows in the short list
(in fact 2659b76 explictelly disable those workflows)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
@davidlange6 see the comments from @fabozzi on #20626 The workflows are anyhow tested with runtests.sh implemented and already merged in #20626 |
right - that is presumably why @slava77 suggested to "add one workflow".
… On Oct 12, 2017, at 2:48 PM, arizzi ***@***.***> wrote:
@davidlange6 see the comments from @fabozzi on #20626
The workflows are anyhow tested with runtests.sh implemented and already merged in #20626
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
The code-checks are being triggered in jenkins. |
+code-checks |
Pull request #20905 was updated. @prebello, @kpedro88, @fabozzi, @cmsbuild, @franzoni, @GurpreetSinghChahal, @davidlange6 can you please check and sign again. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
you guys want to retrigger the tests with the update in the cmsDrivers in runtests.sh ? |
please test |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
merge |
this PR adds cmsDriver support for nanoAOD and some workflows in runTheMatrix.
In this PR we do NOT add NanoAOD to the standard runTheMatrix workflows and relvals so that we avoid spoiling the relval production with unknown output module.
On the other hand some workflows are defined to do dedicated tests of NanoAOD production
runTheMatrix.py -l '1325.6,1325.7,1325.8,1329.1'
and can be used for injections tests
@gpetruc @fabozzi