Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NanoAOD: runTheMatrix and cmsDriver support #20905

Merged
merged 14 commits into from
Oct 14, 2017

Conversation

arizzi
Copy link
Contributor

@arizzi arizzi commented Oct 12, 2017

this PR adds cmsDriver support for nanoAOD and some workflows in runTheMatrix.

In this PR we do NOT add NanoAOD to the standard runTheMatrix workflows and relvals so that we avoid spoiling the relval production with unknown output module.

On the other hand some workflows are defined to do dedicated tests of NanoAOD production
runTheMatrix.py -l '1325.6,1325.7,1325.8,1329.1'

and can be used for injections tests

@gpetruc @fabozzi

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20905/1421

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @arizzi for master.

It involves the following packages:

Configuration/Applications
Configuration/EventContent
Configuration/PyReleaseValidation

@prebello, @kpedro88, @fabozzi, @cmsbuild, @franzoni, @GurpreetSinghChahal, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @felicepantaleo, @ebrondol, @Martin-Grunewald, @makortel this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@slava77
Copy link
Contributor

slava77 commented Oct 12, 2017

@arizzi
Copy link
Contributor Author

arizzi commented Oct 12, 2017

@slava77 I explicitelly removed it because we are not sure if the production infrastructure will handle it when making relvals. The plan is:

  • in pre3 we test injecting by hand that Nano do not spoil anything
  • once the above is verified we enable the workflows in the short list

(in fact 2659b76 explictelly disable those workflows)

@davidlange6
Copy link
Contributor

davidlange6 commented Oct 12, 2017 via email

@arizzi
Copy link
Contributor Author

arizzi commented Oct 12, 2017

@davidlange6 see the comments from @fabozzi on #20626

The workflows are anyhow tested with runtests.sh implemented and already merged in #20626

@davidlange6
Copy link
Contributor

davidlange6 commented Oct 12, 2017 via email

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20905/1424

@cmsbuild
Copy link
Contributor

Pull request #20905 was updated. @prebello, @kpedro88, @fabozzi, @cmsbuild, @franzoni, @GurpreetSinghChahal, @davidlange6 can you please check and sign again.

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20905/23724/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2767051
  • DQMHistoTests: Total failures: 101
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2766779
  • DQMHistoTests: Total skipped: 171
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 10 edm output root files, 26 DQM output files

@arizzi
Copy link
Contributor Author

arizzi commented Oct 13, 2017

you guys want to retrigger the tests with the update in the cmsDrivers in runtests.sh ?

@fabozzi
Copy link
Contributor

fabozzi commented Oct 13, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 13, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23751/console Started: 2017/10/13 10:08

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20905/23751/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2767139
  • DQMHistoTests: Total failures: 102
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2766866
  • DQMHistoTests: Total skipped: 171
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 10 edm output root files, 26 DQM output files

@fabozzi
Copy link
Contributor

fabozzi commented Oct 13, 2017

+1

@davidlange6
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 36b949b into cms-sw:master Oct 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants