Fix unused vars warnings in Reco pkgs

[mrodozov]

Fix the warnings listed here
https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc6_amd64_gcc630/CMSSW_9_4_X_2017-10-09-2300/RecoParticleFlow/PFProducer
https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc6_amd64_gcc630/CMSSW_9_4_X_2017-10-09-2300/RecoEcal/EgammaCoreTools

[cmsbuild]

The code-checks are being triggered in jenkins.

[mrodozov]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20876/1345

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23637/console Started: 2017/10/10 15:05

[cmsbuild]

A new Pull Request was created by @mrodozov for master.

It involves the following packages:

RecoEcal/EgammaCoreTools
RecoParticleFlow/PFProducer

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@mmarionncern, @Sam-Harper, @jainshilpi, @argiro, @bachtis, @cbernet, @lgray, @varuns23, @seemasharmafnal this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

[mrodozov]

please test

[cmsbuild]

+1
Tested at: ac31425
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20876/23637/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
02d60c8
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20876/23637/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20876/23637/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20876/23637/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 26
• DQMHistoTests: Total histograms compared: 2764467
• DQMHistoTests: Total failures: 108
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2764188
• DQMHistoTests: Total skipped: 171
• DQMHistoTests: Total Missing objects: 0
• Checked 107 log files, 10 edm output root files, 26 DQM output files

[slava77]

+1

for #20876 ac31425

• technical; unused variables appear to be there from past developments or debugs no longer present/necessary
• jenkins tests pass

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

[davidlange6]

+1