Protect against missing track info in MiniAOD #20741
Conversation
|
The code-checks are being triggered in jenkins. |
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20741/1141 Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/PR-20741/1141/git-diff.patch You can run |
|
passing code-checks is required. |
| internalId_.d0_ = std::abs(pfTrk->dxy(vtx->position())); | ||
| internalId_.dZ_ = std::abs(pfTrk->dz(vtx->position())); | ||
| } | ||
| if(lPack!=nullptr) { |
There was a problem hiding this comment.
you already have an isPacked bool variable that you can use without needing to check the existence of the pointer every time
| @@ -393,10 +393,19 @@ PileupJetIdentifier PileupJetIdAlgo::computeIdVariables(const reco::Jet * jet, f | |||
| //To handle the electron case | |||
| if(lPF!=nullptr) { | |||
There was a problem hiding this comment.
Shouldn't this be considered with an "else if" after the block started at L399?
With the present logic, if (isPacked) the d0 and dz saved here will be rewritten anyhow
|
The code-checks are being triggered in jenkins. |
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20741/1303 Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/PR-20741/1303/git-diff.patch You can run |
|
@ahinzmann : you still need to apply the code-checks, as explained in #20741 (comment). Without them the tests cannot be launched in github. |
|
The code-checks are being triggered in jenkins. |
|
+code-checks |
|
please test |
|
Matrix error failure is unrelated, likely due to the merging of #20693 |
|
please test |
cmsbuild
added
comparison-pending
tests-pending
and removed
comparison-notrun
tests-rejected
labels
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1
|
cmsbuild
added
fully-signed
reconstruction-approved
and removed
pending-signatures
reconstruction-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
When pileup jet ID is reran on top of an existing MiniAOD, it crashes due to missing tracking information.
The fix sets the corresponding variables to default values if no information is available.
The affected variables are not used in the default MVA training of pileup jet ID, thus have no effect on the observable used in analyses.
Backport to 93 for analyses: #20740