Silent getSiThickness::InvalidSiliconDetid

[rovere]

No description provided.

[cmsbuild]

A new Pull Request was created by @rovere (Marco Rovere) for CMSSW_9_3_X.

It involves the following packages:

RecoLocalCalo/HGCalRecAlgos

@perrotta, @cmsbuild, @kpedro88, @slava77 can you please review it and eventually sign? Thanks.
@edjtscott, @vandreev11, @sethzenz, @felicepantaleo, @kpedro88, @argiro, @cseez, @pfs, @lgray this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

• Backported from Silent getSiThickness::InvalidSiliconDetid #20660

[kpedro88]

@rovere can you do the same for getRadiusToSide()? It hasn't been a problem so far, but just in case.

[rovere]

@kpedro88 there are plenty of other LogError in that same file.
I could easily s/LogError/LogDebug/g but I did only for the thickness since there we tested that the code is ok. Not sure about all the others (few of them return meaningless data if the check fails).
This has to be reviewed properly, better by an HGCAL geometry expert, for the current and future geometries.

[kpedro88]

Ah, there are a few more. I see getWafer() and getCell() as well.

I would prefer to suppress all of them, since they all have the same problematic behavior (triggering on HCAL DetIds).

[rovere]

Address #20658

[kpedro88]

backport of #20660

[kpedro88]

Let's deal with the other messages in a followup PR.

[kpedro88]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23251/console Started: 2017/09/27 16:17

[cmsbuild]

+1
Tested at: adf09d2
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20659/23251/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
eea683a
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20659/23251/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20659/23251/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20659/23251/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 26
• DQMHistoTests: Total histograms compared: 2645486
• DQMHistoTests: Total failures: 197
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2645100
• DQMHistoTests: Total skipped: 189
• DQMHistoTests: Total Missing objects: 0
• Checked 107 log files, 14 edm output root files, 26 DQM output files

[kpedro88]

+1

[slava77]

+1

for #20659 adf09d2

• same as Silent getSiThickness::InvalidSiliconDetid #20660 dcd7d18 in 93X; to silence inappropriately issued LogError
• jenkins tests pass and show that the error message is gone from the logs

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_9_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

[davidlange6]

+1